From: Steven Toth <stoth@linuxtv.org>
To: Chaogui Zhang <czhang1974@gmail.com>
Cc: video4linux-list@redhat.com, linux-dvb@linuxtv.org
Subject: Wanted 800i QAM tested - please reivew... Was: Re: [PATCH] xc5000.c xc_write_reg() wait time
Date: Thu, 31 Jul 2008 21:38:19 -0400 [thread overview]
Message-ID: <4892690B.3050902@linuxtv.org> (raw)
In-Reply-To: <20080731221619.GA4599@gauss.marywood.edu>
Chaogui Zhang wrote:
> This patch fixes the incorrect wait time in xc_write_reg(). Before the
> patch, my Pinnacle PCTV HD 800i cannot tune to any QAM channels. After
> the patch, it found all the channels without problems.
>
> This was previously submitted back in January, as part of a much
> bigger patch involving other stuff. The other parts involve hybrid tuner
> instance handling, and some code clean up. The tuner instance handling
> part is obsolete now since Mike Krufky's tuner refactoring code does
> precisely that and in a more efficient way, even though the xc5000 tuner
> code has not been modified to take advantage of that yet.
>
> Just for reference, the previous patch in the following thread:
>
> http://www.linuxtv.org/pipermail/linux-dvb/2008-January/023392.html
>
> --
>
> Signed-off-by: Chaogui Zhang <czhang1974@gmail.com>
>
> diff -r 55e8c99c8aa8 linux/drivers/media/common/tuners/xc5000.c
> --- a/linux/drivers/media/common/tuners/xc5000.c Wed Jul 30 07:18:13 2008 -0300
> +++ b/linux/drivers/media/common/tuners/xc5000.c Thu Jul 31 17:43:31 2008 -0400
> @@ -250,7 +250,7 @@
> /* busy flag cleared */
> break;
> } else {
> - xc_wait(100); /* wait 5 ms */
> + xc_wait(5); /* wait 5 ms */
> WatchDogTimer--;
> }
> }
During development, using a remote users dev system the 100 value works
reliably on his 800i for QAM, it also works very reliably on my QAM /
ATSC systems. I'm not ware of any QAM issues across multiple vendors
products with the 100 value.
I'm pretty skeptical about this creating QAM issues.
Does anyone else here have an 800i with QAM issues? (I'm changing the
subject thread to attract other users).
- Steve
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-08-01 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 22:16 [PATCH] xc5000.c xc_write_reg() wait time Chaogui Zhang
2008-08-01 1:38 ` Steven Toth [this message]
2008-08-01 5:01 ` [linux-dvb] Wanted 800i QAM tested - please reivew... Was: " Andreas
2008-08-01 13:52 ` Steven Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4892690B.3050902@linuxtv.org \
--to=stoth@linuxtv.org \
--cc=czhang1974@gmail.com \
--cc=linux-dvb@linuxtv.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox