From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] media: Set entity->links NULL in cleanup
Date: Thu, 17 Jul 2014 14:13:40 +0200 [thread overview]
Message-ID: <4899501.NLaQ1XGmm5@avalon> (raw)
In-Reply-To: <20140717115349.GN16460@valkosipuli.retiisi.org.uk>
On Thursday 17 July 2014 14:53:49 Sakari Ailus wrote:
> On Thu, Jul 17, 2014 at 01:43:09PM +0200, Laurent Pinchart wrote:
> > On Tuesday 27 May 2014 16:27:49 Sakari Ailus wrote:
> > > Calling media_entity_cleanup() on a cleaned-up entity would result into
> > > double free of the entity->links pointer and likely memory corruption as
> > > well.
> >
> > My first question is, why would anyone do that ? :-)
>
> Because it makes error handling easier. Many cleanup functions work this
> way, but not media_entity_cleanup().
Do the cleanup functions support being called multiple times, or do they just
support being called on memory that has been zeroed and not further
initialized ? The media_entity_cleanup() function supports the latter.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-07-17 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 13:27 [PATCH 1/1] media: Set entity->links NULL in cleanup Sakari Ailus
2014-07-17 11:43 ` Laurent Pinchart
2014-07-17 11:53 ` Sakari Ailus
2014-07-17 12:13 ` Laurent Pinchart [this message]
2014-09-24 9:17 ` Sakari Ailus
2014-09-26 14:20 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4899501.NLaQ1XGmm5@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox