public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [linux-dvb] [PATCH] Add initial support for DViCO FusionHDTV DVB-T Dual Express
@ 2008-08-07 10:58 stev391
  2008-08-07 15:00 ` Steven Toth
  2008-08-16  4:28 ` David
  0 siblings, 2 replies; 32+ messages in thread
From: stev391 @ 2008-08-07 10:58 UTC (permalink / raw)
  To: Tim Farrington, David; +Cc: linux-dvb


[-- Attachment #1.1: Type: text/plain, Size: 1914 bytes --]

Tim, David,



I like top posting, then I don't have to scroll too far for the main 
information.

The firmware file is incorrect, if it states only 3 firmware images 
loaded then it is wrong (it should be 80). Here is what that line 
should read:
[  154.867137] xc2028 3-0061: Loading 80 firmware images from xc3028-v27.fw, type: xc2028 firmware, ver 2.7

Make sure you are using the correct extract script and follow the 
instructions in the header (script is in the linux/Documentation/video4linux)

Also, the "new" firmware does work in Australia as this is where I 
live... (Melbourne, and it has been tested against 3 different 
transmitters here [1 of which is Mt Dandenong], with varying reception levels. 
The card has really good sensitivity however it can easily be drowned out if 
you have an amplifier).

If you still have trouble load the following modules with debug = 1:
cx23885
zl10353
tuner_xc2028

Regards,

Stephen.


----Original Message----
Message: 1
Date: Thu, 07 Aug 2008 15:52:15 +0800
From: Tim Farrington <timf@iinet.net.au>
Subject: Re: [linux-dvb] [PATCH] Add initial support for DViCO
        FusionHDTV DVB-T Dual Express
To: David <dvb-t@iinet.com.au>
Cc: patrick.claven@manildra.com.au, linux-dvb@linuxtv.org
Message-ID: <489AA9AF.2060803@iinet.net.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed


The point is that the developers are trying to incorporate Chris's work
into the
main v4l-dvb driver.

Chris's original firmware requirements were:
dvb-usb-bluebird-01.fw xc3028-dvico-au-01.fw dvb-usb-bluebird-02.fw

whereas now it needs:
xc3028-v27.fw

It seems that the "new" firmware doesn't work as of yet for Australia,
for this device.

IIRC, Chris had an "offset" for Australia.

Regards,
Timf

-- 
Be Yourself @ mail.com!
Choose From 200+ Email Addresses
Get a Free Account at www.mail.com


[-- Attachment #1.2: Type: text/html, Size: 2828 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 32+ messages in thread
* Re: [linux-dvb] [PATCH] Add initial support for DViCO FusionHDTV DVB-T Dual Express
@ 2008-08-08  0:04 stev391
  0 siblings, 0 replies; 32+ messages in thread
From: stev391 @ 2008-08-08  0:04 UTC (permalink / raw)
  To: Steven Toth; +Cc: linux-dvb


[-- Attachment #1.1: Type: text/plain, Size: 1102 bytes --]

  From: "Steven Toth"
  To: stev391@email.com
  Subject: Re: [linux-dvb] [PATCH] Add initial support for DViCO
  FusionHDTV DVB-T Dual Express
  Date: Thu, 07 Aug 2008 11:00:08 -0400


  stev391@email.com wrote:
  > Tim, David,
  >
  > I like top posting, then I don't have to scroll too far for the
  > main information.

  We have a convention on this mailing list, we don't top post.

  - Steve

----- End Original Message -----


I apologise, I was not aware of this convention.

I'm satisfied that this patch (as applied in Steven Toths, v4l-dvb
branch) does not break any of the current supported features of this
driver and have successfully tested it in varying conditions (different
receptions levels, different frequencies [uhf & vhf], in Australia).

Steve here is my reviewed by line, if you want to add it into the commit:
Add initial support for DViCO FusionHDTV DVB-T Dual Express
Reviewed-by: Stephen Backway <stev391@email.com>

Regards,

Stephen

-- 
Be Yourself @ mail.com!
Choose From 200+ Email Addresses
Get a Free Account at www.mail.com


[-- Attachment #1.2: Type: text/html, Size: 1458 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 32+ messages in thread
* Re: [linux-dvb] [PATCH] Add initial support for DViCO FusionHDTV DVB-T Dual Express
@ 2008-08-05 11:52 stev391
  0 siblings, 0 replies; 32+ messages in thread
From: stev391 @ 2008-08-05 11:52 UTC (permalink / raw)
  To: Steven Toth; +Cc: linux-dvb, linuxdvb


[-- Attachment #1.1: Type: text/plain, Size: 1771 bytes --]

 Steve,

I have successfully run this branch on my dev machine and tried various
conditions to see if I can make it break.

Just one question regarding the new tuner callback.  Why is the mdelay
now set at 200 for the reset?  In the callback I was using for this card
previously this was set at 5. This hasn't caused any performance issues
that I have noticed, but why wait that extra 195milliseconds?

I have just applied this branch to my HTPC and will see how it performs
over the next couple of days and will get back to you with a sign off for
you to include, if you like.

Regards,

Stephen

  ----- Original Message -----
  From: "Steven Toth"
  To: stev391@email.com
  Subject: Re: [linux-dvb] [PATCH] Add initial support for DViCO
  FusionHDTV DVB-T Dual Express
  Date: Mon, 04 Aug 2008 21:25:56 -0400


  stev391@email.com wrote:
  > Anton,
  >
  > Thankyou for cleaning this code up (and you as well Steven).
  >
  > I have been meaning to do some more work on this lately, but you
  > have taken it to were I was hoping to go.
  >
  > Steven, I can test your cleaned up code as well, just drop me an
  > email and I will run it on my machines (I have several that I
  > have access to with these cards in them, with various other
  > cards).

  Stephen / Anton,

  http://linuxtv.org/hg/~stoth/v4l-dvb

  This has Anton's patches and a subsequent cleanup patch to merge
  the single tune callback functions into a single entity. A much
  better solution all-round.

  I've tested with the HVR1500Q (xc5000 based) and I'm happy with the
  results. Can you both try the DViCO board?

  Thanks,

  Steve

-- 
Be Yourself @ mail.com!
Choose From 200+ Email Addresses
Get a Free Account at www.mail.com


[-- Attachment #1.2: Type: text/html, Size: 2190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 32+ messages in thread
* Re: [linux-dvb] [PATCH] Add initial support for DViCO FusionHDTV DVB-T Dual Express
@ 2008-08-01  3:40 stev391
  2008-08-01 12:34 ` bumkunjo
  2008-08-05  1:25 ` Steven Toth
  0 siblings, 2 replies; 32+ messages in thread
From: stev391 @ 2008-08-01  3:40 UTC (permalink / raw)
  To: Anton Blanchard, Steven Toth; +Cc: linux-dvb, stev391@email.com, linuxdvb


[-- Attachment #1.1: Type: text/plain, Size: 1068 bytes --]

 Anton,

Thankyou for cleaning this code up (and you as well Steven).

I have been meaning to do some more work on this lately, but you have
taken it to were I was hoping to go.

Steven, I can test your cleaned up code as well, just drop me an email
and I will run it on my machines (I have several that I have access to
with these cards in them, with various other cards).

Regards,

Stephen.

  ----- Original Message -----
  From: "Anton Blanchard"
  To: "Steven Toth"
  Subject: Re: [linux-dvb] [PATCH] Add initial support for DViCO
  FusionHDTV DVB-T Dual Express
  Date: Fri, 1 Aug 2008 12:55:13 +1000



  Hi,

  > At this stage I think I can add a final patch to get back to a
  > single callback directly, regardless of tuner type. (this
  > weekend)

  Great!

  > I don't have your specific DViCO card, I assume you're willing to
  > re-test with my cleanup patch?

  Yep I have the card and will re-test.

  Anton

-- 
Be Yourself @ mail.com!
Choose From 200+ Email Addresses
Get a Free Account at www.mail.com


[-- Attachment #1.2: Type: text/html, Size: 1472 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 32+ messages in thread
* [linux-dvb] [PATCH] Add initial support for DViCO FusionHDTV DVB-T Dual Express
@ 2008-06-30 23:56 stev391
       [not found] ` <20080731042433.GA21788@kryten>
  0 siblings, 1 reply; 32+ messages in thread
From: stev391 @ 2008-06-30 23:56 UTC (permalink / raw)
  To: linux dvb; +Cc: Michael Krufky


[-- Attachment #1.1: Type: text/plain, Size: 7620 bytes --]

Add initial support for DViCO FusionHDTV DVB-T Dual Express

From: Stephen Backway <stev391@email.com>

Add initial support (Note: Only one tuner is activated, due to issues
with the
SRAM definitions. Once fixed this will be enabled).  The analog portion
of the
card is not configured.  Original work to support this card was completed
by
Chris Pascoe, however this was never merged into the main tree.  Minor
changes
were required to ensure that the card worked correctly, namely the
callback
function, kernel config and various debugging messages.

Signed-off-by: Stephen Backway <stev391@email.com>

diff -Naur v4l-dvb/linux/Documentation/video4linux/CARDLIST.cx23885
v4l-dvb_dev/linux/Documentation/video4linux/CARDLIST.cx23885
--- v4l-dvb/linux/Documentation/video4linux/CARDLIST.cx23885   
2008-06-09 14:13:20.000000000 +1000
+++ v4l-dvb_dev/linux/Documentation/video4linux/CARDLIST.cx23885   
2008-06-30 21:06:19.000000000 +1000
@@ -9,3 +9,4 @@
8 -> Hauppauge WinTV-HVR1700                             [0070:8101]
9 -> Hauppauge WinTV-HVR1400                             [0070:8010]
10 -> DViCO FusionHDTV7 Dual Express                      [18ac:d618]
+ 11 -> DViCO FusionHDTV DVB-T Dual Express                 [18ac:db78]
diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885-cards.c
v4l-dvb_dev/linux/drivers/media/video/cx23885/cx23885-cards.c
--- v4l-dvb/linux/drivers/media/video/cx23885/cx23885-cards.c   
2008-06-09 14:13:21.000000000 +1000
+++ v4l-dvb_dev/linux/drivers/media/video/cx23885/cx23885-cards.c   
2008-06-30 21:08:18.000000000 +1000
@@ -151,6 +151,13 @@
 #endif
.portc    = CX23885_MPEG_DVB,
},
+    [CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP] = {
+    .name    = "DViCO FusionHDTV DVB-T Dual Express",
+#if 0
+    .portb    = CX23885_MPEG_DVB,
+#endif
+    .portc    = CX23885_MPEG_DVB,
+    },
 };
 const unsigned int cx23885_bcount = ARRAY_SIZE(cx23885_boards);

@@ -222,7 +229,11 @@
.subvendor = 0x18ac,
.subdevice = 0xd618,
.card      = CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP,
-    },
+    }, {
+    .subvendor = 0x18ac,
+    .subdevice = 0xdb78,
+    .card      = CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP,
+ },
 };
 const unsigned int cx23885_idcount = ARRAY_SIZE(cx23885_subids);

@@ -439,6 +450,13 @@
mdelay(20);
cx_set(GP0_IO, 0x00050005);
break;
+    case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP:
+    /* GPIO-0 portb xc3028 reset */
+    /* GPIO-1 portb zl10353 reset */
+    /* GPIO-2 portc xc3028 reset */
+    /* GPIO-3 portc zl10353 reset */
+    cx_write(GP0_IO, 0x002f1000);
+    break;
}
 }

@@ -453,7 +471,10 @@
case CX23885_BOARD_HAUPPAUGE_HVR1400:
/* FIXME: Implement me */
break;
-    }
+    case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP:
+    request_module("ir-kbd-i2c");
+    break;
+ }

return 0;
 }
@@ -490,6 +511,7 @@

switch (dev->board) {
case CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP:
+    case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP:
ts2->gen_ctrl_val  = 0xc; /* Serial bus + punctured clock */
ts2->ts_clk_en_val = 0x1; /* Enable TS_CLK */
ts2->src_sel_val   = CX23885_SRC_SEL_PARALLEL_MPEG_VIDEO;
diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885-dvb.c
v4l-dvb_dev/linux/drivers/media/video/cx23885/cx23885-dvb.c
--- v4l-dvb/linux/drivers/media/video/cx23885/cx23885-dvb.c    2008-06-09
14:13:21.000000000 +1000
+++ v4l-dvb_dev/linux/drivers/media/video/cx23885/cx23885-dvb.c   
2008-06-30 21:06:19.000000000 +1000
@@ -36,9 +36,11 @@
 #include "tda8290.h"
 #include "tda18271.h"
 #include "lgdt330x.h"
+#include "zl10353.h"
 #include "xc5000.h"
 #include "tda10048.h"
 #include "tuner-xc2028.h"
+#include "tuner-xc2028-types.h"
 #include "tuner-simple.h"
 #include "dib7000p.h"
 #include "dibx000_common.h"
@@ -155,6 +157,44 @@
.serial_mpeg = 0x40,
 };

+static int cx23885_dvico_xc2028_callback(void *ptr, int command, int
arg)
+{
+    struct cx23885_tsport *port = ptr;
+    struct cx23885_dev *dev = port->dev;
+    u32 reset_mask = 0;
+
+    switch (command) {
+    case XC2028_TUNER_RESET:
+    dprintk(1, "%s: XC2028_TUNER_RESET %d, port %d\n", __func__,
+    arg, port->nr);
+
+    if (port->nr == 0)
+    reset_mask = 0x0101;
+    else if (port->nr == 1)
+    reset_mask = 0x0404;
+
+    cx_clear(GP0_IO, reset_mask);
+    mdelay(5);
+    cx_set(GP0_IO, reset_mask);
+    break;
+    case XC2028_RESET_CLK:
+    dprintk(1, "%s: XC2028_RESET_CLK %d\n", __func__, arg);
+    break;
+    default:
+    dprintk(1, "%s: unknown command %d, arg %d\n", __func__,
+    command, arg);
+    return -EINVAL;
+    }
+
+    return 0;
+}
+
+static struct zl10353_config dvico_fusionhdtv_xc3028 = {
+    .demod_address = 0x0f,
+    .if2           = 45600,
+    .no_tuner      = 1,
+};
+
 static struct s5h1409_config hauppauge_hvr1500q_config = {
.demod_address = 0x32 >> 1,
.output_mode   = S5H1409_SERIAL_OUTPUT,
@@ -481,7 +521,39 @@
&i2c_bus->i2c_adap,
&dvico_xc5000_tunerconfig, i2c_bus);
break;
-    default:
+    case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP:
+    i2c_bus = &dev->i2c_bus[port->nr - 1];
+
+    /* Take demod and tuner out of reset */
+    if (port->nr == 1)
+    cx_set(GP0_IO, 0x0303);
+    else if (port->nr == 2)
+    cx_set(GP0_IO, 0x0c0c);
+    mdelay(5);
+    port->dvb.frontend = dvb_attach(zl10353_attach,
+    &dvico_fusionhdtv_xc3028,
+    &i2c_bus->i2c_adap);
+    if (port->dvb.frontend != NULL) {
+    struct dvb_frontend      *fe;
+    struct xc2028_config    cfg = {
+    .i2c_adap  = &i2c_bus->i2c_adap,
+    .i2c_addr  = 0x61,
+    .video_dev = port,
+    .callback  = cx23885_dvico_xc2028_callback,
+    };
+    static struct xc2028_ctrl ctl = {
+    .fname       = "xc3028-v27.fw",
+    .max_len     = 64,
+    .demod       = XC3028_FE_ZARLINK456,
+    };
+
+    fe = dvb_attach(xc2028_attach, port->dvb.frontend,
+    &cfg);
+    if (fe != NULL && fe->ops.tuner_ops.set_config != NULL)
+    fe->ops.tuner_ops.set_config(fe, &ctl);
+    }
+    break;
+ default:
printk("%s: The frontend of your DVB/ATSC card isn't supported yet\n",
dev->name);
break;
diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/cx23885.h
v4l-dvb_dev/linux/drivers/media/video/cx23885/cx23885.h
--- v4l-dvb/linux/drivers/media/video/cx23885/cx23885.h    2008-06-09
14:13:21.000000000 +1000
+++ v4l-dvb_dev/linux/drivers/media/video/cx23885/cx23885.h    2008-06-30
21:06:19.000000000 +1000
@@ -67,6 +67,7 @@
 #define CX23885_BOARD_HAUPPAUGE_HVR1700        8
 #define CX23885_BOARD_HAUPPAUGE_HVR1400        9
 #define CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP 10
+#define CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP 11

 /* Currently unsupported by the driver: PAL/H, NTSC/Kr, SECAM B/G/H/LC
*/
 #define CX23885_NORMS (\
diff -Naur v4l-dvb/linux/drivers/media/video/cx23885/Kconfig
v4l-dvb_dev/linux/drivers/media/video/cx23885/Kconfig
--- v4l-dvb/linux/drivers/media/video/cx23885/Kconfig    2008-05-15
19:47:08.000000000 +1000
+++ v4l-dvb_dev/linux/drivers/media/video/cx23885/Kconfig    2008-06-30
21:06:19.000000000 +1000
@@ -15,6 +15,7 @@
select MEDIA_TUNER_MT2131 if !DVB_FE_CUSTOMISE
select DVB_S5H1409 if !DVB_FE_CUSTOMISE
select DVB_LGDT330X if !DVB_FE_CUSTOMISE
+ select DVB_ZL10353 if !DVB_FE_CUSTOMISE
select MEDIA_TUNER_XC2028 if !DVB_FE_CUSTOMIZE
select MEDIA_TUNER_TDA8290 if !DVB_FE_CUSTOMIZE
select MEDIA_TUNER_TDA18271 if !DVB_FE_CUSTOMIZE

-- 
Be Yourself @ mail.com!
Choose From 200+ Email Addresses
Get a Free Account at www.mail.com


[-- Attachment #1.2: Type: text/html, Size: 14037 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 32+ messages in thread
end of thread, other threads:[~2008-08-16  4:29 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-07 10:58 [linux-dvb] [PATCH] Add initial support for DViCO FusionHDTV DVB-T Dual Express stev391
2008-08-07 15:00 ` Steven Toth
2008-08-16  4:28 ` David
  -- strict thread matches above, loose matches on Subject: below --
2008-08-08  0:04 stev391
2008-08-05 11:52 stev391
2008-08-01  3:40 stev391
2008-08-01 12:34 ` bumkunjo
2008-08-05  1:25 ` Steven Toth
     [not found]   ` <1217969890.6864.11.camel@bonnie>
2008-08-05 21:16     ` Steven Toth
2008-08-05 21:43   ` Anton Blanchard
2008-08-05 23:41     ` Luke Yelavich
2008-08-06  1:44       ` Steven Toth
2008-08-06  8:09         ` David Porter
2008-08-06  8:51           ` Tim Farrington
2008-08-07  3:31             ` David
2008-08-07  4:34               ` Tim Farrington
2008-08-07  6:41                 ` David
2008-08-07  7:00                   ` Tim Farrington
2008-08-07  7:10                     ` David
2008-08-07  7:18                       ` SUBHRANIL CHOUDHURY
2008-08-07  7:52                       ` Tim Farrington
2008-08-07  8:47                         ` David
2008-08-10 23:31         ` Luke Yelavich
2008-08-07  1:06     ` jochen s
2008-06-30 23:56 stev391
     [not found] ` <20080731042433.GA21788@kryten>
2008-07-31 15:08   ` Steven Toth
2008-08-01  1:21     ` Anton Blanchard
2008-08-01  1:43       ` Steven Toth
2008-08-01  2:04       ` Steven Toth
2008-08-01  2:13         ` Anton Blanchard
2008-08-01  2:52           ` Steven Toth
2008-08-01  2:55             ` Anton Blanchard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox