From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.gmx.net ([213.165.64.20]) by www.linuxtv.org with smtp (Exim 4.63) (envelope-from ) id 1KWxfQ-0001hj-Ik for linux-dvb@linuxtv.org; Sat, 23 Aug 2008 20:16:53 +0200 Message-ID: <48B05420.5010807@gmx.de> Date: Sat, 23 Aug 2008 20:17:04 +0200 From: Eberhard Kaltenhaeuser MIME-Version: 1.0 To: Patrick Boettcher References: <48B00D6C.8080302@gmx.de> <48B01765.8020104@gmail.com> In-Reply-To: Cc: linux-dvb@linuxtv.org Subject: Re: [linux-dvb] Support of Nova S SE DVB card missing List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0727566892==" Mime-version: 1.0 Sender: linux-dvb-bounces@linuxtv.org Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org List-ID: This is a multi-part message in MIME format. --===============0727566892== Content-Type: multipart/alternative; boundary="------------010301010207010902070201" This is a multi-part message in MIME format. --------------010301010207010902070201 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi Patrick, sorry, actually, i have no environment to compile drivers or kernels. Eberhard Patrick Boettcher schrieb: > Hi Hartmut and Eberhard, > > thanks for pointing that out, I almost overlooked the previous mail from > Eberhard. > > Eberhard, are you able to try patches and to compile your own drivers in > order to help finding the best solution. > > One option is to put back the original code in case the > repeated-start-workaround is not set. But this one looks not very > protected. I mean between the two i2c_transfer-calls something else could > happen. > > Is there no other mean to tell to the i2c-adapter to do a repeated start > within one i2c_transfer-call? > > Another option would be to try to set the "repeated_start_workaround" > option also for the Nova SE card. > > What do you think? > > Patrick. > > -- > Mail: patrick.boettcher@desy.de > WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/ > > > On Sat, 23 Aug 2008, e9hack wrote: > > >> Eberhard Kaltenhaeuser schrieb: >> >>> Actual kernel does not support the Hauppauge WinTV Nova S SE PCI card >>> anymore: >>> >>> >> I think it is a problem of this changeset http://linuxtv.org/hg/v4l-dvb/rev/358d281e6a3d >> from Patrick Boettcher. The S5H1420 isn't able to understand repeated start conditions. >> The i2c-read code was changed from: >> >> if ((ret = i2c_transfer (state->i2c, &msg1, 1)) != 1) >> return ret; >> >> if ((ret = i2c_transfer (state->i2c, &msg2, 1)) != 1) >> return ret; >> >> to: >> if (state->config->repeated_start_workaround) { >> ret = i2c_transfer(state->i2c, msg, 3); >> if (ret != 3) >> return ret; >> } else { >> ret = i2c_transfer(state->i2c, &msg[1], 2); >> if (ret != 2) >> return ret; >> } >> >> -Hartmut >> >> > > _______________________________________________ > linux-dvb mailing list > linux-dvb@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb > > -- ___________________________________ | | | Eberhard Kaltenhaeuser | _ | (+49/0)9135 Tel:799955 Fax:725517 | _ / )| |( \ / / | mailto:ke2705@gmx.de | \ \ _( (_ | _ _ | _) )_ (((\ \>|_/ )___________________________( \_| Hi Patrick,

sorry, actually, i have no environment to compile drivers or kernels.

Eberhard


Patrick Boettcher schrieb: 
Hi Hartmut and Eberhard,

thanks for pointing that out, I almost overlooked the previous mail from 
Eberhard.

Eberhard, are you able to try patches and to compile your own drivers in 
order to help finding the best solution.

One option is to put back the original code in case the 
repeated-start-workaround is not set. But this one looks not very 
protected. I mean between the two i2c_transfer-calls something else could 
happen.

Is there no other mean to tell to the i2c-adapter to do a repeated start 
within one i2c_transfer-call?

Another option would be to try to set the "repeated_start_workaround" 
option also for the Nova SE card.

What do you think?

Patrick.

--
   Mail: patrick.boettcher@desy.de
   WWW:  http://www.wi-bw.tfh-wildau.de/~pboettch/


On Sat, 23 Aug 2008, e9hack wrote:

  
Eberhard Kaltenhaeuser schrieb:
    
Actual kernel does not support the Hauppauge WinTV Nova S SE PCI card
anymore:

      
I think it is a problem of this changeset http://linuxtv.org/hg/v4l-dvb/rev/358d281e6a3d
from Patrick Boettcher. The S5H1420 isn't able to understand repeated start conditions.
The i2c-read code was changed from:

	if ((ret = i2c_transfer (state->i2c, &msg1, 1)) != 1)
		return ret;

	if ((ret = i2c_transfer (state->i2c, &msg2, 1)) != 1)
		return ret;

to:
	if (state->config->repeated_start_workaround) {
		ret = i2c_transfer(state->i2c, msg, 3);
		if (ret != 3)
			return ret;
	} else {
		ret = i2c_transfer(state->i2c, &msg[1], 2);
		if (ret != 2)
			return ret;
	}

-Hartmut

    

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

--
Signatur_2          ___________________________________
        |                                   |
        |      Eberhard Kaltenhaeuser       |
      _ | (+49/0)9135 Tel:799955 Fax:725517 | _
     / )|                                   |( \
    / / |       mailto:ke2705@gmx.de        | \ \
  _( (_ |  _                             _  | _) )_
 (((\ \>|_/ )___________________________( \_|</ /)))
 (\ \  \_/ /                             \ \_/  / /)
  \       /                               \       /
   \    _/                                 \_    /
   /   /                                     \   \
--------------010301010207010902070201-- --===============0727566892== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb --===============0727566892==--