PATCH: Priority=high: luca-drivers-parent-fix.patch

[Hans de Goede <j.w.r.degoede@hhs.nl>]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

Hi Mauro,

I didn't know through which tree to send this as Luca's drivers are 
unmaintained so I'm sending this directly to you. I would like to see this make 
2.6.27 as without this any cams using Luca's drivers do not work out of the box 
(they require a manual chmod to allow non root access after plugging them in).

###

While doing some testing using Luca Risolia's sonix driver I noticed that
the video device did not get ACL's set to allow access by locally logged in
users, nor does it show up as a video device in lshal, causing cheese to not
see it.

This turns out to be caused by all of Luca Risolia's drivers not setting
the parent member of the video_device struct. This patch fixes this.

Priority: high

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Regards,

Hans

[-- Attachment #2: luca-drivers-parent-fix.patch --]
[-- Type: text/plain, Size: 1904 bytes --]

While doing some testing using Luca Risolia's sonix driver I noticed that
the video device did not get ACL's set to allow access by locally logged in
users, nor does it show up as a video device in lshal, causing cheese to not
see it.

This turns out to be caused by all of Luca Risolia's drivers not setting
the parent member of the video_device struct. This patch fixes this.

Priority: high

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -r 01f8914508b4 linux/drivers/media/video/et61x251/et61x251_core.c
--- a/linux/drivers/media/video/et61x251/et61x251_core.c	Sun Aug 31 19:25:43 2008 +0200
+++ b/linux/drivers/media/video/et61x251/et61x251_core.c	Mon Sep 01 20:20:14 2008 +0200
@@ -2592,6 +2592,7 @@
 	cam->v4ldev->fops = &et61x251_fops;
 	cam->v4ldev->minor = video_nr[dev_nr];
 	cam->v4ldev->release = video_device_release;
+	cam->v4ldev->parent = &udev->dev;
 	video_set_drvdata(cam->v4ldev, cam);
 
 	init_completion(&cam->probe);
diff -r 01f8914508b4 linux/drivers/media/video/sn9c102/sn9c102_core.c
--- a/linux/drivers/media/video/sn9c102/sn9c102_core.c	Sun Aug 31 19:25:43 2008 +0200
+++ b/linux/drivers/media/video/sn9c102/sn9c102_core.c	Mon Sep 01 20:20:14 2008 +0200
@@ -3316,6 +3316,7 @@
 	cam->v4ldev->fops = &sn9c102_fops;
 	cam->v4ldev->minor = video_nr[dev_nr];
 	cam->v4ldev->release = video_device_release;
+	cam->v4ldev->parent = &udev->dev;
 
 	init_completion(&cam->probe);
 
diff -r 01f8914508b4 linux/drivers/media/video/zc0301/zc0301_core.c
--- a/linux/drivers/media/video/zc0301/zc0301_core.c	Sun Aug 31 19:25:43 2008 +0200
+++ b/linux/drivers/media/video/zc0301/zc0301_core.c	Mon Sep 01 20:20:14 2008 +0200
@@ -1992,6 +1992,7 @@
 	cam->v4ldev->fops = &zc0301_fops;
 	cam->v4ldev->minor = video_nr[dev_nr];
 	cam->v4ldev->release = video_device_release;
+	cam->v4ldev->parent = &udev->dev;
 	video_set_drvdata(cam->v4ldev, cam);
 
 	init_completion(&cam->probe);

[-- Attachment #3: Type: text/plain, Size: 164 bytes --]

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list