From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <48CAB3EA.5050600@magma.ca> Date: Fri, 12 Sep 2008 14:24:42 -0400 From: Patrick Boisvenue MIME-Version: 1.0 To: Andy Walls References: <48C659C5.8000902@magma.ca> <48C68DC5.1050400@linuxtv.org> <48C73161.7090405@magma.ca> <48C732DE.2030902@linuxtv.org> <1221087304.2648.7.camel@morgan.walls.org> <48C86857.70603@magma.ca> <1221095447.2648.69.camel@morgan.walls.org> In-Reply-To: <1221095447.2648.69.camel@morgan.walls.org> Cc: linux-dvb@linuxtv.org Subject: Re: [linux-dvb] HVR-1500Q eeprom not being parsed correctly List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-dvb-bounces@linuxtv.org Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org List-ID: Andy Walls wrote: > On Wed, 2008-09-10 at 20:37 -0400, Patrick Boisvenue wrote: >> Andy Walls wrote: >>> On Tue, 2008-09-09 at 22:37 -0400, Steven Toth wrote: >>>> Patrick Boisvenue wrote: >>>>> Steven Toth wrote: >>>>>> Patrick Boisvenue wrote: >>>>> When launching dvbscan I get the following in dmesg: >>>>> >>>>> xc5000: waiting for firmware upload (dvb-fe-xc5000-1.1.fw)... >>>>> firmware: requesting dvb-fe-xc5000-1.1.fw >>>>> kobject_add_internal failed for i2c-2 with -EEXIST, don't try to >>>>> register things with the same name in the same directory. >>>>> Pid: 8059, comm: kdvb-fe-0 Tainted: P 2.6.26-gentoo #11 >>>>> >>>>> Call Trace: >>>>> [] kobject_add_internal+0x13f/0x17e >>>>> [] kobject_add+0x74/0x7c >>>>> [] printk+0x4e/0x56 >>>>> [] device_add+0x9b/0x483 >>>>> [] kobject_init+0x41/0x69 >>>>> [] _request_firmware+0x169/0x324 >>>>> [] :xc5000:xc_load_fw_and_init_tuner+0x64/0x293 >>>>> [] i2c_transfer+0x75/0x7f >>>>> [] :s5h1409:s5h1409_writereg+0x51/0x83 >>>>> [] :xc5000:xc5000_init+0x3d/0x6f >>>>> [] :dvb_core:dvb_frontend_init+0x49/0x63 >>>>> [] :dvb_core:dvb_frontend_thread+0x78/0x2f0 >>>>> [] :dvb_core:dvb_frontend_thread+0x0/0x2f0 >>>>> [] kthread+0x47/0x74 >>>>> [] schedule_tail+0x27/0x5b >>>>> [] child_rip+0xa/0x12 >>>>> [] kthread+0x0/0x74 >>>>> [] child_rip+0x0/0x12 >>>>> >>>>> fw_register_device: device_register failed >>>>> xc5000: Upload failed. (file not found?) >>>>> xc5000: Unable to initialise tuner >>>>> >>>>> >>>>> I have the firmware file located here: >>>>> >>>>> # ls -l /lib/firmware/dvb-fe-xc5000-1.1.fw >>>>> -rw-r--r-- 1 root root 12332 Aug 31 12:56 >>>>> /lib/firmware/dvb-fe-xc5000-1.1.fw >>>>> >>>>> If there is anything else I can provide (or try) to help debug, let me >>>>> know, >>>>> ...Patrick >>>> > kobject_add_internal failed for i2c-2 with -EEXIST, don't try to >>>> > register things with the same name in the same directory. >>>> >>>> Ooh, that's nasty problem, this is new - and looks like it's i2c related. >>>> >>>> Why does this sound familiar? Anyone? >>> A cx18 user had a similar problem on one distro. I remeber running it >>> down to a race condition in creating device nodes in one of the >>> "virtual" filesystems (/proc or /sys) the device was looking for a >>> paretn PCI device entry to hook onto, but it wasn't created at the time >>> so it tries to create it itself. In the meantime some other part of the >>> kernel subsystem did actually finish creating the entry - so it exists >>> by the time the firmware load tries to make it. >>> >>> As far as I could tell, it should be non-fatal (not an Oops or panic), >>> but if the driver gives up on -EEXIST then things won't work obviously. >>> >>> I never resolved the problem for the user. I think some kernel change >>> outside of cx18 resolved it. That's all the details I have. >>> >>> Regards, >>> Andy >>> >> So what are my options? > > Good question. I don't know. Working with kobjects is way out of my > knowledge base. > > I looked at the kernel code long enough to decide that without being > able to reproduce the problem myself, I won't be able to spot the root > cause. Part of the reason is that this problem is about looking for and > creating sysfs objects as it relates to driver probing and firmware > loading. I couldn't quite sort out what had to happen in series and > what the kernel could be executing in parallel. > > I think your best option would be to post to the LKML or wherever else > the sysfs and kobject experts hang out. > > Another option could be to modify the driver code that gives up when the > firmware operation returns an error code because a sysfs device node > already exists (-EEXIST). That's no big deal, and a driver should be > able to merrily go forward, if it can easily detect the condition. > > More observations before I go bother people LKML. This is the error with an older 2.6.25 kernel. The dmesg output is more interesting. xc5000: waiting for firmware upload (dvb-fe-xc5000-1.1.fw)... sysfs: duplicate filename 'i2c-1' can not be created ------------[ cut here ]------------ WARNING: at fs/sysfs/dir.c:424 sysfs_add_one+0x3f/0x93() Modules linked in: wlan_wep xc5000 s5h1409 cx23885 compat_ioctl32 videodev v4l1_compat cx2341x wlan_scan_sta videobuf_dma_sg ath_rate_sample v4l2_common btcx_risc tveeprom ath_pci videobuf_dvb dvb_core wlan ath_hal(P) videobuf_core Pid: 7730, comm: kdvb-fe-0 Tainted: P 2.6.25-gentoo-r6 #2 Call Trace: [] warn_on_slowpath+0x51/0x63 [] printk+0x4e/0x56 [] find_inode+0x28/0x6d [] sysfs_ilookup_test+0x0/0xf [] ifind+0x44/0x8d [] sysfs_find_dirent+0x1b/0x2f [] sysfs_add_one+0x3f/0x93 [] create_dir+0x4f/0x87 [] sysfs_create_dir+0x35/0x4a [] kobject_get+0x12/0x17 [] kobject_add_internal+0xc3/0x17e [] kobject_add_varg+0x54/0x61 [] __wake_up+0x38/0x4f [] kobject_add+0x74/0x7c [] :cx23885:i2c_readbytes+0x1ae/0x25d [] printk+0x4e/0x56 [] device_add+0x85/0x4a4 [] kobject_init+0x41/0x69 [] _request_firmware+0x154/0x30f [] :xc5000:xc_load_fw_and_init_tuner+0x64/0x293 [] i2c_transfer+0x75/0x7f [] :s5h1409:s5h1409_writereg+0x51/0x83 [] :xc5000:xc5000_init+0x3d/0x6f [] :dvb_core:dvb_frontend_init+0x49/0x63 [] :dvb_core:dvb_frontend_thread+0x78/0x307 [] :dvb_core:dvb_frontend_thread+0x0/0x307 [] kthread+0x47/0x75 [] schedule_tail+0x27/0x5c [] child_rip+0xa/0x12 [] kthread+0x0/0x75 [] child_rip+0x0/0x12 ---[ end trace 01bdacc4ebef05bf ]--- kobject_add_internal failed for i2c-1 with -EEXIST, don't try to register things with the same name in the same directory. Pid: 7730, comm: kdvb-fe-0 Tainted: P 2.6.25-gentoo-r6 #2 Call Trace: [] kobject_add_internal+0x13f/0x17e [] kobject_add_varg+0x54/0x61 [] __wake_up+0x38/0x4f [] kobject_add+0x74/0x7c [] :cx23885:i2c_readbytes+0x1ae/0x25d [] printk+0x4e/0x56 [] device_add+0x85/0x4a4 [] kobject_init+0x41/0x69 [] _request_firmware+0x154/0x30f [] :xc5000:xc_load_fw_and_init_tuner+0x64/0x293 [] i2c_transfer+0x75/0x7f [] :s5h1409:s5h1409_writereg+0x51/0x83 [] :xc5000:xc5000_init+0x3d/0x6f [] :dvb_core:dvb_frontend_init+0x49/0x63 [] :dvb_core:dvb_frontend_thread+0x78/0x307 [] :dvb_core:dvb_frontend_thread+0x0/0x307 [] kthread+0x47/0x75 [] schedule_tail+0x27/0x5c [] child_rip+0xa/0x12 [] kthread+0x0/0x75 [] child_rip+0x0/0x12 fw_register_device: device_register failed xc5000: Upload failed. (file not found?) xc5000: Unable to initialise tuner ...Patrick _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb