[linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Devin Heitmueller]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Attached is a patch to use the proper firmware for the ATI TV Wonder
600.  It was previously configured to use the XC3028 firmware, as I
did not realize the device had an XC3028L until I got one myself for
testing purposes.

This should get pushed in ASAP since the wrong firmware causes the
device to overheat and could cause permanent damage.

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ati_600_xc3028l_tuner.patch --]
[-- Type: text/x-diff; name=ati_600_xc3028l_tuner.patch, Size: 1565 bytes --]

Use correct XC3028L firmware for AMD ATI TV Wonder 600

From: Devin Heitmueller <devin.heitmueller@gmail.com>

The AMD ATI TV Wonder 600 has an XC3028L and *not* an XC3028, so we need to 
load the proper firmware to prevent the device from overheating.

Priority: high

Signed-off-by: Devin Heitmueller <devin.heitmueller@gmail.com>

diff -r e5ca4534b543 linux/drivers/media/common/tuners/tuner-xc2028.h
--- a/linux/drivers/media/common/tuners/tuner-xc2028.h	Tue Sep 09 08:29:56 2008 -0700
+++ b/linux/drivers/media/common/tuners/tuner-xc2028.h	Mon Sep 15 23:51:20 2008 -0400
@@ -10,6 +10,7 @@
 #include "dvb_frontend.h"
 
 #define XC2028_DEFAULT_FIRMWARE "xc3028-v27.fw"
+#define XC3028L_DEFAULT_FIRMWARE "xc3028L-v36.fw"
 
 /*      Dmoduler		IF (kHz) */
 #define	XC3028_FE_DEFAULT	0		/* Don't load SCODE */
diff -r e5ca4534b543 linux/drivers/media/video/em28xx/em28xx-cards.c
--- a/linux/drivers/media/video/em28xx/em28xx-cards.c	Tue Sep 09 08:29:56 2008 -0700
+++ b/linux/drivers/media/video/em28xx/em28xx-cards.c	Mon Sep 15 23:51:20 2008 -0400
@@ -1534,9 +1534,12 @@ static void em28xx_setup_xc3028(struct e
 		/* djh - Not sure which demod we need here */
 		ctl->demod = XC3028_FE_DEFAULT;
 		break;
+	case EM2880_BOARD_AMD_ATI_TV_WONDER_HD_600:
+		ctl->demod = XC3028_FE_DEFAULT;
+		ctl->fname = XC3028L_DEFAULT_FIRMWARE;
+		break;
 	case EM2883_BOARD_HAUPPAUGE_WINTV_HVR_950:
 	case EM2880_BOARD_PINNACLE_PCTV_HD_PRO:
-	case EM2880_BOARD_AMD_ATI_TV_WONDER_HD_600:
 		/* FIXME: Better to specify the needed IF */
 		ctl->demod = XC3028_FE_DEFAULT;
 		break;

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Michael Krufky]

Devin Heitmueller wrote:
> Attached is a patch to use the proper firmware for the ATI TV Wonder
> 600.  It was previously configured to use the XC3028 firmware, as I
> did not realize the device had an XC3028L until I got one myself for
> testing purposes.
> 
> This should get pushed in ASAP since the wrong firmware causes the
> device to overheat and could cause permanent damage.

I'll push this in... I like the fact that you defined the xc3028L firmware in the header -- I will also push up a patch to change the HVR1400 (cx23885 ExpressCard) to use XC3028L_DEFAULT_FIRMWARE instead of specifying the filename explicitly.

Thanks,

Mike

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Devin Heitmueller]

On Tue, Sep 16, 2008 at 1:01 AM, Michael Krufky <mkrufky@linuxtv.org> wrote:
> I'll push this in... I like the fact that you defined the xc3028L firmware in the header -- I will also push up a patch to change the HVR1400 (cx23885 ExpressCard) to use XC3028L_DEFAULT_FIRMWARE instead of specifying the filename explicitly.

Michael,

Thanks for your help in getting this pulled in.  The moral of this
story seems to have been that it's *way* easier to just buy the damn
thing than to add support for someone's device remotely.  92 emails
over three weeks to get support added versus 1 evening to get support
working right.  :-)

Cheers,

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Steven Toth]

Devin Heitmueller wrote:
> On Tue, Sep 16, 2008 at 1:01 AM, Michael Krufky <mkrufky@linuxtv.org> wrote:
>> I'll push this in... I like the fact that you defined the xc3028L firmware in the header -- I will also push up a patch to change the HVR1400 (cx23885 ExpressCard) to use XC3028L_DEFAULT_FIRMWARE instead of specifying the filename explicitly.
> 
> Michael,
> 
> Thanks for your help in getting this pulled in.  The moral of this
> story seems to have been that it's *way* easier to just buy the damn
> thing than to add support for someone's device remotely.  92 emails
> over three weeks to get support added versus 1 evening to get support
> working right.  :-)

/me nods

Better still, have someone give you a device for free in return for help.

- Steve

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Devin Heitmueller]

On Tue, Sep 16, 2008 at 12:36 PM, Steven Toth <stoth@linuxtv.org> wrote:
> Devin Heitmueller wrote:
>> Thanks for your help in getting this pulled in.  The moral of this
>> story seems to have been that it's *way* easier to just buy the damn
>> thing than to add support for someone's device remotely.  92 emails
>> over three weeks to get support added versus 1 evening to get support
>> working right.  :-)
>
> /me nods
>
> Better still, have someone give you a device for free in return for help.

Better still, have a vendor give you a device for free and make the
datasheets available in return for having their device supported.  :-)

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Steven Toth]

Devin Heitmueller wrote:
> On Tue, Sep 16, 2008 at 12:36 PM, Steven Toth <stoth@linuxtv.org> wrote:
>> Devin Heitmueller wrote:
>>> Thanks for your help in getting this pulled in.  The moral of this
>>> story seems to have been that it's *way* easier to just buy the damn
>>> thing than to add support for someone's device remotely.  92 emails
>>> over three weeks to get support added versus 1 evening to get support
>>> working right.  :-)
>> /me nods
>>
>> Better still, have someone give you a device for free in return for help.
> 
> Better still, have a vendor give you a device for free and make the
> datasheets available in return for having their device supported.  :-)

Believe it or not but I'm starting to see that happen, although with 
some restrictions.

- Steve


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Devin Heitmueller]

On Tue, Sep 16, 2008 at 2:37 PM, Steven Toth <stoth@linuxtv.org> wrote:
> Devin Heitmueller wrote:
>>
>> On Tue, Sep 16, 2008 at 12:36 PM, Steven Toth <stoth@linuxtv.org> wrote:
>>>
>>> Devin Heitmueller wrote:
>>>>
>>>> Thanks for your help in getting this pulled in.  The moral of this
>>>> story seems to have been that it's *way* easier to just buy the damn
>>>> thing than to add support for someone's device remotely.  92 emails
>>>> over three weeks to get support added versus 1 evening to get support
>>>> working right.  :-)
>>>
>>> /me nods
>>>
>>> Better still, have someone give you a device for free in return for help.
>>
>> Better still, have a vendor give you a device for free and make the
>> datasheets available in return for having their device supported.  :-)
>
> Believe it or not but I'm starting to see that happen, although with some
> restrictions.

Well, sign me up!  I would love to help the efforts to expand device
support, but at this point I'm personally blocked by the fact that I
have already bought four tuners in the last year, combined with the
lack of actual documentation which results in it taking *way* longer
than it has to.

Sure, I got all four of them to work which is progress, but it would
have gone much faster if the docs were available to me and I wasn't
laying out my own cash to buy tuners I have no personal use for.

I've spent all this time to learn the codebase and I'd like to
leverage that knowledge more, but now I have to ask myself, "What am I
going to do with four tuners?"

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [FIX] Use correct firmware for the ATI TV Wonder 600

[Steven Toth]

Devin Heitmueller wrote:
> On Tue, Sep 16, 2008 at 2:37 PM, Steven Toth <stoth@linuxtv.org> wrote:
>> Devin Heitmueller wrote:
>>> On Tue, Sep 16, 2008 at 12:36 PM, Steven Toth <stoth@linuxtv.org> wrote:
>>>> Devin Heitmueller wrote:
>>>>> Thanks for your help in getting this pulled in.  The moral of this
>>>>> story seems to have been that it's *way* easier to just buy the damn
>>>>> thing than to add support for someone's device remotely.  92 emails
>>>>> over three weeks to get support added versus 1 evening to get support
>>>>> working right.  :-)
>>>> /me nods
>>>>
>>>> Better still, have someone give you a device for free in return for help.
>>> Better still, have a vendor give you a device for free and make the
>>> datasheets available in return for having their device supported.  :-)
>> Believe it or not but I'm starting to see that happen, although with some
>> restrictions.
> 
> Well, sign me up!  I would love to help the efforts to expand device
> support, but at this point I'm personally blocked by the fact that I
> have already bought four tuners in the last year, combined with the
> lack of actual documentation which results in it taking *way* longer
> than it has to.
> 
> Sure, I got all four of them to work which is progress, but it would
> have gone much faster if the docs were available to me and I wasn't
> laying out my own cash to buy tuners I have no personal use for.
> 
> I've spent all this time to learn the codebase and I'd like to
> leverage that knowledge more, but now I have to ask myself, "What am I
> going to do with four tuners?"

Hauppauge always have opensource projects that need help.

If you're interested we can discuss off-line, email my Hauppauge address 
and we'll pick up on the discussion privately.

Regards,

- Steve



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb