Re: [PATCH][RFC] Add support for the ALi m5602 usb bridge webcam

[Hans de Goede <j.w.r.degoede@hhs.nl>]

Erik Andrén wrote:
> Hi,
> I'm proud to announce the following patch adding support for the ALi m5602
> usb bridge connected to several different sensors.
> This driver has been brewing for a long time in the m560x.sf.net project and
> exists due to the hard work of many persons.
> 
> libv4l is needed in order to gain support for multiple pixelformats.
> 
> The patch should apply against the latest v4l-dvb hg tree.
> 
> Thanks for any feedback,
> Erik
>

Hi Erik,

Thanks for doing this, unfortunately the driver which you used as a 
template to start from has various issues (not allowing multiple opens 
for one, interpreting the v4l2 API in interesting ways in other places).

Besides that there is lot of code duplication between isoc mode usb webcams.

I would kindly like to ask you to consider porting the m5602 driver to 
the gspca framework, which provides a generic framework for isoc webcams 
and takes a lot of stuff out of the driver and into a more generic 
framework (like try_fmt mode negatiation, isoc mode setup and handling, 
frame buffer management, etc.).

gspca is in the current 2.6.27 kernels, if you look under
drivers/media/video/gspca you will see drivers for a lot of different 
webcams there, you could for example take the pac207 driver as an 
example, strip it empty and then copy and paste the relevant part of 
your driver to there.

I will help you in anyway I can.

Does this sound like a plan?

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list