public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [linux-dvb] [RFC] cinergyT2 rework final review
@ 2008-09-22  7:20 Tomi Orava
  2008-09-22 20:16 ` Tino Keitel
  0 siblings, 1 reply; 12+ messages in thread
From: Tomi Orava @ 2008-09-22  7:20 UTC (permalink / raw)
  To: linux-dvb



Hi,

> On Fri, Sep 19, 2008 at 14:34:50 +0200, Thierry Merle wrote:
>
> [...]
>
>> OK. In my mind this patch was not a priority and some users reported bugs
>> but we don't have any news from their part. Maybe buggy users :) I will
wait just a little at least from Tomi and send a pull request to Mauro
within the middle of the next week.
>
> I had 2 issues:
>
> - irrecord didn't work
>
> - a failure after resume after suspend with the driver loaded, the
>   keyboard went crazy. Unloading the driver and unplugging the
>   CinergyT2 helped in this case
>
> I don't know if theses issues are still present, though. I don't use the
> IR receiver anymore, and always unload the driver before suspend. I'll
> try to update to the current driver and re-test.

I think that the version in Thierry's repository should contain
the missing key repeat functionality that Thierry added in June.
This should help to get the irrecord running again.

Could you check what is the firmware version in your device ?
Check for the "bcdDevice" keyword with lsusb -v -s <busid>:<devnum> I had
way too many problems with 1.06 firmware version, but the
newer 1.08 seems to be a little bit better in stability.
I do think that this device is certainly not the most stable tuner on
earth but if you don't do suspend/resume with it,
it should work quite fine.

Regards,
Tomi Orava

-- 




-- 



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [linux-dvb] [RFC] cinergyT2 rework final review
@ 2008-09-22  7:14 Tomi Orava
  0 siblings, 0 replies; 12+ messages in thread
From: Tomi Orava @ 2008-09-22  7:14 UTC (permalink / raw)
  To: linux-dvb



Hi,

>> Patrick Boettcher wrote:
>>> Hi Thierry,
>>>
>>> On Fri, 19 Sep 2008, Thierry Merle wrote:
>>>
>>>> Hello all,
>>>> About the rework from Tomi Orava I stored here:
>>>> http://linuxtv.org/hg/~tmerle/cinergyT2
>>>>
>>>> since there seems to be no bug declared with this driver by testers
(I tested this driver on AMD/Intel/ARM platforms for months), it is
time for
>>>> action.
>>>> If I receive no problem report before 19th of October (in one month), I
>>>> will push this driver into mainline.
>>>
>>> Are you really sure you want to wait until October 19 with that? You
heard
>>> Jonathan this morning, he is expecting a new release every day now, so
the
>>> merge window will start quite soon. Maybe it would be better to
shorten your deadline in favour of having the driver in-tree for
2.6.28. When it
>>> is inside it is still possible for at least 1.5 months to fix occuring
problems.
>>
>> Agreed, shorten and aim for 2.6.28 - especially if you've already done
a significant amount of personal testing.
>>
>> - Steve
>>
>>
> OK. In my mind this patch was not a priority and some users reported
bugs but we don't have any news from their part. Maybe buggy users :) I
will wait just a little at least from Tomi and send a pull request to
Mauro within the middle of the next week.

Not much has been happening during the summertime. No new bug reports have
been reported and I never heard again from the person who claimed to have
had problems with this driver in May(?). This driver has been working in
my own use quite well, especially after upgrading the bios to the latest
available version from TerraTec.

Regards,
Tomi Orava


-- 



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [linux-dvb] [RFC] cinergyT2 rework final review
@ 2008-09-19  4:12 Thierry Merle
  2008-09-19  6:35 ` Patrick Boettcher
  0 siblings, 1 reply; 12+ messages in thread
From: Thierry Merle @ 2008-09-19  4:12 UTC (permalink / raw)
  To: linux-dvb

Hello all,
About the rework from Tomi Orava I stored here:
http://linuxtv.org/hg/~tmerle/cinergyT2

since there seems to be no bug declared with this driver by testers (I
tested this driver on AMD/Intel/ARM platforms for months), it is time for
action.
If I receive no problem report before 19th of October (in one month), I
will push this driver into mainline.
This modification uses the dvb-usb framework, this is

To give you an idea of the code benefit, here is a diffstat of the
cinergyT2 rework patch:
 linux/drivers/media/dvb/cinergyT2/Kconfig        |   85 -
 linux/drivers/media/dvb/cinergyT2/Makefile       |    3
 linux/drivers/media/dvb/cinergyT2/cinergyT2.c    | 1150
---------------------
 linux/drivers/media/dvb/dvb-usb/cinergyT2-core.c |  230 ++++
 linux/drivers/media/dvb/dvb-usb/cinergyT2-fe.c   |  351 ++++++
 linux/drivers/media/dvb/dvb-usb/cinergyT2.h      |   95 +
 linux/drivers/media/dvb/Kconfig                    |    1
 linux/drivers/media/dvb/dvb-usb/Kconfig            |    8
 linux/drivers/media/dvb/dvb-usb/Makefile           |    4
 9 files changed, 688 insertions(+), 1239 deletions(-)

Cheers,
Thierry
-- 
Sent from an ArmedSlack powered NSLU2.


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2008-09-22 20:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <mailman.1.1222077601.9177.linux-dvb@linuxtv.org>
2008-09-22 19:18 ` [linux-dvb] [RFC] cinergyT2 rework final review Martin Dauskardt
2008-09-22 20:20   ` Christophe Thommeret
2008-09-22 20:39   ` Tomi Orava
2008-09-22  7:20 Tomi Orava
2008-09-22 20:16 ` Tino Keitel
  -- strict thread matches above, loose matches on Subject: below --
2008-09-22  7:14 Tomi Orava
2008-09-19  4:12 Thierry Merle
2008-09-19  6:35 ` Patrick Boettcher
2008-09-19  6:45   ` Markus Rechberger
2008-09-19  6:57   ` Steven Toth
2008-09-19 12:34     ` Thierry Merle
2008-09-21 23:03       ` Tino Keitel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox