From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mta5.srv.hcvlny.cv.net ([167.206.4.200]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1Kia3U-0007Lf-0f for linux-dvb@linuxtv.org; Wed, 24 Sep 2008 21:29:44 +0200 Received: from steven-toths-macbook-pro.local (ool-18bfe594.dyn.optonline.net [24.191.229.148]) by mta5.srv.hcvlny.cv.net (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTP id <0K7P00B4YSS7EVD0@mta5.srv.hcvlny.cv.net> for linux-dvb@linuxtv.org; Wed, 24 Sep 2008 15:28:57 -0400 (EDT) Date: Wed, 24 Sep 2008 15:28:55 -0400 From: Steven Toth In-reply-to: <8C08530B-BAD7-4E83-B1CA-6AB66EE9F53F@ginandtonic.no> To: Anders Semb Hermansen Message-id: <48DA94F7.1090005@linuxtv.org> MIME-version: 1.0 References: <953A45C4-975B-4A05-8B41-AE8A486D0CA6@ginandtonic.no> <5584.1222273099@kewl.org> <6380.1222276810@kewl.org> <8C08530B-BAD7-4E83-B1CA-6AB66EE9F53F@ginandtonic.no> Cc: linux-dvb@linuxtv.org Subject: Re: [linux-dvb] HVR-4000 and analogue tv List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-dvb-bounces@linuxtv.org Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org List-ID: Anders Semb Hermansen wrote: > Den 24. sep.. 2008 kl. 19.20 skrev Darron Broad: > > > >> >>> Does this mean that mythtv is doing something weird or maybe just >>> using the v4l api in a different way which the driver cannot handle? >> This is feasable. I will take a look if I get the time but this >> is more than likely to be when I have other reasons to look >> at mythtv so don't expect an immediate response :-) >> > > I did some more investigating. > > I thought maybe this had something to do with the tuner, since I got > snow. So I enabled debugging for the tuner module (debug=1). What I > saw was that when I started watching TV in myth, there was a > TUNER_SET_STANDBY after frequency and other things was set. This > TUNER_SET_STANDBY did not appear when I was just changing channel (and > picture worked). > > So I searched the driver for TUNER_STANDBY and found one which I > tried. Here is what I did: > > diff -r e5ca4534b543 linux/drivers/media/video/cx88/cx88-video.c > --- a/linux/drivers/media/video/cx88/cx88-video.c Tue Sep 09 > 08:29:56 2008 -0700 > +++ b/linux/drivers/media/video/cx88/cx88-video.c Wed Sep 24 > 20:35:46 2008 +0200 > @@ -1152,7 +1152,8 @@ > file->private_data = NULL; > kfree(fh); > > - cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL); > + printk("Don't set standby mode! TUNER_SET_STANDBY NO SIR!"); > + //cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL); > > return 0; > } > > > This fixed it!! > > I don't know what side effects this will have. Or if this is caused by > wrong use of v4l by mythtv, or driver not implementing it correctly. > Those who know the codebase can maybe answer that and come up with a > better permanent solution. Anders, thanks for helping debug this. :) This will have odd side effects for other boards. It's an interesting fix and it points us to the real issue, but we need to find a better way to clean this up, before we submit for merge. The HVR4000 is a very strange board, we need to be careful when adding generic changes into cx88-*.c that are not conditioned based on (board == HVR4000) I welcome your patches, if you find anything else that's odd/strange then let's discuss those also. Your help is very much appreciated. Regards, - Steve _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb