From: Andreas Oberritter <obi@linuxtv.org>
To: Mika Laitio <lamikr@pilppa.org>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] dvb-t fix for hvr-4000 multiproto
Date: Thu, 25 Sep 2008 01:49:17 +0200 [thread overview]
Message-ID: <48DAD1FD.1060801@linuxtv.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0809250125040.11057@shogun.pilppa.org>
Mika Laitio wrote:
> memset and udelay changes from s2-mfe were really not making any visible
> changes for me, but at least the memset call is a good thing to do.
+ memset(&core->board, 0, sizeof(core->board));
memcpy(&core->board, &cx88_boards[core->boardnr], sizeof(core->board));
Contrary to your opinion, this call to memset is superflous, as all the
zeroes get overwritten by the call to memcpy.
Regards,
Andreas
_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
prev parent reply other threads:[~2008-09-24 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 22:37 [linux-dvb] dvb-t fix for hvr-4000 multiproto Mika Laitio
2008-09-24 23:49 ` Andreas Oberritter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DAD1FD.1060801@linuxtv.org \
--to=obi@linuxtv.org \
--cc=lamikr@pilppa.org \
--cc=linux-dvb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox