[linux-dvb] dvb-t fix for hvr-4000 multiproto

[linux-dvb] dvb-t fix for hvr-4000 multiproto

[Mika Laitio]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 453 bytes --]

Even if S2 will be the future, multiproto is still needed at least with 
VDR. So to get dvb-t working with latest multiproto from
http://mercurial.intuxication.org/hg/liplianindvb with HVR-4000 and 2.6.26 
kernel, I needed to add radio definitions for hvr-4000.

memset and udelay changes from s2-mfe were really not making any visible 
changes for me, but at least the memset call is a good thing to 
do.

Signed-off-by: Mika Laitio <lamikr@pilppa.org>

[-- Attachment #2: multiproto fixes for hvr-4000 --]
[-- Type: TEXT/PLAIN, Size: 1012 bytes --]

--- cx88-cards.c_old	2008-09-25 00:51:18.000000000 +0300
+++ cx88-cards.c	2008-09-24 10:44:15.000000000 +0300
@@ -1480,6 +1480,10 @@
 		}},
 		/* fixme: Add radio support */
 		.mpeg           = CX88_MPEG_DVB,
+		.radio = {
+			.type   = CX88_RADIO,
+			.gpio0	= 0xe780,
+		},
 	},
 	[CX88_BOARD_HAUPPAUGE_HVR4000LITE] = {
 		.name           = "Hauppauge WinTV-HVR4000(Lite) DVB-S/S2",
@@ -2594,8 +2598,9 @@
 		break;
 	case CX88_BOARD_HAUPPAUGE_HVR3000: /* ? */
 	case CX88_BOARD_HAUPPAUGE_HVR4000:
-		/* Init GPIO for DVB-S/S2/Analog */
-		cx_write(MO_GP0_IO,core->board.input[0].gpio0);
+		/* Init GPIO */
+		cx_write(MO_GP0_IO, core->board.input[0].gpio0);
+		udelay(1000);
 		break;
 
 	case CX88_BOARD_PROLINK_PV_8000GT:
@@ -2939,6 +2944,7 @@
 		cx88_card_list(core, pci);
 	}
 
+	memset(&core->board, 0, sizeof(core->board));
 	memcpy(&core->board, &cx88_boards[core->boardnr], sizeof(core->board));
 
 	info_printk(core, "subsystem: %04x:%04x, board: %s [card=%d,%s]\n",

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] dvb-t fix for hvr-4000 multiproto

[Andreas Oberritter]

Mika Laitio wrote:
> memset and udelay changes from s2-mfe were really not making any visible
> changes for me, but at least the memset call is a good thing to do.

+	memset(&core->board, 0, sizeof(core->board));
 	memcpy(&core->board, &cx88_boards[core->boardnr], sizeof(core->board));

Contrary to your opinion, this call to memset is superflous, as all the
zeroes get overwritten by the call to memcpy.

Regards,
Andreas


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb