From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mta3.srv.hcvlny.cv.net ([167.206.4.198]) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1Kn12z-0004dw-Fg for linux-dvb@linuxtv.org; Tue, 07 Oct 2008 03:07:34 +0200 Received: from steven-toths-macbook-pro.local (ool-18bfe594.dyn.optonline.net [24.191.229.148]) by mta3.srv.hcvlny.cv.net (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTP id <0K8C00JDWGFH0N41@mta3.srv.hcvlny.cv.net> for linux-dvb@linuxtv.org; Mon, 06 Oct 2008 21:06:53 -0400 (EDT) Date: Mon, 06 Oct 2008 21:06:52 -0400 From: Steven Toth In-reply-to: <200810061422.38176.jareguero@telefonica.net> To: Jose Alberto Reguero Message-id: <48EAB62C.8060208@linuxtv.org> MIME-version: 1.0 References: <200810061422.38176.jareguero@telefonica.net> Cc: linux-dvb@linuxtv.org Subject: Re: [linux-dvb] Problems with new S2API and DVB-T List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-dvb-bounces@linuxtv.org Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org List-ID: Jose Alberto Reguero wrote: > I am trying to use the new API for DVB-T and I have some problems. They are > not way to set code_rate_HP, code_rate_LP, transmission_mode, and > guard_interval , and the default values are 0, that are not the AUTO ones. > Also the bandwidth is not treated well. The attached patch is a workaround > that works for me. Hi Jose, Thanks for your patch. I've taken a different approach and added support for DTV_TRANSMISSION_MODE, DTV_HIERARCHY, DTV_GUARD_INTERVAL, DTV_CODE_RATE_HP and DTV_CODE_RATE_LP, so this will probably help. In terms of the bandwidth changes, you realise that you have to bandwidth in units of HZ via the S2API? If you're doing this then I do not see why the bandwidth code is failing. We have some backward compat code which should be cleanly taking care of this, proving you pass HZ into the S2API. One interest point is that we may want to pick sensible defaults for the cache values during initialisation (which doesn't currently happen). Applications that rely on default behaviour could be failing... although Kaffeine, Myth, VDR and tzap applications are not experiencing this issue. http://linuxtv.org/hg/~stoth/s2 Could you pull this tree and try again? (Remember to change your bandwidth values to HZ, I.e. 8000000. Thanks again, Steve _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb