From: Sakari Ailus <sakari.ailus@nokia.com>
To: ext Hans Verkuil <hverkuil@xs4all.nl>
Cc: vimarsh.zutshi@nokia.com, video4linux-list@redhat.com,
tuukka.o.toivonen@nokia.com, hnagalla@ti.com
Subject: Re: [PATCH] V4L: Int if: Define new power state changes
Date: Tue, 07 Oct 2008 19:17:48 +0300 [thread overview]
Message-ID: <48EB8BAC.90706@nokia.com> (raw)
In-Reply-To: <200810061838.38551.hverkuil@xs4all.nl>
ext Hans Verkuil wrote:
> Hi Sakari,
>
> I'm OK with the other changes, but the V4L2_POWER_RESUME command in this
> patch is still really very ugly. In my opinion you should either let
> the slave store the old powerstate (this seems to be the more logical
> approach), or let s_power pass the old powerstate as an extra argument
> if you think it is really needed. But the RESUME command is just
> unnecessary. Without the RESUME there is no more need to document
> anything, since then it is suddenly self-documenting.
Yeah, I agree. I'll remove that and send a new patchset, this time with
git-format-patch -n. :-)
Ps. Last time the first patch got caught by a spam filter and my hunch
is that it'll happen again.
Regards,
--
Sakari Ailus
sakari.ailus@nokia.com
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-10-07 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 11:07 [PATCH 0/6] V4L changes for OMAP 3 camera, try 2 Sakari Ailus
[not found] ` <12232912722008-git-send-email-sakari.ailus@nokia.com>
2008-10-06 11:07 ` [PATCH] V4L: Int if: Add cropcap, g_crop and s_crop commands Sakari Ailus
2008-10-06 11:07 ` [PATCH] V4L: Add 10-bit RAW Bayer formats Sakari Ailus
2008-10-06 11:07 ` [PATCH] V4L: Int if: Define new power state changes Sakari Ailus
2008-10-06 11:07 ` [PATCH] V4L: Int if: Export more interfaces to modules Sakari Ailus
2008-10-06 11:07 ` [PATCH] V4L: Int if: Add enum_framesizes and enum_frameintervals ioctls Sakari Ailus
2008-10-06 16:38 ` [PATCH] V4L: Int if: Define new power state changes Hans Verkuil
2008-10-07 16:17 ` Sakari Ailus [this message]
[not found] ` <12233962961256-git-send-email-sakari.ailus@nokia.com>
2008-10-07 16:18 ` [PATCH 2/6] V4L: Int if: Add cropcap, g_crop and s_crop commands Sakari Ailus
2008-10-07 16:18 ` [PATCH 3/6] V4L: Add 10-bit RAW Bayer formats Sakari Ailus
2008-10-07 16:18 ` [PATCH 4/6] V4L: Int if: Define new power state changes Sakari Ailus
2008-10-07 16:18 ` [PATCH 5/6] V4L: Int if: Export more interfaces to modules Sakari Ailus
2008-10-07 16:18 ` [PATCH 6/6] V4L: Int if: Add enum_framesizes and enum_frameintervals ioctls Sakari Ailus
2008-10-08 6:09 ` [PATCH] V4L: Int if: Define new power state changes Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB8BAC.90706@nokia.com \
--to=sakari.ailus@nokia.com \
--cc=hnagalla@ti.com \
--cc=hverkuil@xs4all.nl \
--cc=tuukka.o.toivonen@nokia.com \
--cc=video4linux-list@redhat.com \
--cc=vimarsh.zutshi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox