[linux-dvb] [PATCH] Fix initialization in mxl5005s

[linux-dvb] [PATCH] Fix initialization in mxl5005s

[Jose Alberto Reguero]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

I think that the initialization in the mxl5005s driver is wrong.

Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net>

Jose Alberto



[-- Attachment #2: mxl5005s.diff --]
[-- Type: text/x-patch, Size: 748 bytes --]

diff -r 4abf15af7eae linux/drivers/media/common/tuners/mxl5005s.c
--- a/linux/drivers/media/common/tuners/mxl5005s.c	Mon Oct 06 21:46:08 2008 -0400
+++ b/linux/drivers/media/common/tuners/mxl5005s.c	Mon Oct 13 00:55:03 2008 +0200
@@ -3912,7 +3912,10 @@
 
 static int mxl5005s_init(struct dvb_frontend *fe)
 {
-	dprintk(1, "%s()\n", __func__);
+	struct mxl5005s_state *state = fe->tuner_priv;
+
+	dprintk(1, "%s()\n", __func__);
+	state->current_mode = MXL_QAM;
 	return mxl5005s_reconfigure(fe, MXL_QAM, MXL5005S_BANDWIDTH_6MHZ);
 }
 
@@ -4094,7 +4097,6 @@
 	state->frontend = fe;
 	state->config = config;
 	state->i2c = i2c;
-	state->current_mode = MXL_QAM;
 
 	printk(KERN_INFO "MXL5005S: Attached at address 0x%02x\n",
 		config->i2c_address);

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH] Fix initialization in mxl5005s

[Steven Toth]

Jose Alberto Reguero wrote:
> I think that the initialization in the mxl5005s driver is wrong.

Great, thanks. :)

I'm curious, why do you think it's wrong? It _could_ actually be wrong, 
but I'd like to understand your rationale and testing. In principle this 
patch shouldn't matter, the tuner should get reconfigured if the caller 
requests anything other than QAM.

Which board are you testing, and what configuration is the tuner 
expected to be running in?

Regards,

Steve



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb