From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781A7C4CEC5 for ; Thu, 12 Sep 2019 17:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5393620644 for ; Thu, 12 Sep 2019 17:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730597AbfILRGN (ORCPT ); Thu, 12 Sep 2019 13:06:13 -0400 Received: from mga05.intel.com ([192.55.52.43]:16008 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727464AbfILRGN (ORCPT ); Thu, 12 Sep 2019 13:06:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 10:06:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="190049683" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.148]) ([10.7.153.148]) by orsmga006.jf.intel.com with ESMTP; 12 Sep 2019 10:06:12 -0700 Subject: Re: [PATCH -next 2/2] media: aspeed: set hsync and vsync polarities to normal before starting mode detection To: Andrew Jeffery , Eddie James , Mauro Carvalho Chehab , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org References: <20190910190756.31432-1-jae.hyun.yoo@linux.intel.com> <20190910190756.31432-3-jae.hyun.yoo@linux.intel.com> <5c5538e7-4b7a-4d13-b4ac-584be4090d48@www.fastmail.com> From: Jae Hyun Yoo Message-ID: <490bc4d9-e471-3b0f-49c9-39e99af95d62@linux.intel.com> Date: Thu, 12 Sep 2019 10:06:12 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <5c5538e7-4b7a-4d13-b4ac-584be4090d48@www.fastmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 9/11/2019 10:39 PM, Andrew Jeffery wrote: > > > On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote: >> Sometimes it detects a weird resolution such as 1024x287 when the >> actual resolution is 1024x768. To resolve such an issue, this >> commit adds clearing for hsync and vsync polarity register bits >> at the beginning of the first mode detection. This is recommended >> in the datasheet. > > I guess this answers my question on the previous patch's commit > message. Maybe it should be in both? I think the previous patch is a bug fix and this one is an enhancement patch. Better splitting them. Thanks, Jae