Re: [linux-dvb] [PATCH] Add missing S2 caps flag to S2API

From: Artem Makhutov <artem@makhutov.org>
To: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] [PATCH] Add missing S2 caps flag to S2API
Date: Mon, 24 Nov 2008 08:12:04 +0100	[thread overview]
Message-ID: <492A53C4.5030509@makhutov.org> (raw)
In-Reply-To: <49293640.10808@cadsoft.de>

Hello,

Klaus Schmidinger schrieb:
> The attached patch adds a capability flag that allows an application
> to determine whether a particular device can handle "second generation
> modulation" transponders. This is necessary in order for applications
> to be able to decide which device to use for a given channel in
> a multi device environment, where DVB-S and DVB-S2 devices are mixed.
> 
> It is assumed that a device capable of handling "second generation
> modulation" can implicitly handle "first generation modulation".
> The flag is not named anything with DVBS2 in order to allow its
> use with future DVBT2 devices as well (should they ever come).
> 
> Signed-off by: Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>

Wouldn't it be better to add something like this:

FE_CAN_8PSK
FE_CAN_16APSK
FE_CAN_32APSK

or

FE_CAN_DVBS2

Instead of FE_CAN_2ND_GEN_MODULATION ? It is too generic for me.

Regards, Artem

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb