From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from crow.cadsoft.de ([217.86.189.86] helo=raven.cadsoft.de) by www.linuxtv.org with esmtp (Exim 4.63) (envelope-from ) id 1L4tOM-0005r8-2E for linux-dvb@linuxtv.org; Tue, 25 Nov 2008 09:35:31 +0100 Received: from [192.168.1.71] (falcon.cadsoft.de [192.168.1.71]) by raven.cadsoft.de (8.14.3/8.14.3) with ESMTP id mAP8ZQdT017515 for ; Tue, 25 Nov 2008 09:35:26 +0100 Message-ID: <492BB8CE.4010008@cadsoft.de> Date: Tue, 25 Nov 2008 09:35:26 +0100 From: Klaus Schmidinger MIME-Version: 1.0 To: linux-dvb@linuxtv.org References: <13077.130.36.62.140.1227542142.squirrel@webmail.xs4all.nl> <492AD583.4040809@cadsoft.de> <492B0182.2030602@gmail.com> In-Reply-To: <492B0182.2030602@gmail.com> Subject: Re: [linux-dvb] [PATCH] Add missing S2 caps flag to S2API List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-dvb-bounces@linuxtv.org Errors-To: linux-dvb-bounces+mchehab=infradead.org@linuxtv.org List-ID: On 24.11.2008 20:33, Manu Abraham wrote: > Klaus Schmidinger wrote: >> On 24.11.2008 16:55, Niels Wagenaar wrote: >>> ... >>> For the time being I have only two options which will work without any >>> additional patching in S2API: >>> >>> - Let the user set this as an option >>> - Use my VUP (very ugly patch) by checking the deliverystem for the string >>> "DVBS2". >> Both are ugly workarounds and any reasonable API requiring them instead >> of simply reporting the -S2 capability of a device should >> be ashamed, go home and do its homework. > > ACK > >> For the time being I'll work with my suggested FE_CAN_2ND_GEN_MODULATION >> patch - until somebody can suggest a different way of doing this (without >> parsing strings or requiring the user to do it). > > ACK. > > That is a saner way of doing it rather than anything else, as it stands. > > Anyway, we won't be seeing professional device support as it stands with > the current API anytime soon, so as it stands the better alternative is > thus. > > But it would be nice to have something shorter: say FE_IS_2G or > something that way, for the minimal typing. Well, I don't really care about the actual name - as long as I can get the information... ;-) Klaus _______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb