From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAQ9hSKH024731 for ; Wed, 26 Nov 2008 04:43:28 -0500 Received: from cathcart.site5.com (89.6b.364a.static.theplanet.com [74.54.107.137]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id mAQ9hGWA028715 for ; Wed, 26 Nov 2008 04:43:16 -0500 Message-ID: <492D1A2D.8070701@compulab.co.il> Date: Wed, 26 Nov 2008 11:43:09 +0200 From: Mike Rapoport MIME-Version: 1.0 To: Guennadi Liakhovetski References: <1227603594-16953-1-git-send-email-mike@compulab.co.il> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: video4linux-list@redhat.com Subject: Re: [PATCH] mt9m111: add support for mt9m112 since sensors seem identical List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Guennadi Liakhovetski wrote: > On Tue, 25 Nov 2008, Mike Rapoport wrote: > >> Signed-off-by: Mike Rapoport >> --- >> drivers/media/video/mt9m111.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c >> index da0b2d5..49c1167 100644 >> --- a/drivers/media/video/mt9m111.c >> +++ b/drivers/media/video/mt9m111.c >> @@ -841,7 +841,8 @@ static int mt9m111_video_probe(struct soc_camera_device *icd) >> data = reg_read(CHIP_VERSION); >> >> switch (data) { >> - case 0x143a: >> + case 0x143a: /* MT9M111 */ >> + case 0x148c: /* MT9M112 */ >> mt9m111->model = V4L2_IDENT_MT9M111; > > Wouldn't it be better to add a new chip ID? Are there any differences > between the two models, that the user might want to know about? I don't have mt9m111 datasheet, I can only judge by "feature comparison" table in the mt9m112 datasheet. It seems that sensors differ in there advanced image processing and low power mode capabilities. If you think it's worse adding new chip ID, I'll prepare the patches. > Thanks > Guennadi > >> icd->formats = mt9m111_colour_formats; >> icd->num_formats = ARRAY_SIZE(mt9m111_colour_formats); >> -- >> 1.5.6.4 >> >> -- >> video4linux-list mailing list >> Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe >> https://www.redhat.com/mailman/listinfo/video4linux-list >> > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > -- Sincerely yours, Mike. -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list