[linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Hi,

if the current tuned transponder is scanned only and the output needs the frequency of the
transponder, it is used the last frequency, which is found during the NIT scanning. This
is wrong. The attached patch will fix this problem.

Regards,
Hartmut



[-- Attachment #2: scan_fix_current_transponder_only.diff --]
[-- Type: text/x-diff, Size: 1437 bytes --]

signed-off-by: Hartmut Birr <e9hack@googlemail.com>
diff -r afd0efc0f9d2 util/scan/scan.c
--- a/util/scan/scan.c	Mon Nov 10 16:32:50 2008 +0100
+++ b/util/scan/scan.c	Mon Nov 17 10:20:02 2008 +0100
@@ -221,8 +221,6 @@ static struct transponder *find_transpon
 
 	list_for_each(pos, &scanned_transponders) {
 		tp = list_entry(pos, struct transponder, list);
-		if (current_tp_only)
-			return tp;
 		if (is_same_transponder(tp->param.frequency, frequency))
 			return tp;
 	}
@@ -879,9 +877,10 @@ static void parse_nit (const unsigned ch
 		if (tn.type == fe_info.type) {
 			/* only add if develivery_descriptor matches FE type */
 			t = find_transponder(tn.param.frequency);
-			if (!t)
+			if (!t && !current_tp_only)
 				t = alloc_transponder(tn.param.frequency);
-			copy_transponder(t, &tn);
+			if (t)
+				copy_transponder(t, &tn);
 		}
 
 		section_length -= descriptors_loop_len + 6;
@@ -2284,7 +2283,10 @@ int main (int argc, char **argv)
 	signal(SIGINT, handle_sigint);
 
 	if (current_tp_only) {
-		current_tp = alloc_transponder(0); /* dummy */
+		struct dvb_frontend_parameters frontend_params;
+		if (ioctl(frontend_fd, FE_GET_FRONTEND, &frontend_params) < 0)
+			fatal("FE_GET_FRONTEND failed: %d %m\n", errno);
+		current_tp = alloc_transponder(frontend_params.frequency);
 		/* move TP from "new" to "scanned" list */
 		list_del_init(&current_tp->list);
 		list_add_tail(&current_tp->list, &scanned_transponders);

[-- Attachment #3: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[Christoph Pfister]

2008/11/17 e9hack <e9hack@googlemail.com>:
> Hi,
>
> if the current tuned transponder is scanned only and the output needs the frequency of the
> transponder, it is used the last frequency, which is found during the NIT scanning. This
> is wrong. The attached patch will fix this problem.

Any opinion about this patch? It seems ok from a quick look, so I'll
apply it soon if nobody objects.

> Regards,
> Hartmut

Thanks,

Christoph

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[Alex Betis]

[-- Attachment #1.1: Type: text/plain, Size: 1553 bytes --]

On Tue, Dec 2, 2008 at 6:34 PM, Christoph Pfister <
christophpfister@gmail.com> wrote:

> 2008/11/17 e9hack <e9hack@googlemail.com>:
> > Hi,
> >
> > if the current tuned transponder is scanned only and the output needs the
> frequency of the
> > transponder, it is used the last frequency, which is found during the NIT
> scanning. This
> > is wrong. The attached patch will fix this problem.

I probably missed that post (or forgot about it already :)).

What scan is being discused? dvb-apps scan utility (or the scan-s2 that I
maintain)?


>
>
> Any opinion about this patch? It seems ok from a quick look, so I'll
> apply it soon if nobody objects.

I don't understand what's wrong with NIT advartised frequency?
For example, many satelite sites (such as lyngsat) have different
frequencies listed for the same channel, generally a difference of 1 MHz
here and there. That's probably caused since wide scans are probably done on
all the possible frequencies.
Since driver tunning algorithm can zigzag in some frequency bounds it will
probably be able to lock on the channel if you'll specify frequencies such
as the following, assuming the real channel frequency is 12000000:
11998000
11999000
12000000
12001000
12002000

NIT specifies the correct frequency and that one should be used next time to
tune.

Am I missing something?

>
>
> > Regards,
> > Hartmut
>
> Thanks,
>
> Christoph
>
> _______________________________________________
> linux-dvb mailing list
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

[-- Attachment #1.2: Type: text/html, Size: 2559 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

Alex Betis schrieb:
 > I don't understand what's wrong with NIT advartised frequency?
> For example, many satelite sites (such as lyngsat) have different
> frequencies listed for the same channel, generally a difference of 1 MHz
> here and there. 

If I do scan the tuned transponder only (parameter '-c'), scan will copy all NIT entries
to the same transponder data. The output contains the last frequency, which was found. On
DVB-C, the NIT contains the frequencies of all transponders. If VDR has tuned to the
113MHz transponder and I scan this transponder, I should got 113MHz and QAM64 modulation,
but I get e.g. 466MHz and QAM256 modulation. The frequency changes on every scan.

-Hartmut



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[Alex Betis]

[-- Attachment #1.1: Type: text/plain, Size: 1330 bytes --]

On Tue, Dec 2, 2008 at 9:43 PM, e9hack <e9hack@googlemail.com> wrote:

> Alex Betis schrieb:
>  > I don't understand what's wrong with NIT advartised frequency?
> > For example, many satelite sites (such as lyngsat) have different
> > frequencies listed for the same channel, generally a difference of 1 MHz
> > here and there.
>
> If I do scan the tuned transponder only (parameter '-c'), scan will copy
> all NIT entries
> to the same transponder data. The output contains the last frequency, which
> was found. On
> DVB-C, the NIT contains the frequencies of all transponders. If VDR has
> tuned to the
> 113MHz transponder and I scan this transponder, I should got 113MHz and
> QAM64 modulation,
> but I get e.g. 466MHz and QAM256 modulation. The frequency changes on every
> scan.

What driver and scan utility do you use?
If you use S2API driver, please try my scan-s2 from here:
http://mercurial.intuxication.org/hg/scan-s2/

I did several fixes in that area. If it still doesn't work, please run it
with "-vv" or "-vvv", (don't remember what level is needed) until you'll see
a HEX dump of the messages, send it to me and I'll take a look.


>
> -Hartmut
>
>
>
> _______________________________________________
> linux-dvb mailing list
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

[-- Attachment #1.2: Type: text/html, Size: 2142 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

Alex Betis schrieb:
> What driver and scan utility do you use?
I'm using the current linuxtv.org repository. I'm a DVB-C user. DVB-S2 isn't important for me.

> If you use S2API driver, please try my scan-s2 from here:
> http://mercurial.intuxication.org/hg/scan-s2/
If I use 'scan-s2 -c -o vdr', the output is wrong. I get:

Bayerisches FS Süd;ARD:201:202=deu,203=2ch;206=deu:204:0:28107:41985:1101:0

I should get:

Bayerisches FS Süd;ARD:346:M256:C:6900:201:202=deu,203=2ch;206=deu:204:0:28107:41985:0:0

Frequency, modulation, DVB type and symbol rate are still missing.

> I did several fixes in that area.
A fix for the lack ONID I did sent some time ago
(http://linuxtv.org/pipermail/linux-dvb/2007-April/017266.html). Nobody was interested.
The including of the polarization into the comparison of the transponders was also
discussed in the German vdr portal
(http://www.vdr-portal.de/board/thread.php?postid=746738#post746738).

I think there is a bug in the DVB-S/DVB-S2 code. If a NIT from a DVB-S transponder was
scanned and a new transponder was found, parse_nit() should create a transponder for DVB-S
and DVB-S2. Currently one new transponder is created and it is first initialized for DVB-S
and some lines later, it is reinitialized for DVB-S2.

-Hartmut


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[Alex Betis]

[-- Attachment #1.1: Type: text/plain, Size: 2202 bytes --]

On Wed, Dec 3, 2008 at 12:07 AM, e9hack <e9hack@googlemail.com> wrote:

> Alex Betis schrieb:
> > What driver and scan utility do you use?
> I'm using the current linuxtv.org repository. I'm a DVB-C user. DVB-S2
> isn't important for me.

I have only DVB-S/S2, so I can only guess. Your help will be appreciated in
order to fix DVB-C issues.


>
> > If you use S2API driver, please try my scan-s2 from here:
> > http://mercurial.intuxication.org/hg/scan-s2/
> If I use 'scan-s2 -c -o vdr', the output is wrong. I get:
>
> Bayerisches FS Süd;ARD:201:202=deu,203=2ch;206=deu:204:0:28107:41985:1101:0
>
> I should get:
>
> Bayerisches FS
> Süd;ARD:346:M256:C:6900:201:202=deu,203=2ch;206=deu:204:0:28107:41985:0:0
>
> Frequency, modulation, DVB type and symbol rate are still missing.

That's interesting. That means the utility doesn't know what delivery system
is used. Probably because it didn't tune the driver.
I'll check that. It should happen with DVB-S as well.
Can you scan the same channel without "-c" and report if the dump is
correct?


>
>
> > I did several fixes in that area.
> A fix for the lack ONID I did sent some time ago
> (http://linuxtv.org/pipermail/linux-dvb/2007-April/017266.html). Nobody
> was interested.

That was already fixed few days ago. Take latest version.

>
> The including of the polarization into the comparison of the transponders
> was also
> discussed in the German vdr portal
> (http://www.vdr-portal.de/board/thread.php?postid=746738#post746738).

That was already fixed few weeks ago.


>
>
> I think there is a bug in the DVB-S/DVB-S2 code. If a NIT from a DVB-S
> transponder was
> scanned and a new transponder was found, parse_nit() should create a
> transponder for DVB-S
> and DVB-S2. Currently one new transponder is created and it is first
> initialized for DVB-S
> and some lines later, it is reinitialized for DVB-S2.

You're right, transponder allocation is missing there. Will fix it, thanks.

>
>
> -Hartmut
>
>
> _______________________________________________
> linux-dvb mailing list
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

[-- Attachment #1.2: Type: text/html, Size: 3919 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

Alex Betis schrieb:
>>> If you use S2API driver, please try my scan-s2 from here:
>>> http://mercurial.intuxication.org/hg/scan-s2/
>> If I use 'scan-s2 -c -o vdr', the output is wrong. I get:
>>
>> Bayerisches FS Süd;ARD:201:202=deu,203=2ch;206=deu:204:0:28107:41985:1101:0
>>
>> I should get:
>>
>> Bayerisches FS
>> Süd;ARD:346:M256:C:6900:201:202=deu,203=2ch;206=deu:204:0:28107:41985:0:0
>>
>> Frequency, modulation, DVB type and symbol rate are still missing.
> 
> That's interesting. That means the utility doesn't know what delivery system
> is used. Probably because it didn't tune the driver.
> I'll check that. It should happen with DVB-S as well.

For the current transponder scanning, it isn't set any filter for NIT parsing. Since the
output format is zap and vdr only, it must be always setup a NIT filter:

diff -r 51eceb97c3bd scan.c
--- a/scan.c    Mon Dec 01 23:36:50 2008 +0200
+++ b/scan.c    Wed Dec 03 18:04:10 2008 +0100
@@ -2495,7 +2503,7 @@ static void scan_tp_dvb (void)
        add_filter (&s0);
        add_filter (&s1);

-       if (!current_tp_only) {
+       if (/*!current_tp_only*/1) {
                setup_filter (&s2, demux_devname, PID_NIT_ST, TID_NIT_ACTUAL, -1, 1, 0,
15); /* NIT */
                add_filter (&s2);
                if (get_other_nits) {

> Can you scan the same channel without "-c" and report if the dump is
> correct?

I need a little patch for tuning to DVB-C transponders:

diff -r 51eceb97c3bd scan.c
--- a/scan.c    Mon Dec 01 23:36:50 2008 +0200
+++ b/scan.c    Wed Dec 03 18:04:10 2008 +0100
@@ -1729,6 +1729,14 @@ static int __tune_to_transponder (int fr

        switch(t->delivery_system)
        {
+       case SYS_DVBC_ANNEX_AC:
+               if_freq = t->frequency;
+
+               if (verbosity >= 2){
+                       dprintf(1,"DVB-C frequency is %d\n", if_freq);
+               }
+               break;
+
        case SYS_DVBS:
        case SYS_DVBS2:
                if (lnb_type.high_val) {

It seems that the output is correct (currently not tested with vdr).

Regards,
Hartmut

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

[-- Attachment #1.1: Type: text/plain, Size: 894 bytes --]

2008/12/3 e9hack <e9hack@googlemail.com>

> For the current transponder scanning, it isn't set any filter for NIT
> parsing. Since the
> output format is zap and vdr only, it must be always setup a NIT filter:
>
> diff -r 51eceb97c3bd scan.c
> --- a/scan.c    Mon Dec 01 23:36:50 2008 +0200
> +++ b/scan.c    Wed Dec 03 18:04:10 2008 +0100
> @@ -2495,7 +2503,7 @@ static void scan_tp_dvb (void)
>        add_filter (&s0);
>        add_filter (&s1);
>
> -       if (!current_tp_only) {
> +       if (/*!current_tp_only*/1) {
>                setup_filter (&s2, demux_devname, PID_NIT_ST,
> TID_NIT_ACTUAL, -1, 1, 0,
> 15); /* NIT */
>                add_filter (&s2);
>                if (get_other_nits) {
>

I forgot, frequency and modulation are wrong as in the original scan
application. The values are from last parsed NIT entry, which isn't from the
current transponder.

Regards,
Hartmut

[-- Attachment #1.2: Type: text/html, Size: 1425 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[Alex Betis]

[-- Attachment #1.1: Type: text/plain, Size: 1464 bytes --]

2008/12/3 <e9hack@googlemail.com>

> 2008/12/3 e9hack <e9hack@googlemail.com>
>
>> For the current transponder scanning, it isn't set any filter for NIT
>> parsing. Since the
>> output format is zap and vdr only, it must be always setup a NIT filter:
>>
>> diff -r 51eceb97c3bd scan.c
>> --- a/scan.c    Mon Dec 01 23:36:50 2008 +0200
>> +++ b/scan.c    Wed Dec 03 18:04:10 2008 +0100
>> @@ -2495,7 +2503,7 @@ static void scan_tp_dvb (void)
>>        add_filter (&s0);
>>        add_filter (&s1);
>>
>> -       if (!current_tp_only) {
>> +       if (/*!current_tp_only*/1) {
>>                setup_filter (&s2, demux_devname, PID_NIT_ST,
>> TID_NIT_ACTUAL, -1, 1, 0,
>> 15); /* NIT */
>>                add_filter (&s2);
>>                if (get_other_nits) {
>>
>
> I forgot, frequency and modulation are wrong as in the original scan
> application. The values are from last parsed NIT entry, which isn't from the
> current transponder.

There is no need for NIT message. I've added query from driver for currently
tuned parameters - should work for DVB-T and DVB-C users. DVB-S/S2 will get
IF frequency, which is not the real transponder frequency.
Please update to latest version.
Your other patch for DVB-C scan is also there.

Let me know if it helps.

Regards,
Alex.

>
>
> Regards,
> Hartmut
>
> _______________________________________________
> linux-dvb mailing list
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

[-- Attachment #1.2: Type: text/html, Size: 2603 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

Alex Betis schrieb:

> There is no need for NIT message. I've added query from driver for currently
> tuned parameters - should work for DVB-T and DVB-C users. DVB-S/S2 will get
> IF frequency, which is not the real transponder frequency.
> Please update to latest version.
> Your other patch for DVB-C scan is also there.
> 
> Let me know if it helps.
> 

It works with the stv0297 and the tda10021 frontend. If the transponder was tuned with the
modulation QAM_AUTO, it would be better to read the current modulation from the frontend.
Currently, QAM_AUTO isn't implemented for a DVB-C frontend, but I'm working on an
implementation for the stv0297.

Regards,
Hartmut

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[Alex Betis]

[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]

On Mon, Dec 8, 2008 at 10:21 PM, e9hack <e9hack@googlemail.com> wrote:

> Alex Betis schrieb:
>
> > There is no need for NIT message. I've added query from driver for
> currently
> > tuned parameters - should work for DVB-T and DVB-C users. DVB-S/S2 will
> get
> > IF frequency, which is not the real transponder frequency.
> > Please update to latest version.
> > Your other patch for DVB-C scan is also there.
> >
> > Let me know if it helps.
> >
>
> It works with the stv0297 and the tda10021 frontend. If the transponder was
> tuned with the
> modulation QAM_AUTO, it would be better to read the current modulation from
> the frontend.

All the tuned parameters are read from the frontend, the problem is that the
frontend returns the values that were used to tune, not the real tuned
values, so if tuning was done with QAM_AUTO, scan-s2 output will not include
modulation since frontend returned QAM_AUTO.


> Currently, QAM_AUTO isn't implemented for a DVB-C frontend, but I'm working
> on an
> implementation for the stv0297.
>
> Regards,
> Hartmut
>
> _______________________________________________
> linux-dvb mailing list
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

[-- Attachment #1.2: Type: text/html, Size: 1930 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

Alex Betis schrieb:
> All the tuned parameters are read from the frontend, the problem is that the
> frontend returns the values that were used to tune, not the real tuned
> values, so if tuning was done with QAM_AUTO, scan-s2 output will not include
> modulation since frontend returned QAM_AUTO.

The parameters are read from property cache and not from frontend. I've add a second ioctl
call for FE_GET_FRONTEND. This will read the real modulation type.

Regards,
Hartmut

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH]Fix a bug in scan, which outputs the wrong frequency if the current tuned transponder is scanned only

[e9hack]

Christoph Pfister schrieb:
> 2008/11/17 e9hack <e9hack@googlemail.com>:
>> Hi,
>>
>> if the current tuned transponder is scanned only and the output needs the frequency of the
>> transponder, it is used the last frequency, which is found during the NIT scanning. This
>> is wrong. The attached patch will fix this problem.
> 
> Any opinion about this patch? It seems ok from a quick look, so I'll
> apply it soon if nobody objects.

After some more investigation, my patch has some problems:

1)Usually the patch is only necessary for transponders, which transmits NIT data of other
transponders (DVB-C only?).

2)It will not work with DVB-S. On DVB-S the returned frequency from frontend is the
LNB-IF. It must be convert to the transponder frequency depend on the LNB configuration.
Scan can't read the LNB configuration from frontend. It must trust the given parameters.

3)On DVB-S, the reported frequency from frontend contains the offset from zigzag scan. If
the offset is greater than 2kHz, scan can't find the correct frequency within the NIT data.

3)The reported frequency from many frontends contains a measured offset. If the offset is
  greater than 2kHz, see above.

Depend on this 4 points, scan should not report any transponder infos, if the current
transponder is scanned only (scan does not tune itself) and if the output format must
contain the frequency of the transponder.

-Hartmut

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb