From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Jim Paris <jim@jtan.com>
Cc: video4linux-list@redhat.com
Subject: Re: gspca: fix vidioc_s_jpegcomp locking
Date: Wed, 10 Dec 2008 09:25:53 +0100 [thread overview]
Message-ID: <493F7D11.405@hhs.nl> (raw)
In-Reply-To: <20081209220858.GA25496@psychosis.jim.sh>
Jim Paris wrote:
> Hans de Goede wrote:
>> Jim Paris wrote:
>>> This locking looked wrong.
>>>
>> Hi,
>>
>> I appreciate the effort, but please do not send patches just because
>> something looks wrong. The original code is perfectly fine. It check if
>> the sub driver supports set_jcomp at all, this check does not need
>> locking.
>
> Well, the patch was a request for comments. But please double-check.
> In the current code, if set_jcomp is NULL, the lock is taken but never
> released.
>
> I agree that the check does not need locking, which is why my change
> moved the check outside the lock.
>
Blergh, sorry I completely misread your patch, somehow reversing what it did in
my head.
You are completely right, the original code is wrong, and this patch needs to
be applied.
Sorry!
Regards,
Hans
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
prev parent reply other threads:[~2008-12-10 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 21:58 gspca: fix vidioc_s_jpegcomp locking Jim Paris
2008-12-09 21:59 ` Hans de Goede
2008-12-09 22:08 ` Jim Paris
2008-12-10 8:25 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493F7D11.405@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=jim@jtan.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox