public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert William Fuller <hydrologiccycle@gmail.com>
To: "video4linux-list@redhat.com" <video4linux-list@redhat.com>
Subject: Re: [REVIEW PATCH 13/14] OMAP: CAM: Add Lens Driver
Date: Fri, 12 Dec 2008 03:44:03 -0500	[thread overview]
Message-ID: <49422453.8080000@gmail.com> (raw)
In-Reply-To: <208cbae30812112203o6be4974epb87b3810e2de3581@mail.gmail.com>

Alexey Klimov wrote:

<snip>

 > I didn't ever see two "=" in one line in code. Is it okay ?

If you do not understand the C programming language, why are you in a 
position to review code?

The "=" operator associates from right to left.  Hence, in the case of 
"a = b = c", c is first assigned to b, then b is assigned to a.

You should understand the concepts of operator precedence and operator 
associativity before you are in a position to review C code.  This is 
elementary.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-12-12  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 20:38 [REVIEW PATCH 13/14] OMAP: CAM: Add Lens Driver Aguirre Rodriguez, Sergio Alberto
2008-12-12  6:03 ` Alexey Klimov
2008-12-12  8:44   ` Robert William Fuller [this message]
2008-12-12 12:25     ` Douglas Schilling Landgraf
2008-12-16 20:24   ` Aguirre Rodriguez, Sergio Alberto
2008-12-16 17:38 ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49422453.8080000@gmail.com \
    --to=hydrologiccycle@gmail.com \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox