Janne, Thanks for your' response. Hopefuly this patch addresses all of your concerns. I am not including the API changes at the moment. I'll try again on that after this gets committed (the number of folks working with DCII is very small, as far as I'm aware, so the other modulation types can be handled later) There were a fewquestions which I'll try to answer here as well: > Do the values for the FEC in cmd[9] depend on the > modulation? Yes, each modulation can have completely different meanings for cmd[9] > I would prefer a S2API command DTV_TURBO_MODES over duplicating > modulations. Especially since the the implemtation in the driver differs > only for QPSK and QPSK_TURBO. > The downside to this is that it requires more changes inside of the user-space software to do something special with these modulations. They really are completely different than non-turbo modes. But as the only interesting case is Turbo-QPSK, and I'm not sure which satellites even broadcast it, that may be ok. >> + QPSK_DCII_C, >> + QPSK_DCII_I, >> + QPSK_DCII_Q, >> > > Are all three needed? What does the last character mean? > I'm not an expert in DCII, and don't know much about it. This set of code came directly from the vendor. Here is the best description of DCII that I've seen though: http://www.coolstf.com/mpeg/#dcii ---------------------- This patch converts the gp8psk module to use the S2API. It pretends to be DVB-S2 capable in order to allow the various supported modulations (8PSK, QPSK-Turbo, etc), and keep software compatibility with the S2API patches for Mythtv and VDR. Signed-off by: Alan Nisota