public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Krufky <mkrufky@linuxtv.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: video4linux-list@redhat.com,
	v4lm <v4l-dvb-maintainer@linuxtv.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [v4l-dvb-maintainer] Moving to git for v4l-dvb
Date: Wed, 17 Dec 2008 09:18:51 -0500	[thread overview]
Message-ID: <49490A4B.90609@linuxtv.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0812171444420.5465@axis700.grange>

Guennadi Liakhovetski wrote:
> Sorry for reviving this almost-a-year-old thread, but after my last 
> failure to formst hg-commits correctly, I'd like to have this clarified 
> before causing Mauro extra manual editing of my commits again.
>
> On Thu, 14 Feb 2008, Mauro Carvalho Chehab wrote:
>
> [snip]
>
>   
>> -git trees have two different meta-tags to represent the tree owner _and_ the
>> patch author. A patch can be committed by a maintainer, preserving author's
>> ownership. On Mercurial, there's only one meta-tag. So, each developer needs to
>> manually add a line with:
>> 	From: someone <some@email>
>> To represent the missing authorship. I need some scripts to convert this "From"
>> artificial field into an Author, before generating the -git.
>>     
>
> later
>
> On Tue, 22 Apr 2008, Mauro Carvalho Chehab wrote:
>
>   
>> In general, you ask me to pull a patch series with yours and also third part
>> patches. Please, be sure to add a "From: " line at the patch, since Mercurial
>> has no meta-tag to indicate patch authorship. The only meta tag for someone is
>> "user". We use this meta-tag to help tracking from what tree a changeset were 
>> merged.
>>     
>
> and recently
>
> On Mon, 8 Dec 2008, Mauro Carvalho Chehab wrote:
>
>   
>> On -git, you have two different fields: the committer and the patch author.
>> Since mercurial has just one field, we should take some care, since, depending
>> on the way you import things into mercurial, you may lead to bad author
>> attribution.
>>
>> To avoid this risk, we've added an extra tag on all mercurial commits. Also, my
>> -git import scripts don't automatically merge any patch that comes without the 
>> "from" field. Those patches require manual work to forward. This way, I have a 
>> double check procedure there.
>>     
>
> So, what should a patch header look like to be imported into hg per "hg 
> import" for later push to linuxtv to be pulled by Mauro?
>
> Looks like it should have two "From: " lines - one will be used by hg for 
> the user field and should contain my address, the second "From: " line 
> should contain the actual patch author? All quotes above mention only one 
> "From: ", and this is what a git-format-patch produces, but it looks like 
> this single "From: " is then consumed by hg to form its "user" field, so 
> nothing is left for a subsequent re-export to git.
>
> Thanks
> Guennadi
>
>   

Guennadi,

Please take a look at one of the hg patches within the repository:

http://linuxtv.org/hg/v4l-dvb/raw-rev/3cc7daa31234

This patch is the same type of output that you would get from using "hg export 3cc7daa31234"

Notice the "From:" line -- that line is used to indicate author.

Notice the "User" line (line 2) -- that line is used to indicate committer.

Does that help to clear it up for you?

Regards,

Mike

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-12-17 14:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05  1:24 NACK NACK! [PATCH] Add two new fourcc codes for 16bpp formats Brandon Philips
2008-02-05  7:16 ` Guennadi Liakhovetski
2008-02-05  8:00   ` Brandon Philips
2008-02-05 12:24     ` Mauro Carvalho Chehab
     [not found]       ` <20080213202055.GA26352@plankton.ifup.org>
2008-02-13 23:24         ` [v4l-dvb-maintainer] Moving to git for v4l-dvb Michael Krufky
2008-02-13 23:54           ` Alex Deucher
2008-02-14  0:56             ` Michael Krufky
2008-02-13 23:55           ` hermann pitton
2008-02-14  2:34           ` Brandon Philips
2008-02-14  2:35             ` Michael Krufky
2008-02-14 12:20               ` Mauro Carvalho Chehab
2008-02-14 19:46         ` Mauro Carvalho Chehab
2008-02-14 23:08           ` Brandon Philips
2008-12-17 14:12           ` Guennadi Liakhovetski
2008-12-17 14:18             ` Michael Krufky [this message]
2008-12-17 14:33               ` Guennadi Liakhovetski
2008-12-17 16:52                 ` Mauro Carvalho Chehab
2008-12-17 17:05                   ` Guennadi Liakhovetski
2008-12-17 18:23                     ` Mauro Carvalho Chehab
2008-02-05 13:23 ` NACK NACK! [PATCH] Add two new fourcc codes for 16bpp formats Michael Krufky
2008-02-05 14:01   ` Mauro Carvalho Chehab
2008-02-05 23:15     ` Brandon Philips
2008-02-06  1:27       ` Michael Krufky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49490A4B.90609@linuxtv.org \
    --to=mkrufky@linuxtv.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=mchehab@infradead.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox