From: "Fábio Belavenuto" <belavenuto@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: video4linux-list@redhat.com
Subject: Re: [PATCH] Add TEA5764 radio driver
Date: Thu, 18 Dec 2008 18:13:36 -0300 [thread overview]
Message-ID: <494ABD00.8070106@gmail.com> (raw)
In-Reply-To: <200812181252.24661.hverkuil@xs4all.nl>
Hans Verkuil escreveu:
> Hi Fabio,
>
> On Wednesday 17 December 2008 23:49:33 Fabio Belavenuto wrote:
>
>> Add support for radio driver TEA5764 from NXP.
>> This chip is connected in pxa I2C bus in EZX phones
>> from Motorola, the chip is used in phone model A1200.
>> This driver is for OpenEZX project (www.openezx.org)
>> Tested with A1200 phone, openezx kernel and fm-tools
>>
>> Signed-off-by: Fabio Belavenuto <belavenuto@gmail.com>
>>
>> drivers/media/radio/Kconfig | 19 +
>> drivers/media/radio/Makefile | 1 +
>> drivers/media/radio/radio-tea5764.c | 641
>> +++++++++++++++++++++++++++++++++++ 3 files changed, 661 insertions(+), 0
>> deletions(-)
>>
>>
>
> I'm sorry, but this isn't the right approach. This chip is a radio tuner and
> as such can be used in many other products. So the tea5764 driver should be
> implemented as a tuner driver instead. See drivers/media/common/tuners for
> other such drivers, including the close cousins tea5761 and tea5767.
>
> Next to that you need a v4l radio driver for this platform that loads the
> tuner module and sets it up correctly.
>
> Basically this driver needs to be split into a tuner driver and a v4l driver
> for this platform.
>
> The big advantage is that the tea5764 driver can be reused in other
> products, and also that it is easy to change the v4l driver if another
> tuner chip is chosen in the future.
>
> BTW, it might be possible that the tea5764 is very similar to the existing
> tea radio drivers. In that case you might want to consider adding support
> for this new variant to an existing driver, rather than creating a new
> driver. I've never looked at the datasheets for these chips, so I don't
> know how feasible that is.
>
> Regards,
>
> Hans
>
>
Thank you, I understand, I will do so.
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
next prev parent reply other threads:[~2008-12-18 20:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 22:49 [PATCH] Add TEA5764 radio driver Fabio Belavenuto
2008-12-18 1:57 ` Alexey Klimov
2008-12-18 21:12 ` Fábio Belavenuto
2008-12-18 11:52 ` Hans Verkuil
2008-12-18 21:13 ` Fábio Belavenuto [this message]
2008-12-30 22:32 ` Mauro Carvalho Chehab
2008-12-31 9:52 ` Hans Verkuil
2008-12-31 10:12 ` Mauro Carvalho Chehab
2009-01-02 2:22 ` Fábio Belavenuto
2009-02-11 7:10 ` Hans Verkuil
2009-02-17 16:38 ` Fabio Belavenuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494ABD00.8070106@gmail.com \
--to=belavenuto@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox