Re: [PATCH] Add TEA5764 radio driver

["Fábio Belavenuto" <belavenuto@gmail.com>]

Mauro Carvalho Chehab escreveu:
> On Wed, 31 Dec 2008 10:52:40 +0100
> Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
>   
>> Hi Mauro,
>>
>> Did you see my review of this driver?
>>
>> (http://lists-archives.org/video4linux/26062-add-tea5764-radio-driver.html)
>>
>> IMHO this driver shouldn't be added in this form. It's up to you of course 
>> to decide this, but I just want to make sure you read my posting.
>>     
>
> No, I haven't seen. I'm not sure why, but patchwork didn't show me your review.
>
> My comments about the points you raised:
>
> a) Yes, the proper approach is to split it into 2 separate drivers:
> 	1) a Motorola i2c bridge driver;
> 	2) a generic tea5764 driver;
>
> I would very much appreciate if Fabio can do this work, allowing others to use
> tea5764 driver;
>
> b) AFAIK, tea5764 is not so close to tea5767, so probably the right decision is
> to have it as a separate driver;
>
> c) The same design trouble on radio-tea5764 is also present on other radio-*
> drivers;
>
> d) While this design doesn't allow sharing tea5764 driver, for now, we have at
> least something. A future patch may split it into two drivers. That's why I
> decided to apply it.
>
> Fábio,
>
> Could you please work on split it into two drivers? You can use cx88 or saa7134
> as examples. On those drivers, the i2c stuff is at *-i2c.c, and the radio
> interface are at *-video.c.
>
> Cheers,
> Mauro
>   
Yes, I will change the driver, I will create 2 as explained, thanks.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list