Re: [linux-dvb] MC44S803 frontend

Re: [linux-dvb] MC44S803 frontend

[Jochen Friedrich]

Hi Roberto,

> Is there any plan to include this frontend in mainline kernels?
> I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table.
I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Thanks,
Jochen

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend

[Antti Palosaari]

Jochen Friedrich wrote:
> Hi Roberto,
> 
>> Is there any plan to include this frontend in mainline kernels?
>> I used to run this driver months ago and it was working well.
> 
> The reason is the huge memory footprint due to the included frequency table.
> I worked a bit on the driver to get rid of this table. Could you try this version:
> 
> 1. Patch for AF9015:
> 
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690
> 
> 2. MC44S80x tuner driver:
> 
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Is it possible to add this driver to the linuxtv.org repo? My, or Manu 
or you? Looks like there is only one device using this driver currently.

Also Manu's original mxl500x driver seems to be much more sensitive than 
current mxl5005s. I don't know what we should do with this driver, but 
from users perspective this situation is not good. There is rather many 
devices using this tuner.

> 
> Thanks,
> Jochen

regards
Antti
-- 
http://palosaari.fi/

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend

[Roberto Ragusa]

Jochen Friedrich wrote:
> Hi Roberto,
> 
>> Is there any plan to include this frontend in mainline kernels?
>> I used to run this driver months ago and it was working well.
> 
> The reason is the huge memory footprint due to the included frequency table.
> I worked a bit on the driver to get rid of this table. Could you try this version:
> 
> 1. Patch for AF9015:
> 
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690
> 
> 2. MC44S80x tuner driver:
> 
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Hi Jochen,

thank you for your work. I see the table values are gone and
parameters are computed by the code.

I will only be able to test this driver in a couple of days, as I do
not have the hardware (Cinergy T USB XE Ver.2) with me at the moment.

Do you prefer me to apply the patch to one tree in particular?

-- 
   Roberto Ragusa    mail at robertoragusa.it

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend

[Detlef Rohde]

Hi All,
from Roberto's latest posting I see that there is some effort in solving 
my shortly before reported problem. As an owner of a Cinergy T USB XE 
Ver.2- stick which works fine under WXP I am bothering for a while i.o. 
to get rid of problems running it under linux. Could anyone please list 
some easy steps how I can set up a working hardwaredriver? Currently I 
have installed: 1. Driver for Afatech 9015, 2. Driver for devices based 
on Afatech 9015, driver for the AF901x demodulator. The first is 
reported as being activated and in use, the latter two which are bundled 
together appear as activated but not in use. This report comes from my 
hardware driver info in Ubuntu Intrepid. Have tried to switch this one 
to be in use with no success. I am uncertain if I need all this stuff or 
should remove 2). As a linux newbie I am not familiar with compiling and 
merging software changes in existing drivers. Hope you can help.
Best regards,
Detlef

Roberto Ragusa schrieb:
> Jochen Friedrich wrote:
>   
>> Hi Roberto,
>>
>>     
>>> Is there any plan to include this frontend in mainline kernels?
>>> I used to run this driver months ago and it was working well.
>>>       
>> The reason is the huge memory footprint due to the included frequency table.
>> I worked a bit on the driver to get rid of this table. Could you try this version:
>>
>> 1. Patch for AF9015:
>>
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690
>>
>> 2. MC44S80x tuner driver:
>>
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>>     
>
> Hi Jochen,
>
> thank you for your work. I see the table values are gone and
> parameters are computed by the code.
>
> I will only be able to test this driver in a couple of days, as I do
> not have the hardware (Cinergy T USB XE Ver.2) with me at the moment.
>
> Do you prefer me to apply the patch to one tree in particular?
>
>   


-- 
Dipl.-Ing. Detlef Rohde
Titiseestr. 12
D-13469 Berlin
Phone: +4930 4021731
A.R.S.: DL7IY


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend

[Jochen Friedrich]

Hi Antti,

> Is it possible to add this driver to the linuxtv.org repo? My, or Manu 
> or you? Looks like there is only one device using this driver currently.

IMHO it would be best to add this to your AF9015 tree. I hope with the now reduced
memory size there is no more reason to reject this driver from being included in the
kernel source.

Unfortunately, I'm on holidays for the next two weeks and I don't know if I have internet
connectivity all the time.

> Also Manu's original mxl500x driver seems to be much more sensitive than 
> current mxl5005s. I don't know what we should do with this driver, but 
> from users perspective this situation is not good. There is rather many 
> devices using this tuner.

Sorry, but I don't have this chip so I can't comment on this one.

Thanks,
Jochen

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend

[Jochen Friedrich]

Hi Roberto,

> I will only be able to test this driver in a couple of days, as I do
> not have the hardware (Cinergy T USB XE Ver.2) with me at the moment.

No problem. I'm on holidays for the next two weeks as well.

> Do you prefer me to apply the patch to one tree in particular?

Not really. The patches are against 2.6.28-rc9.

Thanks,
Jochen

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend

[Jose Alberto Reguero]

El Viernes, 19 de Diciembre de 2008, Antti Palosaari escribió:
> Jochen Friedrich wrote:
> > Hi Roberto,
> >
> >> Is there any plan to include this frontend in mainline kernels?
> >> I used to run this driver months ago and it was working well.
> >
> > The reason is the huge memory footprint due to the included frequency
> > table. I worked a bit on the driver to get rid of this table. Could you
> > try this version:
> >
> > 1. Patch for AF9015:
> >
> > http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a
> >4b2d3c520d949e53bbf7667a481e9690
> >
> > 2. MC44S80x tuner driver:
> >
> > http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/
> >common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bd
> >e668b4eca90f8bdcc5916dfc88c115a3dfd20
> > http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/
> >common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bd
> >e668b4eca90f8bdcc5916dfc88c115a3dfd20
> > http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/
> >common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb
> >=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>
> Is it possible to add this driver to the linuxtv.org repo? My, or Manu
> or you? Looks like there is only one device using this driver currently.
>
> Also Manu's original mxl500x driver seems to be much more sensitive than
> current mxl5005s. I don't know what we should do with this driver, but
> from users perspective this situation is not good. There is rather many
> devices using this tuner.
>

Are your drive using MXL_TF_DEFAULT?
I noticed that in the new driver MXL_TF_DEFAULT is missing in the code.

Jose Alberto

> > Thanks,
> > Jochen
>
> regards
> Antti



_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend (it works)

[Roberto Ragusa]

(to both linux-dvb and linux-media)

Jochen Friedrich wrote:
> Hi Roberto,
> 
>> Is there any plan to include this frontend in mainline kernels?
>> I used to run this driver months ago and it was working well.
> 
> The reason is the huge memory footprint due to the included frequency table.
> I worked a bit on the driver to get rid of this table. Could you try this version:
> 
> 1. Patch for AF9015:
> 
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690
> 
> 2. MC44S80x tuner driver:
> 
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Finally managed to try your version. It works, with no apparent issue.

Scanning is OK, tuning is OK.
I can't test signals below 600MHz at the moment, but I will try (possibly VHF too)
in a couple of days, just to be sure about the frequency handling code.
Also tried removing the USB stick while playing a stream; the devices
were correctly removed when the user space apps closed them.

In my (user) opinion this driver is ready to be merged.

I actually fixed some trivial compilation issues in the driver.

--- a/linux/drivers/media/common/tuners/mc44s80x.c    2009-01-05 12:38:11.000000000 +0100
+++ b/linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100
@@ -470,12 +470,12 @@

        mc44s80x_set_power(state, 0); /* disable powerdown */
        printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg1, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Write error\n");
                goto exit;
        }
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg2, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Read error, Reg=[0x%02x]\n",
                       TUNER_ADDR + 1);
@@ -495,7 +495,7 @@
        return 0;
 unk:
        printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
-              "(0x%02x)\n", __func__, id);
+              "(0x%02x)\n", id);
        goto out;
 exit:
        if (fe->ops.i2c_gate_ctrl)
@@ -512,7 +512,7 @@
        int err = 0;

        printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 0x%p\n", i2c);
-       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
+       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
        if (state == NULL) {
                err = -ENOMEM;
                goto exit;

> Thanks,
> Jochen

Thanks to you.

-- 
   Roberto Ragusa    mail at robertoragusa.it

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend (it works)

[Detlef Rohde]

Hi Roberto,
tnx for doing your test! As a Linux-newbie I better wait now until I can 
use a merged driver since I had bad experiences with former trys i.e. 
OS-crashes. Hopefully one Jochen or somebody else can soon do the rest. 
Meanwhile I am experimenting with a WXP-Pro VM running on  my Ubuntu 
Intrepid Installation. Will try the native Terratec-SW on this machine.
Best regards,
Detlef

Roberto Ragusa schrieb:
> (to both linux-dvb and linux-media)
>
> Jochen Friedrich wrote:
>   
>> Hi Roberto,
>>
>>     
>>> Is there any plan to include this frontend in mainline kernels?
>>> I used to run this driver months ago and it was working well.
>>>       
>> The reason is the huge memory footprint due to the included frequency table.
>> I worked a bit on the driver to get rid of this table. Could you try this version:
>>
>> 1. Patch for AF9015:
>>
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690
>>
>> 2. MC44S80x tuner driver:
>>
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>>     
>
> Finally managed to try your version. It works, with no apparent issue.
>
> Scanning is OK, tuning is OK.
> I can't test signals below 600MHz at the moment, but I will try (possibly VHF too)
> in a couple of days, just to be sure about the frequency handling code.
> Also tried removing the USB stick while playing a stream; the devices
> were correctly removed when the user space apps closed them.
>
> In my (user) opinion this driver is ready to be merged.
>
> I actually fixed some trivial compilation issues in the driver.
>
> --- a/linux/drivers/media/common/tuners/mc44s80x.c    2009-01-05 12:38:11.000000000 +0100
> +++ b/linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100
> @@ -470,12 +470,12 @@
>
>         mc44s80x_set_power(state, 0); /* disable powerdown */
>         printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
> -       err = i2c_transfer(state->i2c, &msg, 1);
> +       err = i2c_transfer(state->i2c, msg1, 1);
>         if (err != 1) {
>                 printk(KERN_WARNING "mc44s80x: Write error\n");
>                 goto exit;
>         }
> -       err = i2c_transfer(state->i2c, &msg, 1);
> +       err = i2c_transfer(state->i2c, msg2, 1);
>         if (err != 1) {
>                 printk(KERN_WARNING "mc44s80x: Read error, Reg=[0x%02x]\n",
>                        TUNER_ADDR + 1);
> @@ -495,7 +495,7 @@
>         return 0;
>  unk:
>         printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
> -              "(0x%02x)\n", __func__, id);
> +              "(0x%02x)\n", id);
>         goto out;
>  exit:
>         if (fe->ops.i2c_gate_ctrl)
> @@ -512,7 +512,7 @@
>         int err = 0;
>
>         printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 0x%p\n", i2c);
> -       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
> +       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
>         if (state == NULL) {
>                 err = -ENOMEM;
>                 goto exit;
>
>   
>> Thanks,
>> Jochen
>>     
>
> Thanks to you.
>
>   


-- 
Dipl.-Ing. Detlef Rohde
Titiseestr. 12
D-13469 Berlin
Phone: +4930 4021731
A.R.S.: DL7IY



Roberto Ragusa schrieb:
> (to both linux-dvb and linux-media)
>
> Jochen Friedrich wrote:
>   
>> Hi Roberto,
>>
>>     
>>> Is there any plan to include this frontend in mainline kernels?
>>> I used to run this driver months ago and it was working well.
>>>       
>> The reason is the huge memory footprint due to the included frequency table.
>> I worked a bit on the driver to get rid of this table. Could you try this version:
>>
>> 1. Patch for AF9015:
>>
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690
>>
>> 2. MC44S80x tuner driver:
>>
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
>>     
>
> Finally managed to try your version. It works, with no apparent issue.
>
> Scanning is OK, tuning is OK.
> I can't test signals below 600MHz at the moment, but I will try (possibly VHF too)
> in a couple of days, just to be sure about the frequency handling code.
> Also tried removing the USB stick while playing a stream; the devices
> were correctly removed when the user space apps closed them.
>
> In my (user) opinion this driver is ready to be merged.
>
> I actually fixed some trivial compilation issues in the driver.
>
> --- a/linux/drivers/media/common/tuners/mc44s80x.c    2009-01-05 12:38:11.000000000 +0100
> +++ b/linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100
> @@ -470,12 +470,12 @@
>
>         mc44s80x_set_power(state, 0); /* disable powerdown */
>         printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
> -       err = i2c_transfer(state->i2c, &msg, 1);
> +       err = i2c_transfer(state->i2c, msg1, 1);
>         if (err != 1) {
>                 printk(KERN_WARNING "mc44s80x: Write error\n");
>                 goto exit;
>         }
> -       err = i2c_transfer(state->i2c, &msg, 1);
> +       err = i2c_transfer(state->i2c, msg2, 1);
>         if (err != 1) {
>                 printk(KERN_WARNING "mc44s80x: Read error, Reg=[0x%02x]\n",
>                        TUNER_ADDR + 1);
> @@ -495,7 +495,7 @@
>         return 0;
>  unk:
>         printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
> -              "(0x%02x)\n", __func__, id);
> +              "(0x%02x)\n", id);
>         goto out;
>  exit:
>         if (fe->ops.i2c_gate_ctrl)
> @@ -512,7 +512,7 @@
>         int err = 0;
>
>         printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 0x%p\n", i2c);
> -       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
> +       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
>         if (state == NULL) {
>                 err = -ENOMEM;
>                 goto exit;
>
>   
>> Thanks,
>> Jochen
>>     
>
> Thanks to you.
>
>   


-- 
Dipl.-Ing. Detlef Rohde
Titiseestr. 12
D-13469 Berlin
Phone: +4930 4021731
A.R.S.: DL7IY


_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend (it works)

[Luís Silva]

Hi.
> Finally managed to try your version. It works, with no apparent issue.
Thank you all for this good work. Any ideas as to when will these files hit 
the mercurial repos at linuxtv.org?
-- 
Luís A. C. Silva
lacsilva@gmail.com

_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] MC44S803 frontend (it works)

[Roberto Ragusa]

Luís Silva wrote:
> Hi.

>> Finally managed to try your version. It works, with no apparent issue.

> Thank you all for this good work. Any ideas as to when will these files hit 
> the mercurial repos at linuxtv.org?

That is not under my control.

I hope someone will route this driver into official trees.

I can also add that additional tests on VHF frequencies
have been successful too.

Best regards.

-- 
   Roberto Ragusa    mail at robertoragusa.it

Re: [linux-dvb] MC44S803 frontend (it works)

[Jochen Friedrich]

Hi Roberto,

>> Thank you all for this good work. Any ideas as to when will these files hit 
>> the mercurial repos at linuxtv.org?
> 
> That is not under my control.
> I hope someone will route this driver into official trees.

As the tuner driver currently is only used with AF9015 frontends, I hope Antti will pick this one up.
I can resubmit with a Signed-off-by if required.

> I can also add that additional tests on VHF frequencies
> have been successful too.

Cool.

Thanks,
Jochen

Re: [linux-dvb] MC44S803 frontend (it works)

[Antti Palosaari]

Jochen Friedrich wrote:
> Hi Roberto,
> 
>>> Thank you all for this good work. Any ideas as to when will these files hit 
>>> the mercurial repos at linuxtv.org?
>> That is not under my control.
>> I hope someone will route this driver into official trees.
> 
> As the tuner driver currently is only used with AF9015 frontends, I hope Antti will pick this one up.
> I can resubmit with a Signed-off-by if required.

Could you explain for changes af9015_i2c_xfer() done? Is it for case I2C 
READ coming from MC44S803 but tuner does not implement read at all? Is 
it really needed?

Maybe I can move MC44S803 and needed AF9015 changes to my devel tree at 
linuxtv.org... But that does not change problem that tuner is not still 
in v4l-dvb-master nor coming for Kernel before Manu will pull it.

>> I can also add that additional tests on VHF frequencies
>> have been successful too.
> 
> Cool.
> 
> Thanks,
> Jochen

regards
Antti
-- 
http://palosaari.fi/

Re: [linux-dvb] MC44S803 frontend (it works)

[Antti Palosaari]

Manu,
looks like your MC44S803 driver is in very good shape with Jochen's 
changes. When you are planning to push it to the v4l-dvb or Kernel?

regards
Antti
-- 
http://palosaari.fi/

Re: [linux-dvb] MC44S803 frontend (it works)

[Jochen Friedrich]

Hi Antti,

> Could you explain for changes af9015_i2c_xfer() done? Is it for case I2C 
> READ coming from MC44S803 but tuner does not implement read at all? Is 
> it really needed?

Yes. Currently, MC44S803 uses a READ in mc44s80x_get_devid() to check the ID register.
According to the spec from freescale, a READ needs to be a seperate I2c transaction,
because the STOP bit is used to latch the address registers. That's the reason why a
dedicated READ support is needed (most other tuners use a WRITE / READ combined I2c
transaction instead).

> Maybe I can move MC44S803 and needed AF9015 changes to my devel tree at 
> linuxtv.org... But that does not change problem that tuner is not still 
> in v4l-dvb-master nor coming for Kernel before Manu will pull it.

Unfortunately, i didn't see any comments from Manu yet...

Thanks,
Jochen

Re: [linux-dvb] MC44S803 frontend (it works)

[Antti Palosaari]

Jochen Friedrich wrote:
> Hi Antti,
> 
>> Could you explain for changes af9015_i2c_xfer() done? Is it for case I2C 
>> READ coming from MC44S803 but tuner does not implement read at all? Is 
>> it really needed?
> 
> Yes. Currently, MC44S803 uses a READ in mc44s80x_get_devid() to check the ID register.
> According to the spec from freescale, a READ needs to be a seperate I2c transaction,
> because the STOP bit is used to latch the address registers. That's the reason why a
> dedicated READ support is needed (most other tuners use a WRITE / READ combined I2c
> transaction instead).

OK. Maybe comment to the code is required, but I can add it. I am 
willing to see, if you have, usb-sniffs for tuner read and write.

> 
>> Maybe I can move MC44S803 and needed AF9015 changes to my devel tree at 
>> linuxtv.org... But that does not change problem that tuner is not still 
>> in v4l-dvb-master nor coming for Kernel before Manu will pull it.
> 
> Unfortunately, i didn't see any comments from Manu yet...

we will waiting...

> 
> Thanks,
> Jochen

regards
Antti
-- 
http://palosaari.fi/

Re: [linux-dvb] MC44S803 frontend (it works)

[Jochen Friedrich]

Hi Antti,

>> Yes. Currently, MC44S803 uses a READ in mc44s80x_get_devid() to check the ID register.
>> According to the spec from freescale, a READ needs to be a seperate I2c transaction,
>> because the STOP bit is used to latch the address registers. That's the reason why a
>> dedicated READ support is needed (most other tuners use a WRITE / READ combined I2c
>> transaction instead).
> 
> OK. Maybe comment to the code is required, but I can add it. I am 
> willing to see, if you have, usb-sniffs for tuner read and write.

there is documentation for this tuner at the freescale web page:

http://www.freescale.com/files/rf_if/doc/data_sheet/MC44S803.pdf?pspll=1

>From page 8:

I2C OPERATION
The same 24-bit shift register is used to shift data in and
out of the part. The input data stream is clocked in on the
rising edge of SCLK into the shift register with the MSB first.
The IC Address and R/W bit are sent first. This allows the IC
to determine if it is the device that is being communicated
with. After that, 24 bits are clocked in to control the IC. If less
than 24 bits are required, then 16 or 8 bits could be used. In
other words, commands can be sent in 1, 2, or 3 byte
increments depending on the requirements for the particular
control register you are writing to. Data can be read back from
the IC in 1, 2, or 3 byte increments also. The Master controls
the clock line, whether writing to the part or reading from it.
After each byte that is sent, the device that receives it sends
an acknowledge bit. The output data stream is clocked out of
the shift register on the falling edge of SCLK and valid on the
rising edge, with the MSB first. The data stored in the shift
register is loaded into one of the appropriate registers after
the Stop Condition is sent. The 4 LSBs are the Control
Register Address Bits.

This means a READ needs to be implemented using 2 transactions.
One transaction to write the address and one to read the value back.

The read operations are specified on pages 22 and 23:

There are 16 Data Registers that can be read back from
the IC. The 1011 Control Register (Data Register Address)
controls which of these Data Registers will be read out of the
IC during the next read operation. To select the desired Data
Register this address register first needs to be set. Then on
the next read operation the desired data will be available.

Currently the driver only reads the ID bits to verify it's talking to a 
MC44S80x chip.

The READ operation was modeled after the "official" driver from TerraTec:

ftp://ftp.terratec.net/Receiver/Cinergy_T_USB_XE/Update/Cinergy_T_USB_XE_MKII_Drv_Linux.zip

>>> Maybe I can move MC44S803 and needed AF9015 changes to my devel tree at 
>>> linuxtv.org... But that does not change problem that tuner is not still 
>>> in v4l-dvb-master nor coming for Kernel before Manu will pull it.
>> Unfortunately, i didn't see any comments from Manu yet...
> 
> we will waiting...

OK, we'll do.

Thanks,
Jochen

Re: MC44S803 frontend (it works)

[Detlef Rohde]

Hi again,
I wonder if there is any progress including/merging the frontend-driver 
MC44S803 i.o. to get my Cinergy T USB XE running under Linux? Currently 
I can use it on a WXP-VM, but I guess it's not the best solution making 
this detour..
Regards
Detlef

Detlef Rohde schrieb:
> Hi Roberto,
> tnx for doing your test! As a Linux-newbie I better wait now until I 
> can use a merged driver since I had bad experiences with former trys 
> i.e. OS-crashes. Hopefully one Jochen or somebody else can soon do the 
> rest. Meanwhile I am experimenting with a WXP-Pro VM running on  my 
> Ubuntu Intrepid Installation. Will try the native Terratec-SW on this 
> machine.
> Best regards,
> Detlef
>
> Roberto Ragusa schrieb:
>> (to both linux-dvb and linux-media)
>>
>> Jochen Friedrich wrote:
>>  
>>> Hi Roberto,
>>>
>>>    
>>>> Is there any plan to include this frontend in mainline kernels?
>>>> I used to run this driver months ago and it was working well.
>>>>       
>>> The reason is the huge memory footprint due to the included 
>>> frequency table.
>>> I worked a bit on the driver to get rid of this table. Could you try 
>>> this version:
>>>
>>> 1. Patch for AF9015:
>>>
>>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690 
>>>
>>>
>>> 2. MC44S80x tuner driver:
>>>
>>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20 
>>>
>>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20 
>>>
>>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20 
>>>
>>>     
>>
>> Finally managed to try your version. It works, with no apparent issue.
>>
>> Scanning is OK, tuning is OK.
>> I can't test signals below 600MHz at the moment, but I will try 
>> (possibly VHF too)
>> in a couple of days, just to be sure about the frequency handling code.
>> Also tried removing the USB stick while playing a stream; the devices
>> were correctly removed when the user space apps closed them.
>>
>> In my (user) opinion this driver is ready to be merged.
>>
>> I actually fixed some trivial compilation issues in the driver.
>>
>> --- a/linux/drivers/media/common/tuners/mc44s80x.c    2009-01-05 
>> 12:38:11.000000000 +0100
>> +++ b/linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 
>> 16:12:59.000000000 +0100
>> @@ -470,12 +470,12 @@
>>
>>         mc44s80x_set_power(state, 0); /* disable powerdown */
>>         printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
>> -       err = i2c_transfer(state->i2c, &msg, 1);
>> +       err = i2c_transfer(state->i2c, msg1, 1);
>>         if (err != 1) {
>>                 printk(KERN_WARNING "mc44s80x: Write error\n");
>>                 goto exit;
>>         }
>> -       err = i2c_transfer(state->i2c, &msg, 1);
>> +       err = i2c_transfer(state->i2c, msg2, 1);
>>         if (err != 1) {
>>                 printk(KERN_WARNING "mc44s80x: Read error, 
>> Reg=[0x%02x]\n",
>>                        TUNER_ADDR + 1);
>> @@ -495,7 +495,7 @@
>>         return 0;
>>  unk:
>>         printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
>> -              "(0x%02x)\n", __func__, id);
>> +              "(0x%02x)\n", id);
>>         goto out;
>>  exit:
>>         if (fe->ops.i2c_gate_ctrl)
>> @@ -512,7 +512,7 @@
>>         int err = 0;
>>
>>         printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 
>> 0x%p\n", i2c);
>> -       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
>> +       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
>>         if (state == NULL) {
>>                 err = -ENOMEM;
>>                 goto exit;
>>
>>  
>>> Thanks,
>>> Jochen
>>>     
>>
>> Thanks to you.
>>
>>   
>
>

Re: [linux-dvb] MC44S803 frontend (it works, please merge)

[Roberto Ragusa]

Detlef Rohde wrote:
> Hi again,
> I wonder if there is any progress including/merging the frontend-driver 
> MC44S803 i.o. to get my Cinergy T USB XE running under Linux? Currently 
> I can use it on a WXP-VM, but I guess it's not the best solution making 
> this detour..

I'm even more impatient than you.

Why is it so difficult to merge a little and isolated piece of code which
has been reported as both working and useful?

I don't know how many trees this code has to be propagated through,
but I'm afraid it will be a long time before I see support for this
hardware in a stock Fedora kernel. Maybe the hardware could be
considered obsolete by then.

Isn't one of the expected advantages of the free software +
public mailing lists + user testing + git repositories
model to have a fast pace of development?

Waiting and hoping.
-- 
   Roberto Ragusa    mail at robertoragusa.it

Re: MC44S803 frontend (it works)

[Jochen Friedrich]

Hi Detlef,

> I wonder if there is any progress including/merging the frontend-driver 
> MC44S803 i.o. to get my Cinergy T USB XE running under Linux? Currently 
> I can use it on a WXP-VM, but I guess it's not the best solution making 
> this detour..

Work is going on to merge this driver. However, it takes some time and review
cycles to make sure the driver meets the quality and code style as defined
in Documentation/development-process/2.Process.

Of course you could also download my kernel snapshot from
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=8d0441385cc9cf327d069b7185d2a647d4c77150
and test the preliminary driver ;-)

Thanks,
Jochen

Re: MC44S803 frontend (it works)

[Jochen Friedrich]

Hi Detlef,

> Of course you could also download my kernel snapshot from
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=8d0441385cc9cf327d069b7185d2a647d4c77150
> and test the preliminary driver ;-)

Better use
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=3efdc3ee161cfb9268ee95cfd6d14a9f6bc8ae51

Sorry, the old version contained a type preventing the driver to compile.

Thanks,
Jochen

Re: MC44S803 frontend (it works)

[Detlef Rohde]

Hi Jochen,
thanks for your work. It's a bit stupid to put so much effort in getting 
a 20 €-device running. Easier way is buying another one which is better 
supported. On the other hand I learned much abt Linux. Will try your 
snapshot within the next few days and report on it.
Regards,
Detlef

Jochen Friedrich schrieb:
> Hi Detlef,
>
>   
>> Of course you could also download my kernel snapshot from
>> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=8d0441385cc9cf327d069b7185d2a647d4c77150
>> and test the preliminary driver ;-)
>>     
>
> Better use
> http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=3efdc3ee161cfb9268ee95cfd6d14a9f6bc8ae51
>
> Sorry, the old version contained a type preventing the driver to compile.
>
> Thanks,
> Jochen
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   

Re: MC44S803 frontend (it works)

[Antti Palosaari]

Hello
I just pushed Jochen's MC44S803 driver to linuxtv.org devel tree. I did 
some changes to patch that adds this tuner to AF9015, because patch 
didn't applied and also some other changes. Hopefully it doesn't break 
functionality. Please test.

http://linuxtv.org/hg/~anttip/mc44s803/

regards
Antti
-- 
http://palosaari.fi/

Re: MC44S803 frontend (it works)

[Detlef Rohde]

Hi Antti,
thanks for your work. I unpacked mc44s803-b7ac1c462be3 and tried to run 
"make install" as root since I wanted to update my kernel modules. This 
did not work. On the other hand running only "make" finished with some 
warnings but no errors. My kernel is  2.6.27-11-generic from Ubuntu 
8.10. The system is up to date. These tries I performed on a newly 
installed Linux where I never tried running my DVB-T stick (TerraTec 
Electronic GmbH Cinergy T XE DVB-T Receiver, MKII) under Linux before. 
Have installed VMware on this machine and can use the stick without 
problems in a WXP-Pro VM. Can you please give an advice what I should do 
next? I wo'nt destroy my running system.
Best regards,
Detlef

Antti Palosaari schrieb:
> Hello
> I just pushed Jochen's MC44S803 driver to linuxtv.org devel tree. I 
> did some changes to patch that adds this tuner to AF9015, because 
> patch didn't applied and also some other changes. Hopefully it doesn't 
> break functionality. Please test.
>
> http://linuxtv.org/hg/~anttip/mc44s803/
>
> regards
> Antti

Re: MC44S803 frontend (it works)

[Antti Palosaari]

Detlef Rohde wrote:
> Hi Antti,
> thanks for your work. I unpacked mc44s803-b7ac1c462be3 and tried to run 
> "make install" as root since I wanted to update my kernel modules. This 
> did not work. On the other hand running only "make" finished with some 
> warnings but no errors. My kernel is  2.6.27-11-generic from Ubuntu 
> 8.10. The system is up to date. These tries I performed on a newly 
> installed Linux where I never tried running my DVB-T stick (TerraTec 
> Electronic GmbH Cinergy T XE DVB-T Receiver, MKII) under Linux before. 
> Have installed VMware on this machine and can use the stick without 
> problems in a WXP-Pro VM. Can you please give an advice what I should do 
> next? I wo'nt destroy my running system.
> Best regards,
> Detlef

Tahnks,
I did some more changes, could you test again:
http://linuxtv.org/hg/~anttip/mc44s803/

Antti
-- 
http://palosaari.fi/

Re: MC44S803 frontend (it works)

[Jochen Friedrich]

Hi Antti,

> I did some more changes, could you test again:

This version works OK for me :-). The old version also worked, but was very insensitive (i only received one
transponder instead of 6, i guess this GPIO must switch on some RF-amplifyer or so).

Thanks,
Jochen

Re: MC44S803 frontend (it works)

[Roberto Ragusa]

Antti Palosaari wrote:

> Tahnks,
> I did some more changes, could you test again:
> http://linuxtv.org/hg/~anttip/mc44s803/

Tested here.
Works perfectly.

-- 
   Roberto Ragusa    mail at robertoragusa.it

Re: MC44S803 frontend (it works)

[Antti Palosaari]

Hi Jochen,

Jochen Friedrich wrote:
> This version works OK for me :-). The old version also worked, but was very insensitive (i only received one
> transponder instead of 6, i guess this GPIO must switch on some RF-amplifyer or so).

Yes, you are correct. I also ensured that from TerraTec provided driver.

I moved af9015_i2c_xfer() things back as I now think those are enough 
general. If driver now works, and you are also happy for af9015 changes 
I did, af9015 changes are fine for me too.
Could you look and make fast test all are ok?

PS.
If you want remote working then send AF15IRTBL.bin (or USB-sniff) to me. 
 From file I can look correct IR-codes for your remote control and after 
those are set it is rather easy to add key bindings for button events. 
This same apply all AF9015 devices, I am happy to add remotes too.

regards
Antti
-- 
http://palosaari.fi/