From: Antti Palosaari <crope@iki.fi>
To: Jochen Friedrich <jochen@scram.de>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCHv4] Add Freescale MC44S803 tuner driver
Date: Sat, 17 Jan 2009 20:45:44 +0200 [thread overview]
Message-ID: <49722758.8030801@iki.fi> (raw)
In-Reply-To: <496F9A1C.7040602@scram.de>
Hello Jochen,
I just reviewed this patch and here is my comments;
Jochen Friedrich wrote:
> + buf[0] = (val & 0xFF0000) >> 16;
I am not sure where it comes I have seen comments sometimes that we
should use lower case hex numbers.
> + return -EREMOTEIO;
[...]
> + u8 ret, id;
Error status (-EREMOTEIO) is stored to the u8, which leads ~254. This
seems not to be problem currently because mc44s803_readreg() is used
only in mc44s803_attach() that returns NULL in error case. Anyhow, I
think it would be better to use int for clarity.
regards,
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2009-01-17 18:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 20:18 [PATCHv4] Add Freescale MC44S803 tuner driver Jochen Friedrich
2009-01-17 18:45 ` Antti Palosaari [this message]
2009-01-17 23:09 ` Detlef Rohde
2009-01-17 23:33 ` Roberto Ragusa
2009-01-18 11:10 ` Detlef Rohde
2009-01-19 14:48 ` Jochen Friedrich
2009-01-19 14:52 ` Antti Palosaari
-- strict thread matches above, loose matches on Subject: below --
2009-01-19 18:33 Jochen Friedrich
2009-01-19 18:37 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49722758.8030801@iki.fi \
--to=crope@iki.fi \
--cc=jochen@scram.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox