* [PATCH] V4L/DVB: make card signed
@ 2009-01-18 14:55 Roel Kluin
2009-01-29 9:19 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-01-18 14:55 UTC (permalink / raw)
To: mchehab; +Cc: linux-media, video4linux-list
Is this correct?
--------------->8----------8<----------------
make card signed
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
index ef9bf00..7c7a96c 100644
--- a/drivers/media/video/em28xx/em28xx-cards.c
+++ b/drivers/media/video/em28xx/em28xx-cards.c
@@ -47,7 +47,7 @@ static unsigned int disable_ir;
module_param(disable_ir, int, 0444);
MODULE_PARM_DESC(disable_ir, "disable infrared remote support");
-static unsigned int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
+static int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
module_param_array(card, int, NULL, 0444);
MODULE_PARM_DESC(card, "card type");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] V4L/DVB: make card signed
2009-01-18 14:55 [PATCH] V4L/DVB: make card signed Roel Kluin
@ 2009-01-29 9:19 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2009-01-29 9:19 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-media, video4linux-list
On Sun, 18 Jan 2009 15:55:15 +0100
Roel Kluin <roel.kluin@gmail.com> wrote:
> Is this correct?
No, it isn't. There's no sense on a negative value for a card.
> --------------->8----------8<----------------
> make card signed
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
> index ef9bf00..7c7a96c 100644
> --- a/drivers/media/video/em28xx/em28xx-cards.c
> +++ b/drivers/media/video/em28xx/em28xx-cards.c
> @@ -47,7 +47,7 @@ static unsigned int disable_ir;
> module_param(disable_ir, int, 0444);
> MODULE_PARM_DESC(disable_ir, "disable infrared remote support");
>
> -static unsigned int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
> +static int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET };
> module_param_array(card, int, NULL, 0444);
> MODULE_PARM_DESC(card, "card type");
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-29 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-18 14:55 [PATCH] V4L/DVB: make card signed Roel Kluin
2009-01-29 9:19 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox