[REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Aguirre Rodriguez, Sergio Alberto]

Hi,

I'm sending the following patchset for review to the relevant lists (linux-omap, v4l, linux-media).

Includes:
 - Omap3 camera core + ISP drivers.
 - MT9P012 sensor driver (adapted to 3430SDP)
 - DW9710 lens driver (adapted to work with MT9P012 for SDP)
 - Necessary v4l2-int-device changes to make above drivers work
 - Redefine OMAP3 ISP platform device.
 - Review comments fixed from: (Thanks a lot for their time and help)
   - Hans Verkuil
   - Tony Lindgreen
   - Felipe Balbi
   - Vaibhav Hiremath
   - David Brownell

Some notes:
 - Uses v4l2-int-device solution.
 - Tested with 3430SDP ES3.0 VG5.0.1 with Camkit v3.0.1
 - Applies cleanly on top of commit 0ec95b96fd77036a13398c66901e11cd301190d0 by Jouni Hogander (OMAP3: PM: Emu_pwrdm is switched off by hardware even when sdti is in use)
 - ISP wrappers dropped from the patchset, as a rework is going on currently.


I appreciate in advance your time.

Regards,
Sergio

Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[stanley.miao]

Hi,Sergio,

I saw you had a ov3640 patch in omapzoom tree. Why don't you submit it
together ?

Stanley.

On Mon, 2009-01-12 at 20:03 -0600, Aguirre Rodriguez, Sergio Alberto
wrote:
> Hi,
> 
> I'm sending the following patchset for review to the relevant lists (linux-omap, v4l, linux-media).
> 
> Includes:
>  - Omap3 camera core + ISP drivers.
>  - MT9P012 sensor driver (adapted to 3430SDP)
>  - DW9710 lens driver (adapted to work with MT9P012 for SDP)
>  - Necessary v4l2-int-device changes to make above drivers work
>  - Redefine OMAP3 ISP platform device.
>  - Review comments fixed from: (Thanks a lot for their time and help)
>    - Hans Verkuil
>    - Tony Lindgreen
>    - Felipe Balbi
>    - Vaibhav Hiremath
>    - David Brownell
> 
> Some notes:
>  - Uses v4l2-int-device solution.
>  - Tested with 3430SDP ES3.0 VG5.0.1 with Camkit v3.0.1
>  - Applies cleanly on top of commit 0ec95b96fd77036a13398c66901e11cd301190d0 by Jouni Hogander (OMAP3: PM: Emu_pwrdm is switched off by hardware even when sdti is in use)
>  - ISP wrappers dropped from the patchset, as a rework is going on currently.
> 
> 
> I appreciate in advance your time.
> 
> Regards,
> Sergio
> 
> --
> video4linux-list mailing list
> Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list

RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Aguirre Rodriguez, Sergio Alberto]

Hi Stanley,

I'm currently have that patch on hold, along with the ISP wrapper because I'm reworking them, and also I wanted first to be sure the OMAP3 camera core gets pushed (that's why I included only one sensor driver, to be able to test at least the camera core), and that way I feel it'll be more easier that the OV3640 sensor gets accepted after that.

Thanks for the interest.

Regards,
Sergio

> -----Original Message-----
> From: stanley.miao [mailto:stanley.miao@windriver.com]
> Sent: Monday, January 12, 2009 8:31 PM
> To: Aguirre Rodriguez, Sergio Alberto
> Cc: linux-omap@vger.kernel.org; video4linux-list@redhat.com; Nagalla,
> Hari; Sakari Ailus; Tuukka.O Toivonen; linux-media@vger.kernel.org
> Subject: Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor
> driver v2
> 
> Hi,Sergio,
> 
> I saw you had a ov3640 patch in omapzoom tree. Why don't you submit it
> together ?
> 
> Stanley.
> 
> On Mon, 2009-01-12 at 20:03 -0600, Aguirre Rodriguez, Sergio Alberto
> wrote:
> > Hi,
> >
> > I'm sending the following patchset for review to the relevant lists
> (linux-omap, v4l, linux-media).
> >
> > Includes:
> >  - Omap3 camera core + ISP drivers.
> >  - MT9P012 sensor driver (adapted to 3430SDP)
> >  - DW9710 lens driver (adapted to work with MT9P012 for SDP)
> >  - Necessary v4l2-int-device changes to make above drivers work
> >  - Redefine OMAP3 ISP platform device.
> >  - Review comments fixed from: (Thanks a lot for their time and help)
> >    - Hans Verkuil
> >    - Tony Lindgreen
> >    - Felipe Balbi
> >    - Vaibhav Hiremath
> >    - David Brownell
> >
> > Some notes:
> >  - Uses v4l2-int-device solution.
> >  - Tested with 3430SDP ES3.0 VG5.0.1 with Camkit v3.0.1
> >  - Applies cleanly on top of commit
> 0ec95b96fd77036a13398c66901e11cd301190d0 by Jouni Hogander (OMAP3: PM:
> Emu_pwrdm is switched off by hardware even when sdti is in use)
> >  - ISP wrappers dropped from the patchset, as a rework is going on
> currently.
> >
> >
> > I appreciate in advance your time.
> >
> > Regards,
> > Sergio
> >
> > --
> > video4linux-list mailing list
> > Unsubscribe mailto:video4linux-list-
> request@redhat.com?subject=unsubscribe
> > https://www.redhat.com/mailman/listinfo/video4linux-list

Patch series in Tarball submitted (RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2)

[Aguirre Rodriguez, Sergio Alberto]

Hi all,

Just in case you're having troubles getting the patches, heres a tarball with all of them:

https://omapzoom.org/gf/download/docmanfileversion/51/959/l-o_cam_patches_2009_01_12.tar.bz2

I appreciate your time,
Sergio

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Aguirre Rodriguez, Sergio Alberto
> Sent: Monday, January 12, 2009 8:03 PM
> To: linux-omap@vger.kernel.org
> Cc: linux-media@vger.kernel.org; video4linux-list@redhat.com; Sakari
> Ailus; Tuukka.O Toivonen; Nagalla, Hari
> Subject: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver
> v2
> 
> Hi,
> 
> I'm sending the following patchset for review to the relevant lists
> (linux-omap, v4l, linux-media).
> 
> Includes:
>  - Omap3 camera core + ISP drivers.
>  - MT9P012 sensor driver (adapted to 3430SDP)
>  - DW9710 lens driver (adapted to work with MT9P012 for SDP)
>  - Necessary v4l2-int-device changes to make above drivers work
>  - Redefine OMAP3 ISP platform device.
>  - Review comments fixed from: (Thanks a lot for their time and help)
>    - Hans Verkuil
>    - Tony Lindgreen
>    - Felipe Balbi
>    - Vaibhav Hiremath
>    - David Brownell
> 
> Some notes:
>  - Uses v4l2-int-device solution.
>  - Tested with 3430SDP ES3.0 VG5.0.1 with Camkit v3.0.1
>  - Applies cleanly on top of commit
> 0ec95b96fd77036a13398c66901e11cd301190d0 by Jouni Hogander (OMAP3: PM:
> Emu_pwrdm is switched off by hardware even when sdti is in use)
>  - ISP wrappers dropped from the patchset, as a rework is going on
> currently.
> 
> 
> I appreciate in advance your time.
> 
> Regards,
> Sergio
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Patch series in Tarball submitted (RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2)

[Hiremath, Vaibhav]

Thanks,
Vaibhav Hiremath
Platform Support Products
Texas Instruments Inc
Ph: +91-80-25099927
> -----Original Message-----
> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> owner@vger.kernel.org] On Behalf Of Aguirre Rodriguez, Sergio
> Alberto
> Sent: Wednesday, January 14, 2009 1:49 AM
> To: linux-omap@vger.kernel.org
> Cc: linux-media@vger.kernel.org; video4linux-list@redhat.com; Sakari
> Ailus; Tuukka.O Toivonen; Nagalla, Hari
> Subject: Patch series in Tarball submitted (RE: [REVIEW PATCH 00/14]
> OMAP3 camera + ISP + MT9P012 sensor driver v2)
> 
> Hi all,
> 
> Just in case you're having troubles getting the patches, heres a
> tarball with all of them:
> 
> https://omapzoom.org/gf/download/docmanfileversion/51/959/l-
> o_cam_patches_2009_01_12.tar.bz2
> 
[Hiremath, Vaibhav] I tried to build camera driver as module and got following error - 

ERROR: "ispmmu_get_mapeable_space" [drivers/media/video/omap34xxcam.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

You have missed to export this symbol, please correct in next version of patches.

> I appreciate your time,
> Sergio
> 
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Aguirre Rodriguez, Sergio
> Alberto
> > Sent: Monday, January 12, 2009 8:03 PM
> > To: linux-omap@vger.kernel.org
> > Cc: linux-media@vger.kernel.org; video4linux-list@redhat.com;
> Sakari
> > Ailus; Tuukka.O Toivonen; Nagalla, Hari
> > Subject: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor
> driver
> > v2
> >
> > Hi,
> >
> > I'm sending the following patchset for review to the relevant
> lists
> > (linux-omap, v4l, linux-media).
> >
> > Includes:
> >  - Omap3 camera core + ISP drivers.
> >  - MT9P012 sensor driver (adapted to 3430SDP)
> >  - DW9710 lens driver (adapted to work with MT9P012 for SDP)
> >  - Necessary v4l2-int-device changes to make above drivers work
> >  - Redefine OMAP3 ISP platform device.
> >  - Review comments fixed from: (Thanks a lot for their time and
> help)
> >    - Hans Verkuil
> >    - Tony Lindgreen
> >    - Felipe Balbi
> >    - Vaibhav Hiremath
> >    - David Brownell
> >
> > Some notes:
> >  - Uses v4l2-int-device solution.
> >  - Tested with 3430SDP ES3.0 VG5.0.1 with Camkit v3.0.1
> >  - Applies cleanly on top of commit
> > 0ec95b96fd77036a13398c66901e11cd301190d0 by Jouni Hogander (OMAP3:
> PM:
> > Emu_pwrdm is switched off by hardware even when sdti is in use)
> >  - ISP wrappers dropped from the patchset, as a rework is going on
> > currently.
> >
> >
> > I appreciate in advance your time.
> >
> > Regards,
> > Sergio
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-
> omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Patch series in Tarball submitted (RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2)

[Aguirre Rodriguez, Sergio Alberto]

> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Wednesday, January 14, 2009 8:51 AM

<snip>

> [Hiremath, Vaibhav] I tried to build camera driver as module and got
> following error -
> 
> ERROR: "ispmmu_get_mapeable_space" [drivers/media/video/omap34xxcam.ko]
> undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> You have missed to export this symbol, please correct in next version of
> patches.
> 

Oops, good catch. Thanks, I'll correct that. No problem.

Regards,
Sergio

Re: Patch series in Tarball submitted (RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2)

[Mauro Carvalho Chehab]

On Wed, 14 Jan 2009 08:55:08 -0600
"Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com> wrote:

> 
> 
> > -----Original Message-----
> > From: Hiremath, Vaibhav
> > Sent: Wednesday, January 14, 2009 8:51 AM
> 
> <snip>
> 
> > [Hiremath, Vaibhav] I tried to build camera driver as module and got
> > following error -
> > 
> > ERROR: "ispmmu_get_mapeable_space" [drivers/media/video/omap34xxcam.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> > 
> > You have missed to export this symbol, please correct in next version of
> > patches.
> > 
> 
> Oops, good catch. Thanks, I'll correct that. No problem.

Better to wait a little bit before posting the new version... I'm still
analyzing the current posting. 

It would be useful if you could document the private ioctls you've added, to
help me to better analyse the remaining patches.


Cheers,
Mauro

Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Sakari Ailus]

Aguirre Rodriguez, Sergio Alberto wrote:
> Hi,
> 
> I'm sending the following patchset for review to the relevant lists (linux-omap, v4l, linux-media).
> 
> Includes:
>  - Omap3 camera core + ISP drivers.
>  - MT9P012 sensor driver (adapted to 3430SDP)
>  - DW9710 lens driver (adapted to work with MT9P012 for SDP)
>  - Necessary v4l2-int-device changes to make above drivers work
>  - Redefine OMAP3 ISP platform device.
>  - Review comments fixed from: (Thanks a lot for their time and help)
>    - Hans Verkuil
>    - Tony Lindgreen
>    - Felipe Balbi
>    - Vaibhav Hiremath
>    - David Brownell

Hi Sergio,

We should try to figure out how we could synchronise our version of the 
ISP and camera ASAP before making any more changes... I wouldn't want to 
start posting a competing version. ;-)

-- 
Sakari Ailus
sakari.ailus@nokia.com

RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Hiremath, Vaibhav]

Thanks,
Vaibhav Hiremath

> -----Original Message-----
> From: video4linux-list-bounces@redhat.com [mailto:video4linux-list-
> bounces@redhat.com] On Behalf Of Sakari Ailus
> Sent: Monday, January 19, 2009 3:50 PM
> To: Aguirre Rodriguez, Sergio Alberto
> Cc: Nagalla, Hari; video4linux-list@redhat.com; linux-
> omap@vger.kernel.org; Tuukka.O Toivonen; linux-media@vger.kernel.org
> Subject: Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012
> sensor driver v2
> 
> Aguirre Rodriguez, Sergio Alberto wrote:
> > Hi,
> >
> > I'm sending the following patchset for review to the relevant
> lists (linux-omap, v4l, linux-media).
> >
> > Includes:
> >  - Omap3 camera core + ISP drivers.
> >  - MT9P012 sensor driver (adapted to 3430SDP)
> >  - DW9710 lens driver (adapted to work with MT9P012 for SDP)
> >  - Necessary v4l2-int-device changes to make above drivers work
> >  - Redefine OMAP3 ISP platform device.
> >  - Review comments fixed from: (Thanks a lot for their time and
> help)
> >    - Hans Verkuil
> >    - Tony Lindgreen
> >    - Felipe Balbi
> >    - Vaibhav Hiremath
> >    - David Brownell
> 
> Hi Sergio,
> 
> We should try to figure out how we could synchronise our version of
> the
> ISP and camera ASAP before making any more changes... I wouldn't
> want to
> start posting a competing version. ;-)
> 
[Hiremath, Vaibhav] Sakari,
Can you share your version of code (either in form of patches or source) here onto the mailing list, so that everybody those who are interested will be aware of changes?

Atleast for me I would get prior view of changes which might affect BT656 support (posted on top of Sergio's patch).

Again one more thing I would like to bring to your notice is about sub-device framework. Also we need to plan for the migration from V4L2-int to sub-device framework, which is of equal important. I feel the more time we spend in merging and aligning offline, more we are carrying risk.

According to me as I mentioned before, the plan should be to push ISP-Camera with V4L2-int interface as early as possible with whatever minimal sensor/decoder support we have today, which will make sure that our underneath ISP-library is in place. Once that is placed in, we can have additional patches on top of it to add more features. 

In this way, we can plan for migration to sub-device framework and also be easier and simpler. Even if any customers are interested, they can pick it up the ISP library and start development on top of it.


> --
> Sakari Ailus
> sakari.ailus@nokia.com
> 
> --
> video4linux-list mailing list
> Unsubscribe mailto:video4linux-list-
> request@redhat.com?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list

Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Sakari Ailus]

Hiremath, Vaibhav wrote:
> [Hiremath, Vaibhav] Sakari, Can you share your version of code
> (either in form of patches or source) here onto the mailing list, so
> that everybody those who are interested will be aware of changes?

I will synchronise soon with Sergio (as he noted). After that we'll send 
a new patchset. I was thinking of separating the ISP and camera driver 
patches from other hardware dependent patches. The resulting patchset 
wouldn't be that huge anymore but on the other hand it wouldn't be very 
usable as such.

> Atleast for me I would get prior view of changes which might affect
> BT656 support (posted on top of Sergio's patch).
> 
> Again one more thing I would like to bring to your notice is about
> sub-device framework. Also we need to plan for the migration from
> V4L2-int to sub-device framework, which is of equal important. I feel
> the more time we spend in merging and aligning offline, more we are
> carrying risk.

I agree that we should be moving to v4l2 sub-device at some point, 
preferrably sooner than later, but I think the ISP driver should get a 
much much better interface than it currently has. So that should be part 
of the task.

> According to me as I mentioned before, the plan should be to push
> ISP-Camera with V4L2-int interface as early as possible with whatever
> minimal sensor/decoder support we have today, which will make sure
> that our underneath ISP-library is in place. Once that is placed in,
> we can have additional patches on top of it to add more features.

I agree. But I'd say that fixing the bugs and cleaning up the code is as 
least as important than adding new features.

> In this way, we can plan for migration to sub-device framework and
> also be easier and simpler. Even if any customers are interested,
> they can pick it up the ISP library and start development on top of
> it.

There's still a long way to get there --- the ISP driver's current 
interface and internals don't mix well with either v4l2 sub-device or 
v4l2-int-if. For example, there's no ISP object, just function calls and 
then output frame size / frame interval enumeration doesn't work 
properly for YUV (maybe not even for RAW10). Enumerating frame size has 
side effects. The ISP driver doesn't have a standard interface, it's now 
specific to OMAP 3. And this is just an example...

Regards,

-- 
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com

Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Hans Verkuil]

On Friday 06 February 2009 16:03:26 Sakari Ailus wrote:
> Hiremath, Vaibhav wrote:
> > [Hiremath, Vaibhav] Sakari, Can you share your version of code
> > (either in form of patches or source) here onto the mailing list, so
> > that everybody those who are interested will be aware of changes?
>
> I will synchronise soon with Sergio (as he noted). After that we'll send
> a new patchset. I was thinking of separating the ISP and camera driver
> patches from other hardware dependent patches. The resulting patchset
> wouldn't be that huge anymore but on the other hand it wouldn't be very
> usable as such.
>
> > Atleast for me I would get prior view of changes which might affect
> > BT656 support (posted on top of Sergio's patch).
> >
> > Again one more thing I would like to bring to your notice is about
> > sub-device framework. Also we need to plan for the migration from
> > V4L2-int to sub-device framework, which is of equal important. I feel
> > the more time we spend in merging and aligning offline, more we are
> > carrying risk.
>
> I agree that we should be moving to v4l2 sub-device at some point,
> preferrably sooner than later, but I think the ISP driver should get a
> much much better interface than it currently has. So that should be part
> of the task.
>
> > According to me as I mentioned before, the plan should be to push
> > ISP-Camera with V4L2-int interface as early as possible with whatever
> > minimal sensor/decoder support we have today, which will make sure
> > that our underneath ISP-library is in place. Once that is placed in,
> > we can have additional patches on top of it to add more features.
>
> I agree. But I'd say that fixing the bugs and cleaning up the code is as
> least as important than adding new features.
>
> > In this way, we can plan for migration to sub-device framework and
> > also be easier and simpler. Even if any customers are interested,
> > they can pick it up the ISP library and start development on top of
> > it.
>
> There's still a long way to get there --- the ISP driver's current
> interface and internals don't mix well with either v4l2 sub-device or
> v4l2-int-if. For example, there's no ISP object, just function calls and
> then output frame size / frame interval enumeration doesn't work
> properly for YUV (maybe not even for RAW10). Enumerating frame size has
> side effects. The ISP driver doesn't have a standard interface, it's now
> specific to OMAP 3. And this is just an example...

Please note that it is easy to add a subdevice-specific set of ops if 
needed. It is not implemented at the moment, but if you need it please ask 
and I can show you how to do it.

In general, if you think something is missing in v4l2_subdev or if something 
is awkward to use, please ask me! I'd be happy to help you with that. It's 
an internal API, so changes are possible and almost certainly necessary for 
omap anyway.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG

RE: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012 sensor driver v2

[Hiremath, Vaibhav]

Thanks,
Vaibhav Hiremath

> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@maxwell.research.nokia.com]
> Sent: Friday, February 06, 2009 8:33 PM
> To: Hiremath, Vaibhav
> Cc: Ailus Sakari (Nokia-D/Helsinki); Aguirre Rodriguez, Sergio
> Alberto; Nagalla, Hari; video4linux-list@redhat.com; linux-
> omap@vger.kernel.org; Toivonen Tuukka.O (Nokia-D/Oulu); linux-
> media@vger.kernel.org
> Subject: Re: [REVIEW PATCH 00/14] OMAP3 camera + ISP + MT9P012
> sensor driver v2
> 
> Hiremath, Vaibhav wrote:
> > [Hiremath, Vaibhav] Sakari, Can you share your version of code
> > (either in form of patches or source) here onto the mailing list,
> so
> > that everybody those who are interested will be aware of changes?
> 
> I will synchronise soon with Sergio (as he noted). After that we'll
> send
> a new patchset. I was thinking of separating the ISP and camera
> driver
> patches from other hardware dependent patches. The resulting
> patchset
> wouldn't be that huge anymore but on the other hand it wouldn't be
> very
> usable as such.
> 
[Hiremath, Vaibhav] How much change can we expect as compared to the patches posted by Sergio on 14th Jan?

> > Atleast for me I would get prior view of changes which might
> affect
> > BT656 support (posted on top of Sergio's patch).
> >
> > Again one more thing I would like to bring to your notice is about
> > sub-device framework. Also we need to plan for the migration from
> > V4L2-int to sub-device framework, which is of equal important. I
> feel
> > the more time we spend in merging and aligning offline, more we
> are
> > carrying risk.
> 
> I agree that we should be moving to v4l2 sub-device at some point,
> preferrably sooner than later, but I think the ISP driver should get
> a
> much much better interface than it currently has. So that should be
> part
> of the task.
> 
> > According to me as I mentioned before, the plan should be to push
> > ISP-Camera with V4L2-int interface as early as possible with
> whatever
> > minimal sensor/decoder support we have today, which will make sure
> > that our underneath ISP-library is in place. Once that is placed
> in,
> > we can have additional patches on top of it to add more features.
> 
> I agree. But I'd say that fixing the bugs and cleaning up the code
> is as
> least as important than adding new features.
> 
[Hiremath, Vaibhav] It would be really great if you could share your plan of action for ISP-Camera driver that would really help to plan our milestone accordingly.

> > In this way, we can plan for migration to sub-device framework and
> > also be easier and simpler. Even if any customers are interested,
> > they can pick it up the ISP library and start development on top
> of
> > it.
> 
> There's still a long way to get there --- the ISP driver's current
> interface and internals don't mix well with either v4l2 sub-device
> or
> v4l2-int-if. For example, there's no ISP object, just function calls
> and
> then output frame size / frame interval enumeration doesn't work
> properly for YUV (maybe not even for RAW10). Enumerating frame size
> has
> side effects. The ISP driver doesn't have a standard interface, it's
> now
> specific to OMAP 3. And this is just an example...
> 
> Regards,
> 
> --
> Sakari Ailus
> sakari.ailus@maxwell.research.nokia.com