public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCHv4] Add Freescale MC44S803 tuner driver
Date: Mon, 19 Jan 2009 15:48:14 +0100	[thread overview]
Message-ID: <497492AE.5030509@scram.de> (raw)
In-Reply-To: <49722758.8030801@iki.fi>

Hi Antti,

>> +	buf[0] = (val & 0xFF0000) >> 16;
> 
> I am not sure where it comes I have seen comments sometimes that we 
> should use lower case hex numbers.

OK, will fix.

>> +		return -EREMOTEIO;
> [...]
>> +	u8 ret, id;
> 
> Error status (-EREMOTEIO) is stored to the u8, which leads ~254. This 
> seems not to be problem currently because mc44s803_readreg() is used 
> only in mc44s803_attach() that returns NULL in error case. Anyhow, I 
> think it would be better to use int for clarity.

This is definitely a BUG. I'll also fix this. Do you want me to post an
update to the tuner or an incremental patch against your repository?

Thanks,
Jochen

  parent reply	other threads:[~2009-01-19 14:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 20:18 [PATCHv4] Add Freescale MC44S803 tuner driver Jochen Friedrich
2009-01-17 18:45 ` Antti Palosaari
2009-01-17 23:09   ` Detlef Rohde
2009-01-17 23:33     ` Roberto Ragusa
2009-01-18 11:10       ` Detlef Rohde
2009-01-19 14:48   ` Jochen Friedrich [this message]
2009-01-19 14:52     ` Antti Palosaari
  -- strict thread matches above, loose matches on Subject: below --
2009-01-19 18:33 Jochen Friedrich
2009-01-19 18:37 ` Jochen Friedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497492AE.5030509@scram.de \
    --to=jochen@scram.de \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox