From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v9 7/8] media: vsp1: Adapt entities to configure into a body
Date: Thu, 17 May 2018 12:58:46 +0300 [thread overview]
Message-ID: <4978075.HTLm1iqz4m@avalon> (raw)
In-Reply-To: <17b49567300141edc849f55c39405d88aab3877e.1525354160.git-series.kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Thursday, 3 May 2018 16:35:46 EEST Kieran Bingham wrote:
> Currently the entities store their configurations into a display list.
> Adapt this such that the code can be configured into a body directly,
> allowing greater flexibility and control of the content.
>
> All users of vsp1_dl_list_write() are removed in this process, thus it
> too is removed.
>
> A helper, vsp1_dl_list_get_body0() is provided to access the internal body0
> from the display list.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> v9:
> - Pass the DL through configure_partition() calls
>
> v8:
> - Fixed comment style and indentation
> - Supported UIF
> - Supported new configure_partition() functionality
>
> v7:
> - Rebase
> - s/prepare/configure_stream/
> - s/configure/configure_frame/
> ---
> drivers/media/platform/vsp1/vsp1_brx.c | 22 ++++++------
> drivers/media/platform/vsp1/vsp1_clu.c | 23 ++++++-------
> drivers/media/platform/vsp1/vsp1_dl.c | 12 ++-----
> drivers/media/platform/vsp1/vsp1_dl.h | 2 +-
> drivers/media/platform/vsp1/vsp1_drm.c | 12 ++++---
> drivers/media/platform/vsp1/vsp1_entity.c | 22 ++++++------
> drivers/media/platform/vsp1/vsp1_entity.h | 18 ++++++----
> drivers/media/platform/vsp1/vsp1_hgo.c | 16 ++++-----
> drivers/media/platform/vsp1/vsp1_hgt.c | 18 +++++-----
> drivers/media/platform/vsp1/vsp1_hsit.c | 10 ++---
> drivers/media/platform/vsp1/vsp1_lif.c | 15 ++++----
> drivers/media/platform/vsp1/vsp1_lut.c | 23 ++++++-------
> drivers/media/platform/vsp1/vsp1_pipe.c | 4 +-
> drivers/media/platform/vsp1/vsp1_pipe.h | 3 +-
> drivers/media/platform/vsp1/vsp1_rpf.c | 44 ++++++++++++------------
> drivers/media/platform/vsp1/vsp1_sru.c | 14 ++++----
> drivers/media/platform/vsp1/vsp1_uds.c | 25 +++++++-------
> drivers/media/platform/vsp1/vsp1_uds.h | 2 +-
> drivers/media/platform/vsp1/vsp1_uif.c | 21 +++++------
> drivers/media/platform/vsp1/vsp1_video.c | 16 ++++++---
> drivers/media/platform/vsp1/vsp1_wpf.c | 42 ++++++++++++-----------
> 21 files changed, 194 insertions(+), 170 deletions(-)
[snip]
> diff --git a/drivers/media/platform/vsp1/vsp1_rpf.c
> b/drivers/media/platform/vsp1/vsp1_rpf.c index deb86cc235ef..8fae7c485642
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_rpf.c
> +++ b/drivers/media/platform/vsp1/vsp1_rpf.c
[snip]
> @@ -192,7 +195,6 @@ static void rpf_configure_partition(struct vsp1_entity
> *entity, const struct vsp1_format_info *fmtinfo = rpf->fmtinfo;
> const struct v4l2_pix_format_mplane *format = &rpf->format;
> struct v4l2_rect crop;
> -
No need to remove this blank line.
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
There's no need to resubmit, I'll fix when applying.
> /*
> * Source size and crop offsets.
> *
[snip]
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-05-17 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 13:35 [PATCH v9 0/8] vsp1: TLB optimisation and DL caching Kieran Bingham
2018-05-03 13:35 ` [PATCH v9 1/8] media: vsp1: Reword uses of 'fragment' as 'body' Kieran Bingham
2018-05-03 13:35 ` [PATCH v9 2/8] media: vsp1: Protect bodies against overflow Kieran Bingham
2018-05-03 13:35 ` [PATCH v9 3/8] media: vsp1: Provide a body pool Kieran Bingham
2018-05-16 23:59 ` Laurent Pinchart
2018-05-03 13:35 ` [PATCH v9 4/8] media: vsp1: Convert display lists to use new " Kieran Bingham
2018-05-17 0:05 ` Laurent Pinchart
2018-05-03 13:35 ` [PATCH v9 5/8] media: vsp1: Use reference counting for bodies Kieran Bingham
2018-05-03 13:35 ` [PATCH v9 6/8] media: vsp1: Refactor display list configure operations Kieran Bingham
2018-05-17 9:41 ` Laurent Pinchart
2018-05-17 13:02 ` Kieran Bingham
2018-05-03 13:35 ` [PATCH v9 7/8] media: vsp1: Adapt entities to configure into a body Kieran Bingham
2018-05-17 9:58 ` Laurent Pinchart [this message]
2018-05-03 13:35 ` [PATCH v9 8/8] media: vsp1: Move video configuration to a cached dlb Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4978075.HTLm1iqz4m@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox