Broken Tuning on Wintv Nova HD S2

Broken Tuning on Wintv Nova HD S2

[gimli]

Hi,

the following changesets breaks Tuning to Vertical Transponders :

http://mercurial.intuxication.org/hg/s2-liplianin/rev/1ca67881d96a
http://linuxtv.org/hg/v4l-dvb/rev/2cd7efb4cc19

For example :

DMAX;BetaDigital:12246:vC34M2O0S0:S19.2E:27500:511:512=deu:32:0:10101:1:1092:0


cu

Edgar ( gimli ) Hucek

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[n37]

I also can confirm this. Reverting to a previous revision restores
proper tuning to vertical transponders.

On Tue, Jan 27, 2009 at 10:39 PM, gimli <gimli@dark-green.com> wrote:
> Hi,
>
> the following changesets breaks Tuning to Vertical Transponders :
>
> http://mercurial.intuxication.org/hg/s2-liplianin/rev/1ca67881d96a
> http://linuxtv.org/hg/v4l-dvb/rev/2cd7efb4cc19
>
> For example :
>
> DMAX;BetaDigital:12246:vC34M2O0S0:S19.2E:27500:511:512=deu:32:0:10101:1:1092:0
>
>
> cu
>
> Edgar ( gimli ) Hucek
>
> _______________________________________________
> linux-dvb users mailing list
> For V4L/DVB development, please use instead linux-media@vger.kernel.org
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Mika Laitio]

> I also can confirm this. Reverting to a previous revision restores
> proper tuning to vertical transponders.

I can also confirm it with hvr-4000 and latest drivers v4l-dvb drivers 
from linuxtv org. Before I reverted this patch, I could not get lock 
with vdr for example to:

Sky News;BT:11597:vC56:S19.2E:22000:305+131:306=eng:579:0:28707:1:1026:0
Al 
Jazeera;CANALSATELLITE:11567:vC56:S19.2E:22000:55:56=ara:0:0:9021:1:1024:0

while this worked

Eurosport;SES 
Astra:12226:hC34:S19.2E:27500:101:103=deu:102:0:31200:1:1091:0

Once I reverted that patch, all channels showed up nicely.

Mika

>
> On Tue, Jan 27, 2009 at 10:39 PM, gimli <gimli@dark-green.com> wrote:
>> Hi,
>>
>> the following changesets breaks Tuning to Vertical Transponders :
>>
>> http://mercurial.intuxication.org/hg/s2-liplianin/rev/1ca67881d96a
>> http://linuxtv.org/hg/v4l-dvb/rev/2cd7efb4cc19
>>
>> For example :
>>
>> DMAX;BetaDigital:12246:vC34M2O0S0:S19.2E:27500:511:512=deu:32:0:10101:1:1092:0
>>
>>
>> cu
>>
>> Edgar ( gimli ) Hucek
>>
>> _______________________________________________
>> linux-dvb users mailing list
>> For V4L/DVB development, please use instead linux-media@vger.kernel.org
>> linux-dvb@linuxtv.org
>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Igor M. Liplianin]

[-- Attachment #1: Type: text/plain, Size: 842 bytes --]

В сообщении от 27 January 2009 22:39:51 gimli написал(а):
> Hi,
>
> the following changesets breaks Tuning to Vertical Transponders :
>
> http://mercurial.intuxication.org/hg/s2-liplianin/rev/1ca67881d96a
> http://linuxtv.org/hg/v4l-dvb/rev/2cd7efb4cc19
>
> For example :
>
> DMAX;BetaDigital:12246:vC34M2O0S0:S19.2E:27500:511:512=deu:32:0:10101:1:109
>2:0
>
>
> cu
>
> Edgar ( gimli ) Hucek
>
> _______________________________________________
> linux-dvb users mailing list
> For V4L/DVB development, please use instead linux-media@vger.kernel.org
> linux-dvb@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

More likely not polarization, but hi band may broken.
Anyway, please, try attached patch.

-- 
Igor M. Liplianin
Microsoft Windows Free Zone - Linux used for all Computing Tasks

[-- Attachment #2: 10391.patch --]
[-- Type: text/x-diff, Size: 1811 bytes --]

# HG changeset patch
# User Igor M. Liplianin <liplianin@me.by>
# Date 1233189531 -7200
# Node ID d09924ba6c75233d8212ef79076739d9400d79a8
# Parent  43dbc8ebb5a21c8991df5e5ead54b724c0dc18f4
HVR-4000 Test

diff -r 43dbc8ebb5a2 -r d09924ba6c75 linux/drivers/media/dvb/frontends/cx24116.c
--- a/linux/drivers/media/dvb/frontends/cx24116.c	Tue Jan 27 23:47:50 2009 -0200
+++ b/linux/drivers/media/dvb/frontends/cx24116.c	Thu Jan 29 02:38:51 2009 +0200
@@ -861,6 +861,7 @@
 static int cx24116_set_tone(struct dvb_frontend *fe,
 	fe_sec_tone_mode_t tone)
 {
+	struct cx24116_state *state = fe->demodulator_priv;
 	struct cx24116_cmd cmd;
 	int ret;
 
@@ -870,8 +871,12 @@
 		return -EINVAL;
 	}
 
-	/* Wait for LNB ready */
-	ret = cx24116_wait_for_lnb(fe);
+	if (state->config->use_lnb_dc != 1)
+		ret = cx24116_set_voltage(fe, SEC_VOLTAGE_13);
+	else
+		/* Wait for LNB ready */
+		ret = cx24116_wait_for_lnb(fe);
+
 	if (ret != 0)
 		return ret;
 
diff -r 43dbc8ebb5a2 -r d09924ba6c75 linux/drivers/media/dvb/frontends/cx24116.h
--- a/linux/drivers/media/dvb/frontends/cx24116.h	Tue Jan 27 23:47:50 2009 -0200
+++ b/linux/drivers/media/dvb/frontends/cx24116.h	Thu Jan 29 02:38:51 2009 +0200
@@ -35,6 +35,9 @@
 
 	/* Need to set MPEG parameters */
 	u8 mpg_clk_pos_pol:0x02;
+
+	/* Need to set LNB power control */
+	u8 use_lnb_dc;
 };
 
 #if defined(CONFIG_DVB_CX24116) || \
diff -r 43dbc8ebb5a2 -r d09924ba6c75 linux/drivers/media/video/cx23885/cx23885-dvb.c
--- a/linux/drivers/media/video/cx23885/cx23885-dvb.c	Tue Jan 27 23:47:50 2009 -0200
+++ b/linux/drivers/media/video/cx23885/cx23885-dvb.c	Thu Jan 29 02:38:51 2009 +0200
@@ -334,6 +334,7 @@
 
 static struct cx24116_config dvbworld_cx24116_config = {
 	.demod_address = 0x05,
+	.use_lnb_dc = 1,
 };
 
 static int dvb_register(struct cx23885_tsport *port)

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[gimli]

Hi,

your patch seems to work.

cu

Edgar (gimli) Hucek

Igor M. Liplianin schrieb:
> В сообщении от 27 January 2009 22:39:51 gimli написал(а):
>> Hi,
>>
>> the following changesets breaks Tuning to Vertical Transponders :
>>
>> http://mercurial.intuxication.org/hg/s2-liplianin/rev/1ca67881d96a
>> http://linuxtv.org/hg/v4l-dvb/rev/2cd7efb4cc19
>>
>> For example :
>>
>> DMAX;BetaDigital:12246:vC34M2O0S0:S19.2E:27500:511:512=deu:32:0:10101:1:109
>> 2:0
>>
>>
>> cu
>>
>> Edgar ( gimli ) Hucek
>>
>> _______________________________________________
>> linux-dvb users mailing list
>> For V4L/DVB development, please use instead linux-media@vger.kernel.org
>> linux-dvb@linuxtv.org
>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
> 
> More likely not polarization, but hi band may broken.
> Anyway, please, try attached patch.
> 
> 

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Igor M. Liplianin]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

В сообщении от 29 January 2009 20:07:32 gimli написал(а):
> Hi,
>
> your patch seems to work.
If it works, then I prepare more simple patch.


[-- Attachment #2: hvr4000.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

# HG changeset patch
# User Igor M. Liplianin <liplianin@me.by>
# Date 1233253267 -7200
# Node ID 3542d1c1e03add577ce85175327701c552d14856
# Parent  4086371cea7b7f8b461e1a77513274aa43583c8c
Bug fix: Restore HVR-4000 tuning.

From: Igor M. Liplianin <liplianin@me.by>

Some cards uses cx24116 LNB_DC pin for LNB power control,
some not uses, some uses it different way, like HVR-4000.

Signed-off-by: Igor M. Liplianin <liplianin@me.by>

diff -r 4086371cea7b -r 3542d1c1e03a linux/drivers/media/dvb/frontends/cx24116.c
--- a/linux/drivers/media/dvb/frontends/cx24116.c	Sat Jan 17 17:23:31 2009 +0200
+++ b/linux/drivers/media/dvb/frontends/cx24116.c	Thu Jan 29 20:21:07 2009 +0200
@@ -1184,7 +1184,12 @@
 	if (ret != 0)
 		return ret;
 
-	return cx24116_diseqc_init(fe);
+	ret = cx24116_diseqc_init(fe);
+	if (ret != 0)
+		return ret;
+
+	/* HVR-4000 needs this */
+	return cx24116_set_voltage(fe, SEC_VOLTAGE_13);
 }
 
 /*

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[gimli]

Igor M. Liplianin schrieb:
> В сообщении от 29 January 2009 20:07:32 gimli написал(а):
>> Hi,
>>
>> your patch seems to work.
> If it works, then I prepare more simple patch.
> 
> 

Hi,

you can also put my :

Signed-off-by: Edgar Hucek <gimli@dark-green.com>

to the list.

cu

Edgar (gimli) Hucek

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Igor M. Liplianin]

On 29 января 2009, "Igor M. Liplianin" <liplianin@tut.by> wrote:
> Igor M. Liplianin schrieb:
> > п▓ я│п╬п╬п╠я┴п╣п╫п╦п╦ п╬я┌ 29 January 2009 20:07:32 gimli п╫п╟п©п╦я│п╟п╩(п╟):
> >> Hi,
> >>
> >> your patch seems to work.
> >
> > If it works, then I prepare more simple patch.
>
> Hi,
>
> you can also put my :
>
> Signed-off-by: Edgar Hucek <gimli@dark-green.com>
>
> to the list.
>
> cu
>
> Edgar (gimli) Hucek

Does simple patch work ?
I need your Acked-by :)

-- 
Igor M. Liplianin
Microsoft Windows Free Zone - Linux used for all Computing Tasks

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Mika Laitio]

>> Edgar (gimli) Hucek
>
> Does simple patch work ?
> I need your Acked-by :)

Hi, I have only saw one version of your patch in mailing list,
did you send the simpler version somewhere?

Mika

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Igor M. Liplianin]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

В сообщении от 29 January 2009 23:36:43 Mika Laitio написал(а):
> >> Edgar (gimli) Hucek
> >
> > Does simple patch work ?
> > I need your Acked-by :)
>
> Hi, I have only saw one version of your patch in mailing list,
> did you send the simpler version somewhere?
>
> Mika
Sorry, send it to Edgar only.
But it is unintentionally.

-- 
Igor M. Liplianin
Microsoft Windows Free Zone - Linux used for all Computing Tasks

[-- Attachment #2: hvr4000.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

# HG changeset patch
# User Igor M. Liplianin <liplianin@me.by>
# Date 1233253267 -7200
# Node ID 3542d1c1e03add577ce85175327701c552d14856
# Parent  4086371cea7b7f8b461e1a77513274aa43583c8c
Bug fix: Restore HVR-4000 tuning.

From: Igor M. Liplianin <liplianin@me.by>

Some cards uses cx24116 LNB_DC pin for LNB power control,
some not uses, some uses it different way, like HVR-4000.

Signed-off-by: Igor M. Liplianin <liplianin@me.by>

diff -r 4086371cea7b -r 3542d1c1e03a linux/drivers/media/dvb/frontends/cx24116.c
--- a/linux/drivers/media/dvb/frontends/cx24116.c	Sat Jan 17 17:23:31 2009 +0200
+++ b/linux/drivers/media/dvb/frontends/cx24116.c	Thu Jan 29 20:21:07 2009 +0200
@@ -1184,7 +1184,12 @@
 	if (ret != 0)
 		return ret;
 
-	return cx24116_diseqc_init(fe);
+	ret = cx24116_diseqc_init(fe);
+	if (ret != 0)
+		return ret;
+
+	/* HVR-4000 needs this */
+	return cx24116_set_voltage(fe, SEC_VOLTAGE_13);
 }
 
 /*

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[gimli]

Igor M. Liplianin schrieb:
> On 29 января 2009, "Igor M. Liplianin" <liplianin@tut.by> wrote:
>> Igor M. Liplianin schrieb:
>>> п▓ я│п╬п╬п╠я┴п╣п╫п╦п╦ п╬я┌ 29 January 2009 20:07:32 gimli п╫п╟п©п╦я│п╟п╩(п╟):
>>>> Hi,
>>>>
>>>> your patch seems to work.
>>> If it works, then I prepare more simple patch.
>> Hi,
>>
>> you can also put my :
>>
>> Signed-off-by: Edgar Hucek <gimli@dark-green.com>
>>
>> to the list.
>>
>> cu
>>
>> Edgar (gimli) Hucek
> 
> Does simple patch work ?
> I need your Acked-by :)
> 

Acked-by : Edgar Hucek <gimli@dark-green.com>

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Igor M. Liplianin]

В сообщении от 30 January 2009 02:10:18 gimli написал(а):
> Igor M. Liplianin schrieb:
> > On 29 января 2009, "Igor M. Liplianin" <liplianin@tut.by> wrote:
> >> Igor M. Liplianin schrieb:
> >>> п▓ я│п╬п╬п╠я┴п╣п╫п╦п╦ п╬я┌ 29 January 2009 20:07:32 gimli п╫п╟п©п╦я│п╟п╩(п╟):
> >>>> Hi,
> >>>>
> >>>> your patch seems to work.
> >>>
> >>> If it works, then I prepare more simple patch.
> >>
> >> Hi,
> >>
> >> you can also put my :
> >>
> >> Signed-off-by: Edgar Hucek <gimli@dark-green.com>
> >>
> >> to the list.
> >>
> >> cu
> >>
> >> Edgar (gimli) Hucek
> >
> > Does simple patch work ?
> > I need your Acked-by :)
>
> Acked-by : Edgar Hucek <gimli@dark-green.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

OK

Igor

Re: [linux-dvb] Broken Tuning on Wintv Nova HD S2

[Igor M. Liplianin]

В сообщении от 30 January 2009 02:10:18 gimli написал(а):
> Acked-by : Edgar Hucek <gimli@dark-green.com>
Explanation of using Signed-off-by, Acked-by and Tested-by.
	http://kerneltrap.org/node/8329

Sorry yet, but it seems Tested-by :)
Anyway, I already included your Tested-by clause.

-- 
Igor M. Liplianin
Microsoft Windows Free Zone - Linux used for all Computing Tasks