From: Manu Abraham <abraham.manu@gmail.com>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] [PATCH] saa716x: don't cast pointers to 32bit int
Date: Wed, 28 Jan 2009 03:51:22 +0400 [thread overview]
Message-ID: <497F9DFA.3000603@gmail.com> (raw)
In-Reply-To: <20090105170950.GA7131@dreamland.darkstar.lan>
Luca Tettamanti wrote:
> Pointers may be 64bit long, casting them to u32 is wrong.
> For doing math on the address unsigned long is guaranteed to have to correct
> size to hold the value of the pointer.
>
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
> ---
> Patch applies to HG repo.
>
> linux/drivers/media/dvb/saa716x/saa716x_dma.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: saa716x/linux/drivers/media/dvb/saa716x/saa716x_dma.c
> ===================================================================
> --- saa716x.orig/linux/drivers/media/dvb/saa716x/saa716x_dma.c 2008-12-27 21:35:04.000000000 +0100
> +++ saa716x/linux/drivers/media/dvb/saa716x/saa716x_dma.c 2008-12-27 21:35:28.000000000 +0100
> @@ -34,7 +34,7 @@
> return -ENOMEM;
> }
>
> - BUG_ON(!(((u32) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0));
> + BUG_ON(!(((unsigned long) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0));
>
> return 0;
> }
> @@ -126,9 +126,9 @@
> }
>
> /* align memory to page */
> - dmabuf->mem_virt = (void *) PAGE_ALIGN (((u32) dmabuf->mem_virt_noalign));
> + dmabuf->mem_virt = (void *) PAGE_ALIGN (((unsigned long) dmabuf->mem_virt_noalign));
>
> - BUG_ON(!((((u32) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0));
> + BUG_ON(!((((unsigned long) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0));
> } else {
> dmabuf->mem_virt = buf;
> }
>
Applied.
Thanks,
Manu
_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next prev parent reply other threads:[~2009-01-27 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 17:09 [linux-dvb] [PATCH] saa716x: don't cast pointers to 32bit int Luca Tettamanti
2009-01-27 23:51 ` Manu Abraham [this message]
2009-01-30 9:47 ` [linux-dvb] saa716x: HC82 does not work Martin Pauly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497F9DFA.3000603@gmail.com \
--to=abraham.manu@gmail.com \
--cc=kronos.it@gmail.com \
--cc=linux-dvb@linuxtv.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox