[linux-dvb] [PATCH] saa716x: don't cast pointers to 32bit int

[linux-dvb] [PATCH] saa716x: don't cast pointers to 32bit int

[Luca Tettamanti]

Pointers may be 64bit long, casting them to u32 is wrong.
For doing math on the address unsigned long is guaranteed to have to correct
size to hold the value of the pointer.

Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
---
 Patch applies to HG repo.

 linux/drivers/media/dvb/saa716x/saa716x_dma.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: saa716x/linux/drivers/media/dvb/saa716x/saa716x_dma.c
===================================================================
--- saa716x.orig/linux/drivers/media/dvb/saa716x/saa716x_dma.c	2008-12-27 21:35:04.000000000 +0100
+++ saa716x/linux/drivers/media/dvb/saa716x/saa716x_dma.c	2008-12-27 21:35:28.000000000 +0100
@@ -34,7 +34,7 @@
 		return -ENOMEM;
 	}
 
-	BUG_ON(!(((u32) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0));
+	BUG_ON(!(((unsigned long) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0));
 
 	return 0;
 }
@@ -126,9 +126,9 @@
 		}
 
 		/* align memory to page */
-		dmabuf->mem_virt = (void *) PAGE_ALIGN (((u32) dmabuf->mem_virt_noalign));
+		dmabuf->mem_virt = (void *) PAGE_ALIGN (((unsigned long) dmabuf->mem_virt_noalign));
 
-		BUG_ON(!((((u32) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0));
+		BUG_ON(!((((unsigned long) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0));
 	} else {
 		dmabuf->mem_virt = buf;
 	}

Luca
-- 
Porc i' mond che cio' sott i piedi!
V. Catozzo

_______________________________________________
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

Re: [linux-dvb] [PATCH] saa716x: don't cast pointers to 32bit int

[Manu Abraham]

Luca Tettamanti wrote:
> Pointers may be 64bit long, casting them to u32 is wrong.
> For doing math on the address unsigned long is guaranteed to have to correct
> size to hold the value of the pointer.
> 
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
> ---
>  Patch applies to HG repo.
> 
>  linux/drivers/media/dvb/saa716x/saa716x_dma.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Index: saa716x/linux/drivers/media/dvb/saa716x/saa716x_dma.c
> ===================================================================
> --- saa716x.orig/linux/drivers/media/dvb/saa716x/saa716x_dma.c	2008-12-27 21:35:04.000000000 +0100
> +++ saa716x/linux/drivers/media/dvb/saa716x/saa716x_dma.c	2008-12-27 21:35:28.000000000 +0100
> @@ -34,7 +34,7 @@
>  		return -ENOMEM;
>  	}
>  
> -	BUG_ON(!(((u32) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0));
> +	BUG_ON(!(((unsigned long) dmabuf->mem_ptab_phys % SAA716x_PAGE_SIZE) == 0));
>  
>  	return 0;
>  }
> @@ -126,9 +126,9 @@
>  		}
>  
>  		/* align memory to page */
> -		dmabuf->mem_virt = (void *) PAGE_ALIGN (((u32) dmabuf->mem_virt_noalign));
> +		dmabuf->mem_virt = (void *) PAGE_ALIGN (((unsigned long) dmabuf->mem_virt_noalign));
>  
> -		BUG_ON(!((((u32) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0));
> +		BUG_ON(!((((unsigned long) dmabuf->mem_virt) % SAA716x_PAGE_SIZE) == 0));
>  	} else {
>  		dmabuf->mem_virt = buf;
>  	}
> 

Applied.

Thanks,
Manu

_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[linux-dvb] saa716x: HC82 does not work

[Martin Pauly]

hey,
i have a avermedia hc82. This one should be working with the saa716x
driver, but it isnt. Im trying to get it working on a 64bit Ubuntu
System. I installed the latest driver and loaded kernel moduls
saa716x_core and saa716x_hybrid, but there still is no /dev/dvb
directory. 
The output of  lsmod | grep saa716x is: 
saa716x_hybrid         19464  0 
tda1004x               26244  1 saa716x_hybrid
saa716x_core           67892  1 saa716x_hybrid
dvb_core              113324  2 saa716x_hybrid,saa716x_core
i2c_core               36128  2 tda1004x,saa716x_core
so the modules are loaded.
Any ideas? Anything I can do to make it work?

Thanks,
Martin