* Re: saa716x compile warnings
[not found] <alpine.LSU.2.00.0901060621130.18397@fbirervta.pbzchgretzou.qr>
@ 2009-01-28 0:43 ` Manu Abraham
0 siblings, 0 replies; only message in thread
From: Manu Abraham @ 2009-01-28 0:43 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linux-media
Jan Engelhardt wrote:
> Hi,
>
>
> I noticed in a forum post that the saa716x driver spews warnings on
> x86_64:
>
> http://www.linux-club.de/viewtopic.php?f=41&t=100240
>
> /home/johnny/Documents/saa716x-e9cc5826649c/v4l/saa716x_dma.c:129:
> warning: cast from pointer to integer of different size
>
> as I look into the code (tip just moments ago), that seems to be largely
> true:
>
> /* align memory to page */
> dmabuf->mem_virt = (void *) PAGE_ALIGN (((u32) dmabuf->mem_virt_noalign));
>
> I always recommend building it not only on x86 to catch such errors.
> Truncating to (u32) is likely to be wrong for 64-bit systems!
>
Fixed now.
Thanks,
Manu
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-01-28 0:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <alpine.LSU.2.00.0901060621130.18397@fbirervta.pbzchgretzou.qr>
2009-01-28 0:43 ` saa716x compile warnings Manu Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox