From: Roel Kluin <roel.kluin@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-media@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong?
Date: Sat, 31 Jan 2009 17:52:05 +0100 [thread overview]
Message-ID: <498481B5.4030702@gmail.com> (raw)
vi drivers/media/common/saa7146_i2c.c +292
in saa7146_i2c_transfer(..., int retries)
{
int address_err = 0;
do {
...
if (...)
address_err++;
...
} while (retries--);
/* if every retry had an address error, exit right away */
if (address_err == retries) {
goto out;
}
...
}
this is wrong, isn't it?
next reply other threads:[~2009-01-31 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 16:52 Roel Kluin [this message]
2009-02-01 10:55 ` [PATCH] saa7146_i2c: saa7146_i2c_transfer() wrong? Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498481B5.4030702@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox