From: "H. Peter Anvin" <hpa@zytor.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
mingo@elte.hu, x86@kernel.org, sam@ravnborg.org,
jirislaby@gmail.com, gregkh@suse.de, davem@davemloft.net,
xyzzy@speakeasy.org, mchehab@infradead.org,
jens.axboe@oracle.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Make exported headers use strict posix types
Date: Thu, 05 Feb 2009 09:54:35 -0800 [thread overview]
Message-ID: <498B27DB.9000808@zytor.com> (raw)
In-Reply-To: <200902051707.55457.arnd@arndb.de>
Arnd Bergmann wrote:
> A number of standard posix types are used in exported headers, which
> is not allowed if __STRICT_KERNEL_NAMES is defined. Change them all
> to use the safe __kernel variant so that we can make __STRICT_KERNEL_NAMES
> the default.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> ---
> On Thursday 05 February 2009, H. Peter Anvin wrote:
>
>> I have been advocating for hacking headers_install for a while. That
>> takes care of the 106. The 15 *need* to be audited immediately, because
>> that is even likely to be actual manifest bugs.
>
> This is what I found, please review.
>
Indeed a lot of these look like real bugs, e.g. the use of off_t (which
may be 32 bits in userspace while __kernel_off_t is 64 bits.)
So these are, indeed, critical bug fixes and should go into 2.6.29.
Some of these changes may require changes in userspace code if userspace
has hacked around the problems. Those changes, though, really should
happen, too.
-hpa
next prev parent reply other threads:[~2009-02-05 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090204064307.GA18415@gondor.apana.org.au>
[not found] ` <200902051530.25897.arnd@arndb.de>
[not found] ` <498B0315.5080804@zytor.com>
2009-02-05 16:07 ` [PATCH] Make exported headers use strict posix types Arnd Bergmann
2009-02-05 17:54 ` H. Peter Anvin [this message]
2009-02-05 18:45 ` Arnd Bergmann
2009-02-17 9:38 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B27DB.9000808@zytor.com \
--to=hpa@zytor.com \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=jaswinder@kernel.org \
--cc=jens.axboe@oracle.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox