From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:44618 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032454AbeEXKvl (ORCPT ); Thu, 24 May 2018 06:51:41 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 04/11] media: vsp1: Remove unused display list structure field Date: Thu, 24 May 2018 13:51:37 +0300 Message-ID: <4994134.peM4qCLYyD@avalon> In-Reply-To: <9266418a78e00b185bb5ff131b54f289c7d8b016.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> References: <9266418a78e00b185bb5ff131b54f289c7d8b016.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:15 EEST Kieran Bingham wrote: > The vsp1 reference in the vsp1_dl_body structure is not used. > Remove it. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_dl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c > b/drivers/media/platform/vsp1/vsp1_dl.c index ec6fc21fabe0..b23e88cda49f > 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -44,7 +44,6 @@ struct vsp1_dl_entry { > * @list: entry in the display list list of bodies > * @free: entry in the pool free body list > * @pool: pool to which this body belongs > - * @vsp1: the VSP1 device > * @entries: array of entries > * @dma: DMA address of the entries > * @size: size of the DMA memory in bytes > @@ -58,7 +57,6 @@ struct vsp1_dl_body { > refcount_t refcnt; > > struct vsp1_dl_body_pool *pool; > - struct vsp1_device *vsp1; > > struct vsp1_dl_entry *entries; > dma_addr_t dma; -- Regards, Laurent Pinchart