From: Zhang Xiaobing <xbzhang@telegentsystems.com>
To: linux-dvb@linuxtv.org
Subject: [linux-dvb] A dvb-core code problem
Date: Fri, 13 Feb 2009 11:23:01 +0800 [thread overview]
Message-ID: <4994E795.6030700@telegentsystems.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
I found a code problem in dvb-core when I was debugging with my dvb driver.
The code in dvb_dvr_release() file dmxdev.c
/* TODO */
dvbdev->users--;
if(*dvbdev->users== -1* && dmxdev->exit==1) {
fops_put(file->f_op);
file->f_op = NULL;
mutex_unlock(&dmxdev->mutex);
"dvbdev->users== -1" should be changed to "dvbdev->users== 1", otherwise
driver may block forever in dvb_dmxdev_release() where a wakeup
condition is "dvbdev->users== 1".
Here is the code in dvb_dmxdev_release().
if (dmxdev->dvr_dvbdev->users > 1) {
wait_event(dmxdev->dvr_dvbdev->wait_queue,
*dmxdev->dvr_dvbdev->users==1*);
}
I hope it is right to post this message here.
--
Xiaobing Zhang
[-- Attachment #1.2: Type: text/html, Size: 1791 bytes --]
[-- Attachment #2: Type: text/plain, Size: 228 bytes --]
_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next reply other threads:[~2009-02-13 3:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 3:23 Zhang Xiaobing [this message]
2009-02-15 23:45 ` [linux-dvb] A dvb-core code problem CityK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4994E795.6030700@telegentsystems.com \
--to=xbzhang@telegentsystems.com \
--cc=linux-dvb@linuxtv.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox