From: CityK <cityk@rogers.com>
To: linux-media@vger.kernel.org
Cc: linux-dvb@linuxtv.org
Subject: Re: [linux-dvb] A dvb-core code problem
Date: Sun, 15 Feb 2009 18:45:17 -0500 [thread overview]
Message-ID: <4998A90D.3050403@rogers.com> (raw)
In-Reply-To: <4994E795.6030700@telegentsystems.com>
Zhang Xiaobing wrote:
> I found a code problem in dvb-core when I was debugging with my dvb
> driver.
>
> The code in dvb_dvr_release() file dmxdev.c
> /* TODO */
> dvbdev->users--;
> if(*dvbdev->users== -1* && dmxdev->exit==1) {
> fops_put(file->f_op);
> file->f_op = NULL;
> mutex_unlock(&dmxdev->mutex);
>
> "dvbdev->users== -1" should be changed to "dvbdev->users== 1",
> otherwise driver may block forever in dvb_dmxdev_release() where a
> wakeup condition is "dvbdev->users== 1".
>
> Here is the code in dvb_dmxdev_release().
>
> if (dmxdev->dvr_dvbdev->users > 1) {
> wait_event(dmxdev->dvr_dvbdev->wait_queue,
> *dmxdev->dvr_dvbdev->users==1*);
> }
>
> I hope it is right to post this message here.
Hi Zhang, could you post a patch to the linux-media mail list; for
general info see here:
http://www.linuxtv.org/wiki/index.php/Development:_How_to_submit_patches
prev parent reply other threads:[~2009-02-15 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 3:23 [linux-dvb] A dvb-core code problem Zhang Xiaobing
2009-02-15 23:45 ` CityK [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4998A90D.3050403@rogers.com \
--to=cityk@rogers.com \
--cc=linux-dvb@linuxtv.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox