public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: wk <handygewinnspiel@gmx.de>
To: linux-media@vger.kernel.org
Subject: linux/include/dvb/frontend.h : missing capability flags
Date: Wed, 18 Feb 2009 19:41:34 +0100	[thread overview]
Message-ID: <499C565E.3070108@gmx.de> (raw)

Some time ago two new members were added in frontend.h  to
enum fe_code_rate:

-  FEC_3_5
-  FEC_9_10

But the matching capability flags for that are still missing, signalling 
applications support for those:

- FE_CAN_FEC_3_5
- FE_CAN_FEC_9_10

It would be possible to use  0x1000000, 0x2000000 for that to get some 
consistent and logically understandable file,
but there would be also the second possibility to remove
    FE_CAN_FEC_1_2
    FE_CAN_FEC_2_3
    FE_CAN_FEC_3_4
    FE_CAN_FEC_4_5
    FE_CAN_FEC_5_6
    FE_CAN_FEC_6_7
    FE_CAN_FEC_7_8
    FE_CAN_FEC_8_9

This would assume, that all related drivers supports all of these (what 
they should do anyway..).
This would also make sense, since all other frontend related properties 
except modulation are also not explicitly stated
(for example there's also no "FE_CAN_BANDWIDTH_6_MHZ or 
FE_CAN_GUARD_INTERVAL_1_8")

Opinions?


Secondly, inside frontend.h  "DTV_API_VERSION" is defined twice, line 
302 and 303:

#define DTV_API_VERSION                35
#define DTV_API_VERSION                35



Regards,
Winfried









                 reply	other threads:[~2009-02-18 18:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499C565E.3070108@gmx.de \
    --to=handygewinnspiel@gmx.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox