From: CityK <cityk@rogers.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: sebastian.blanes@gmail.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] Add "Sony PlayTV" to dibcom driver
Date: Sun, 22 Feb 2009 23:32:36 -0500 [thread overview]
Message-ID: <49A226E4.3050009@rogers.com> (raw)
In-Reply-To: <20090222233839.566f2870@pedra.chehab.org>
Mauro Carvalho Chehab wrote:
> On Sun, 22 Feb 2009 15:04:13 -0500 CityK <cityk@rogers.com> wrote:
>> I don't think the Patchwork tool picked it up, as I don't see it in the
>> queue :(
>> http://patchwork.kernel.org/project/linux-media/list/
>>
>> I'm wondering it the quotations in the subject line are enough to throw
>> the script off. Mauro, any ideas?
>>
>
> In general those tools to pick and work with scripts don't like very much
> inlined patches, although it generally works.
>
> Also, it requires that the patch is not line wrapped.
>
> In this specific case, the patch is line-wrapped:
>
> --- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2009-02-18
> 13:49:37.000000000 +0100
> +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2009-02-18
> 23:45:43.000000000 +0100
>
> instead of:
>
> --- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2009-02-18 13:49:37.000000000 +0100
> +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2009-02-18 23:45:43.000000000 +0100
>
>
> So, it doesn't apply as a patch and patchwork discards it.
Ahh, thanks for the explanation. Its strange that they are not tailored
for inline patches, given that that is precisely the preferred and
prescribed submission method!
next prev parent reply other threads:[~2009-02-23 4:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 9:20 [PATCH] Add "Sony PlayTV" to dibcom driver sebastian.blanes
2009-02-22 20:04 ` CityK
2009-02-23 2:38 ` Mauro Carvalho Chehab
2009-02-23 4:32 ` CityK [this message]
2009-02-23 10:17 ` Mauro Carvalho Chehab
2009-02-24 17:51 ` sebastian.blanes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A226E4.3050009@rogers.com \
--to=cityk@rogers.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=sebastian.blanes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox