[PATCH] Add "Sony PlayTV" to dibcom driver

[PATCH] Add "Sony PlayTV" to dibcom driver

[sebastian.blanes]

This patch introduces support for DVB-T for the following dibcom based card:
  Sony PlayTV (USB-ID: 1415:0003)

Signed-off-by: Sebastián Blanes <sebastian.blanes@gmail.com>

diff -uprN -X dontdiff.txt
v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	2009-02-18
13:49:37.000000000 +0100
+++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	2009-02-19
00:35:30.000000000 +0100
@@ -1419,6 +1419,7 @@ struct usb_device_id dib0700_usb_id_tabl
 	{ USB_DEVICE(USB_VID_TERRATEC,	USB_PID_TERRATEC_CINERGY_T_EXPRESS) },
 	{ USB_DEVICE(USB_VID_TERRATEC,
 			USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY_2) },
+	{ USB_DEVICE(USB_VID_SONY,	USB_PID_SONY_PLAYTV) },
 	{ 0 }		/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
@@ -1684,7 +1685,7 @@ struct dvb_usb_device_properties dib0700
 			}
 		},

-		.num_device_descs = 5,
+		.num_device_descs = 6,
 		.devices = {
 			{   "DiBcom STK7070PD reference design",
 				{ &dib0700_usb_id_table[17], NULL },
@@ -1705,6 +1706,10 @@ struct dvb_usb_device_properties dib0700
 			{  "Terratec Cinergy DT USB XS Diversity",
 				{ &dib0700_usb_id_table[43], NULL },
 				{ NULL },
+			},
+			{   "Sony PlayTV",
+				{ &dib0700_usb_id_table[44], NULL },
+				{ NULL },
 			}
 		},
 		.rc_interval      = DEFAULT_RC_INTERVAL,
diff -uprN -X dontdiff.txt
v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
13:49:37.000000000 +0100
+++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
23:45:43.000000000 +0100
@@ -55,6 +55,7 @@
 #define USB_VID_GIGABYTE			0x1044
 #define USB_VID_YUAN				0x1164
 #define USB_VID_XTENSIONS			0x1ae7
+#define USB_VID_SONY				0x1415

 /* Product IDs */
 #define USB_PID_ADSTECH_USB2_COLD			0xa333
@@ -237,5 +238,6 @@
 #define USB_PID_XTENSIONS_XD_380			0x0381
 #define USB_PID_TELESTAR_STARSTICK_2			0x8000
 #define USB_PID_MSI_DIGI_VOX_MINI_III                   0x8807
+#define USB_PID_SONY_PLAYTV		                0x0003

 #endif

Re: [PATCH] Add "Sony PlayTV" to dibcom driver

[CityK]

I don't think the Patchwork tool picked it up, as I don't see it in the
queue :(
http://patchwork.kernel.org/project/linux-media/list/

I'm wondering it the quotations in the subject line are enough to throw
the script off.  Mauro, any ideas?

Re: [PATCH] Add "Sony PlayTV" to dibcom driver

[Mauro Carvalho Chehab]

On Sun, 22 Feb 2009 15:04:13 -0500
CityK <cityk@rogers.com> wrote:

> I don't think the Patchwork tool picked it up, as I don't see it in the
> queue :(
> http://patchwork.kernel.org/project/linux-media/list/
> 
> I'm wondering it the quotations in the subject line are enough to throw
> the script off.  Mauro, any ideas?

In general those tools to pick and work with scripts don't like very much
inlined patches, although it generally works.

Also, it requires that the patch is not line wrapped.

In this specific case, the patch is line-wrapped:

--- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
13:49:37.000000000 +0100
+++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
23:45:43.000000000 +0100

instead of:

--- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18 13:49:37.000000000 +0100
+++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18 23:45:43.000000000 +0100


So, it doesn't apply as a patch and patchwork discards it.

Sebastian, 

could you please send it again, being sure that your email won't break long
lines?


Cheers,
Mauro

Re: [PATCH] Add "Sony PlayTV" to dibcom driver

[CityK]

Mauro Carvalho Chehab wrote:
> On Sun, 22 Feb 2009 15:04:13 -0500 CityK <cityk@rogers.com> wrote:
>> I don't think the Patchwork tool picked it up, as I don't see it in the
>> queue :(
>> http://patchwork.kernel.org/project/linux-media/list/
>>
>> I'm wondering it the quotations in the subject line are enough to throw
>> the script off.  Mauro, any ideas?
>>     
>
> In general those tools to pick and work with scripts don't like very much
> inlined patches, although it generally works.
>
> Also, it requires that the patch is not line wrapped.
>
> In this specific case, the patch is line-wrapped:
>
> --- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
> 13:49:37.000000000 +0100
> +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
> 23:45:43.000000000 +0100
>
> instead of:
>
> --- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18 13:49:37.000000000 +0100
> +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18 23:45:43.000000000 +0100
>
>
> So, it doesn't apply as a patch and patchwork discards it.

Ahh, thanks for the explanation. Its strange that they are not tailored
for inline patches, given that that is precisely the preferred and
prescribed submission method!

Re: [PATCH] Add "Sony PlayTV" to dibcom driver

[Mauro Carvalho Chehab]

On Sun, 22 Feb 2009 23:32:36 -0500
CityK <cityk@rogers.com> wrote:

> Mauro Carvalho Chehab wrote:
> > On Sun, 22 Feb 2009 15:04:13 -0500 CityK <cityk@rogers.com> wrote:
> >> I don't think the Patchwork tool picked it up, as I don't see it in the
> >> queue :(
> >> http://patchwork.kernel.org/project/linux-media/list/
> >>
> >> I'm wondering it the quotations in the subject line are enough to throw
> >> the script off.  Mauro, any ideas?
> >>     
> >
> > In general those tools to pick and work with scripts don't like very much
> > inlined patches, although it generally works.
> >
> > Also, it requires that the patch is not line wrapped.
> >
> > In this specific case, the patch is line-wrapped:
> >
> > --- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
> > 13:49:37.000000000 +0100
> > +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18
> > 23:45:43.000000000 +0100
> >
> > instead of:
> >
> > --- v4l-dvb-359d95e1d541-vanilla/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18 13:49:37.000000000 +0100
> > +++ v4l-dvb-359d95e1d541/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	2009-02-18 23:45:43.000000000 +0100
> >
> >
> > So, it doesn't apply as a patch and patchwork discards it.
> 
> Ahh, thanks for the explanation. Its strange that they are not tailored
> for inline patches, given that that is precisely the preferred and
> prescribed submission method!

Ops! I mean the opposite. It is fine for inlined patch. mime patches may have
troubles. 

In fact, patchwork supports mime types, provided that the emailer describe
the attachment with the proper type (text/x-patch). It the mime is text/plain,
it should work also. However, if the emailer sends it with a different type, the
attachment will be discarded.


Cheers,
Mauro

Re: [PATCH] Add "Sony PlayTV" to dibcom driver

[sebastian.blanes]

2009/2/23 Mauro Carvalho Chehab <mchehab@infradead.org>:
> [...]
> Sebastian,
>
> could you please send it again, being sure that your email won't break long
> lines?
>

diff -uprN -X dontdiff.txt
a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	Wed Feb 18 13:49:37 2009
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	Tue Feb 24 18:23:12 2009
@@ -1419,6 +1419,7 @@ struct usb_device_id dib0700_usb_id_tabl
 	{ USB_DEVICE(USB_VID_TERRATEC,	USB_PID_TERRATEC_CINERGY_T_EXPRESS) },
 	{ USB_DEVICE(USB_VID_TERRATEC,
 			USB_PID_TERRATEC_CINERGY_DT_XS_DIVERSITY_2) },
+	{ USB_DEVICE(USB_VID_SONY,	USB_PID_SONY_PLAYTV) },
 	{ 0 }		/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
@@ -1684,7 +1685,7 @@ struct dvb_usb_device_properties dib0700
 			}
 		},

-		.num_device_descs = 5,
+		.num_device_descs = 6,
 		.devices = {
 			{   "DiBcom STK7070PD reference design",
 				{ &dib0700_usb_id_table[17], NULL },
@@ -1705,7 +1706,11 @@ struct dvb_usb_device_properties dib0700
 			{  "Terratec Cinergy DT USB XS Diversity",
 				{ &dib0700_usb_id_table[43], NULL },
 				{ NULL },
-			}
+			},
+			{  "Sony PlayTV",
+				{ &dib0700_usb_id_table[44], NULL },
+				{ NULL },
+			}		
 		},
 		.rc_interval      = DEFAULT_RC_INTERVAL,
 		.rc_key_map       = dib0700_rc_keys,
diff -uprN -X dontdiff.txt
a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	Wed Feb 18 13:49:37 2009
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	Tue Feb 24 18:24:59 2009
@@ -55,6 +55,7 @@
 #define USB_VID_GIGABYTE			0x1044
 #define USB_VID_YUAN				0x1164
 #define USB_VID_XTENSIONS			0x1ae7
+#define USB_VID_SONY				0x1415

 /* Product IDs */
 #define USB_PID_ADSTECH_USB2_COLD			0xa333
@@ -237,5 +238,6 @@
 #define USB_PID_XTENSIONS_XD_380			0x0381
 #define USB_PID_TELESTAR_STARSTICK_2			0x8000
 #define USB_PID_MSI_DIGI_VOX_MINI_III                   0x8807
+#define USB_PID_SONY_PLAYTV				0x0003

 #endif