public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Wool <vital@embeddedalley.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: video4linux-list@redhat.com, em28xx@mcentral.de
Subject: Re: em28xx: Compro VideoMate For You sound problems
Date: Wed, 25 Feb 2009 22:25:37 +0300	[thread overview]
Message-ID: <49A59B31.9080407@embeddedalley.com> (raw)
In-Reply-To: <20090225153323.66778ad2@caramujo.chehab.org>

Mauro,

Mauro Carvalho Chehab wrote:
>   
>> diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
>> index 100f90a..f300e74 100644
>> --- a/drivers/media/video/em28xx/em28xx-cards.c
>> +++ b/drivers/media/video/em28xx/em28xx-cards.c
>> @@ -1245,14 +1245,17 @@ struct em28xx_board em28xx_boards[] = {
>>  		.tda9887_conf = TDA9887_PRESENT,
>>  		.decoder      = EM28XX_TVP5150,
>>  		.adecoder     = EM28XX_TVAUDIO,
>> +		.tuner_gpio   = default_tuner_gpio,
>>     
>
> You don't need a tuner gpio. This is used basically by xc3028 based devices, in
> order to reset it during software upload.
>
> Instead, we should add another gpio here, for mute. This should be called in a
> place where we can remove the unwanted noise (e. g. at the beginning of the
> device setup logic), and when mute is selected by the audio functions.
>   
I'm not quite sure I understood. Do I need to add another field to the 
board structure and use it where appropriate?

Thanks,
   Vitaly

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2009-02-25 19:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24  7:47 em28xx: Compro VideoMate For You sound problems Vitaly Wool
2009-02-25  2:42 ` Mauro Carvalho Chehab
2009-02-25 12:42   ` Vitaly Wool
2009-02-25 12:07     ` Mauro Carvalho Chehab
2009-02-25 15:46       ` Vitaly Wool
2009-02-25 13:18         ` Mauro Carvalho Chehab
2009-02-25 16:58           ` Vitaly Wool
2009-02-25 17:11           ` Vitaly Wool
2009-02-25 18:33             ` Mauro Carvalho Chehab
2009-02-25 19:25               ` Vitaly Wool [this message]
2009-02-25 23:40                 ` Mauro Carvalho Chehab
2009-02-27 15:12                   ` Vitaly Wool
2009-02-27 15:43                     ` Vitaly Wool
2009-02-28  0:40                       ` Mauro Carvalho Chehab
2009-02-28  4:49                         ` Vitaly Wool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A59B31.9080407@embeddedalley.com \
    --to=vital@embeddedalley.com \
    --cc=em28xx@mcentral.de \
    --cc=mchehab@infradead.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox