Re: em28xx: Compro VideoMate For You sound problems

[Vitaly Wool <vital@embeddedalley.com>]

Mauro Carvalho Chehab wrote:
> On Fri, 27 Feb 2009 18:43:07 +0300
> Vitaly Wool <vital@embeddedalley.com> wrote:
>
>   
>> Vitaly Wool wrote:
>>
>>     
>>> Ok, I'm working on that. The problem as of now is that it works fine on 
>>> 2.6.26 and doesn't work with 2.6.29-rc5.
>>> I'll get back to you when I find out the reason.
>>>       
>> And here's the patch that solves the problem:
>>
>> diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
>> index 5aeccb3..ae4b231 100644
>> --- a/drivers/media/video/tvaudio.c
>> +++ b/drivers/media/video/tvaudio.c
>> @@ -169,12 +169,14 @@ static int chip_write(struct CHIPSTATE *chip, int subaddr, int val)
>>  			return -1;
>>  		}
>>  	} else {
>> +#if 0
>>  		if (subaddr + 1 >= ARRAY_SIZE(chip->shadow.bytes)) {
>>  			v4l2_info(sd,
>>  				"Tried to access a non-existent register: %d\n",
>>  				subaddr);
>>  			return -EINVAL;
>>  		}
>> +#endif
>>  
>>  		v4l2_dbg(1, debug, sd, "chip_write: reg%d=0x%x\n",
>>  			subaddr, val);
>>
>>
>>
>> Apparently this check is bogus. The patch for em28xx stuff will follow, after some cleanups.
>>     
>
> Hmm... the check is to avoid accessing an out of range registrer cache. Could you
> please send me the errors generated by the v4l2_info msg?
>   
The ARRAY_SIZE actually is 65 in this situation. I've no idea yet where 
that is derived from.
The "false erroneous" access is to register 255, for quick configuration:

#define TDA9874A_ESP            0xFF    /* easy standard progr. 
(tda9874a) */

So either the bytes array is set up incorrectly, or the check is bogus, 
IMHO.

Thanks,
   Vitaly

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list