From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([192.100.122.230]:44796 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753768AbZCCHJr (ORCPT ); Tue, 3 Mar 2009 02:09:47 -0500 Message-ID: <49ACD793.7000505@nokia.com> Date: Tue, 03 Mar 2009 09:09:07 +0200 From: Sakari Ailus Reply-To: sakari.ailus@maxwell.research.nokia.com MIME-Version: 1.0 To: "DongSoo(Nathaniel) Kim" CC: "Aguirre Rodriguez, Sergio Alberto" , "linux-omap@vger.kernel.org" , "video4linux-list@redhat.com" , "Nagalla, Hari" , "Toivonen Tuukka.O (Nokia-D/Oulu)" , "linux-media@vger.kernel.org" Subject: Re: [REVIEW PATCH 09/14] OMAP: CAM: Add ISP Core References: <5e9665e10903020009y7fe7d0d0j356708e1c3149cac@mail.gmail.com> In-Reply-To: <5e9665e10903020009y7fe7d0d0j356708e1c3149cac@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: DongSoo(Nathaniel) Kim wrote: > Hello, > > reviewing ISP driver, I found that we've got no querymenu support in > ISP and also omap3 camera interface driver. > > +/** > + * struct vcontrol - Video control structure. > + * @qc: V4L2 Query control structure. > + * @current_value: Current value of the control. > + */ > +static struct vcontrol { > + struct v4l2_queryctrl qc; > + int current_value; > +} video_control[] = { > > > > + { > + { > + .id = V4L2_CID_PRIVATE_ISP_COLOR_FX, > + .type = V4L2_CTRL_TYPE_INTEGER, > + .name = "Color Effects", > + .minimum = PREV_DEFAULT_COLOR, > + .maximum = PREV_BW_COLOR, > + .step = 1, > + .default_value = PREV_DEFAULT_COLOR, > + }, > + .current_value = PREV_DEFAULT_COLOR, > + } > +}; I don't see these lines in Sergio's patch you replied to. I have V4L2_CTRL_TYPE_MENU there instead of V4L2_CTRL_TYPE_INTEGER. > I think we should make it menu type for this color FX control. > If that kind of control has no menu information, user has no way to > figure out what kind of FX supported by device. > BTW if we make querymenu support in omap3 camera subsystem, we should > make querymenu support for v4l2 int device also. > I think I've seen before a patch which intent to use querymenu in v4l2 > int device, but no patch for omap3 ISP and camera interface. > Can I make a patch and post on linux-omap, linux-media list? of course > if you don't mind. > Or...am I digging wrong way? I mean.. querymenu for omap3 camera subsystem. > Please let me know :) I'm always happy to get patches. :-) But my understanding is that querymenu is implemented in ISP and camera drivers --- though I haven't tried it myself. Cheers, -- Sakari Ailus sakari.ailus@maxwell.research.nokia.com