Re: [RFC][PATCH 0/2] Sensor orientation reporting

[Hans de Goede <j.w.r.degoede@hhs.nl>]

Adam Baker wrote:
> Hi all,
> 
> I've finally got round to writing a sample patch to support the proposed 
> mechanism of reporting sensor orientation to user space. It is split into 2 
> parts, part 1 contains the kernel changes and part 2 the libv4l changes. In 
> order to keep the patch simple I haven't attempted to add support to libv4l 
> for HFLIP and VFLIP but just assumed for now that if a cam needs one then it 
> needs both. If the basic idea gets accepted then fixing that is purely a user 
> space change.
> 
> I also haven't provided an implementation of VIDIOC_ENUMINPUT in libv4l that 
> updates the flags to reflect what libv4l has done to the image. Hans Verkuil 
> originally said he wanted to leave the orientation information available to 
> the user app but I suspect that is actually undesirable. If an app is 
> designed to work without libv4l and to re-orient an image as required then if 
> someone runs it with the LD_PRELOAD capability of libv4l then correct 
> operation depends upon reporting the corrected orientation to the app, not 
> the original orientation.
> 

Thanks!

Both patches look good to me.

Regards,

Hans