public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: linux-media@vger.kernel.org
Cc: Ricardo Jorge da Fonseca Marques Ferreira <storm@sys49152.net>
Subject: v4l parent for usb device interface or device?
Date: Wed, 25 Mar 2009 11:18:31 +0100	[thread overview]
Message-ID: <49CA04F7.4010603@redhat.com> (raw)

<take 2 this time to the new list, hoping it gets some more attention>

Hi,

Today it came to my attention (through a libv4l bugreport) that
the uvc driver and the gspca driver handle the setting of
the v4l parent for usb webcams differently.

The probe function for an usb driver gets passed in a
"struct usb_interface *intf" parameter.

uvc sets parent to:

vdev->parent = &intf->dev;

gspca uses:
struct usb_device *dev = interface_to_usbdev(intf);
vdev.parent = &dev->dev;

Looking at what for example the usb mass-storage driver
does (with my multi function printer/scanner with cardreader),
which matches UVC, and thinking about how this is supposed to
work with multifunction devices in general, I believe the uvc
driver behaviour is correct, but before writing a patch for
gspca, I thought it would be good to first discuss this on the
list.

So what do you think ?

Thanks & Regards,

Hans


p.s.

This mainly influences what the /sys/class/video4linux/video#/device
symlink will point to, which libv4l uses.

             reply	other threads:[~2009-03-25 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 10:18 Hans de Goede [this message]
2009-03-25 14:51 ` v4l parent for usb device interface or device? Laurent Pinchart
  -- strict thread matches above, loose matches on Subject: below --
2009-03-25 14:58 Hans Verkuil
2009-03-26 12:29 ` Hans de Goede
2009-03-26 18:14   ` Theodore Kilgore
2009-03-27  0:51   ` Janne Grunau
2009-03-27  1:31     ` David Brownell
2009-03-27 20:59       ` Janne Grunau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CA04F7.4010603@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=storm@sys49152.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox