[PATCH]: gspca: use usb interface as parent

[PATCH]: gspca: use usb interface as parent

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

As discussed in the:
"v4l parent for usb device interface or device?"
thread, here is a patch for gspca to make it use
the usb interface as its parent device, instead
of the usb device.

Regards,

Hans

p.s.

I'll also push a patch to my libv4l repo, with
matching libv4l changes so that libv4l's upside
down cam detections stays working with this change.

Note: this libv4l patch also fixes libv4l upside
down detection for the new device numbering style.

[-- Attachment #2: gspca-use-usb-interface-as-parent.patch --]
[-- Type: text/plain, Size: 513 bytes --]

diff -r c28651a2c2c3 linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c	Thu Mar 26 09:44:15 2009 +0100
+++ b/linux/drivers/media/video/gspca/gspca.c	Fri Mar 27 10:32:24 2009 +0100
@@ -1958,7 +1958,7 @@
 
 	/* init video stuff */
 	memcpy(&gspca_dev->vdev, &gspca_template, sizeof gspca_template);
-	gspca_dev->vdev.parent = &dev->dev;
+	gspca_dev->vdev.parent = &intf->dev;
 	gspca_dev->module = module;
 	gspca_dev->present = 1;
 	ret = video_register_device(&gspca_dev->vdev,

Re: [PATCH]: gspca: use usb interface as parent

[Jean-Francois Moine]

On Fri, 27 Mar 2009 10:35:43 +0100
Hans de Goede <hdegoede@redhat.com> wrote:

> Hi all,

Hi Hans,

> As discussed in the:
> "v4l parent for usb device interface or device?"
> thread, here is a patch for gspca to make it use
> the usb interface as its parent device, instead
> of the usb device.
	[snip]

Applied, thanks.

This patch may solve the microphone problem that some people have...

Cheers.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/